WIP: fix: Hydra bugfix sweep #1099

Draft

nex wants to merge 7 commits from nex/fix/event-auth into main

pull from: nex/fix/event-auth

merge into: continuwuation:main

continuwuation:main

continuwuation:renovate/lock-file-maintenance

continuwuation:renovate/rand-0.x

continuwuation:renovate/opentelemetry-rust-monorepo

continuwuation:renovate/axum-monorepo

continuwuation:jade/flake-clone

continuwuation:renovate/rust-patch-updates

continuwuation:ginger/upload-rpms-on-schedule

continuwuation:nex/fix/incoming-fetch

continuwuation:nex/fix/upgrade

continuwuation:tom/ci-fedora-rpm

continuwuation:nex/fed-improvements

continuwuation:jade/ci-release-fix

continuwuation:jade/rocksdb-10-5

continuwuation:illegal-car-mods

continuwuation:ginger/fix-msc4133-migration

continuwuation:ginger/migrate-busted-tz

continuwuation:hydra/public

continuwuation:tom/max-perf-docs

continuwuation:nex/feat/manual-extremities

continuwuation:nex/feat/async-media

continuwuation:nex/feat/fast-joins-hack-do-not-use-DO-NOT-USE

continuwuation:nex/feat/better-logging

continuwuation:trigger-ci-so-latest-isnt-on-illegal-car-mods

continuwuation:nex/feat/pins-backfill

continuwuation:jade/tuwunel-2025-06-old

continuwuation:jade/ai-slop-db-docs

continuwuation:nex/fix-create-auth

continuwuation:jade/version-stats

continuwuation:jade/read-receipts

continuwuation:dahsa_uwu/axum-0.8

continuwuation:jade/rust-toolchain-no-targets

continuwuation:jade/logging-features

continuwuation:jade/syncv5-typing

continuwuation:jade/msc2815

continuwuation:jade/relations

continuwuation:jade/purge-sync-tokens

continuwuation:morguldir/see-eye

continuwuation:jade/css-small-screen

continuwuation:nex/wip-751

continuwuation:tuwunel-rebase

continuwuation:test

continuwuation:oddlid/rename-admin-room-bot

continuwuation:strawberry/nix-ci-stuff

continuwuation:strawberry/valgrind

continuwuation:strawberry/morgs-snake-sync-jason-main

continuwuation:newer-media-endpoints

continuwuation:folly-coroutines-async-io

continuwuation:federation-retry-timer-port

continuwuation:bad-attempt-at-extracting-homeserver-signing-key

continuwuation:room-deletion-attempt-do-not-use

Conversation 3 Commits 7 Files changed 4 +98 -52

nex commented 2025-10-04 01:50:25 +00:00

Owner

Copy link

fixes #1097, fixes #1093, closes #1060 (by removing the logic for now, depending on a future replacement via #1061)

Also fixes issues with kicking and unbanning and redacting

fixes #1097, fixes #1093, closes #1060 (by removing the logic for now, depending on a future replacement via #1061) Also fixes issues with kicking and unbanning and redacting

nex added 1 commit 2025-10-04 01:50:25 +00:00

fix: Unbans and kicks incorrectly checked creatorship in !v12 dcce1fbc5a

nex requested review from Jade 2025-10-04 20:58:22 +00:00

nex added this to the 0.5.0 milestone 2025-10-04 20:58:23 +00:00

nex added the

Bug

Matrix/Core

Matrix/Hydra

labels 2025-10-04 20:58:37 +00:00

Jade approved these changes 2025-10-04 22:02:16 +00:00

Dismissed

nex changed title from fix: Unbans and kicks incorrectly checked creatorship in !v12 to WIP: fix: Several event auth issues 2025-10-04 23:33:47 +00:00

nex dismissed Jade's review 2025-10-04 23:33:53 +00:00

Reason:

PR scope changed

nex added 1 commit 2025-10-05 17:27:33 +00:00

fix: Temporarily disable policy checking on pdu create (it is outdated anyway) 735e0782f3

nex added 2 commits 2025-10-08 20:34:22 +00:00

fix: Weird re-application of partially resolved state 5fa3d65fa4

fix: Don't check restricted join rules for invite joins 0842b8945a

nex changed title from WIP: fix: Several event auth issues to WIP: fix: Hydra bugfix sweep 2025-10-08 20:46:26 +00:00

nex force-pushed nex/fix/event-auth from 0842b8945a to c4e7e7c655 2025-10-08 21:06:57 +00:00 Compare

nex added 1 commit 2025-10-08 21:28:37 +00:00

fix: Inverted creatorship check c3ffa68d68

nex added 1 commit 2025-10-08 23:46:33 +00:00

fix: Incorrect interpretation of 5.5.4 9c355cdfa9

nex added 1 commit 2025-10-12 21:31:17 +00:00

fix: Kicks in !v12 are impossible 57e905b7b1

nex commented 2025-10-12 21:47:01 +00:00

Author

Owner

Copy link

Waiting until #1094 is fixed before un-drafting this (aiming to tackle it in this PR also)

Waiting until #1094 is fixed before un-drafting this (aiming to tackle it in this PR also)

nex force-pushed nex/fix/event-auth from 57e905b7b1 to e7b4b45ec4 2025-10-15 02:50:02 +00:00 Compare

nex commented 2025-10-15 12:45:30 +00:00

Author

Owner

Copy link

dont merge v12 is broken again lol

dont merge v12 is broken again lol

All checks were successful

Hide all checks

Documentation / Build and Deploy Documentation (pull_request) Successful in 1m5s

Details

Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m48s

Required

Details

Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 8m11s

Details

Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 7m21s

Details

Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 22s

Details

Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 19m21s

Required

Details

Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 15m59s

Details

Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 16m4s

Details

Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 20s

Details

This pull request has changes conflicting with the target branch.

• src/service/rooms/timeline/create.rs

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin nex/fix/event-auth:nex/fix/event-auth

git switch nex/fix/event-auth

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Bug

Something isn't working as intended

  

Cherry-picking

Commits picked from other conduit projects

  

Database

This requires or includes changes to the database

  

Dependencies

Something dependency related

  

Dependencies/Renovate

Automatic dependency upgrades by Renovate

  

Difficulty

Easy

Low difficulty to implement - touches few parts of the codebase, low complexity

  

Difficulty

Hard

High difficulty to implement - touches many parts of the codebase, high complexity

  

Difficulty

Medium

Medium difficulty to implement - touches more parts of the codebase, higher complexity

  

Documentation

Improvements or additions to documentation

  

Enhancement

New feature or request

  

Good first issue

Good for newcomers

  

Help wanted

Additional eyes and keyboards are required for this one

  

Inherited

Issues that have been inhereted from the project pre-fork

  

Matrix/Administration

Features pertaining to homeserver administration

  

Matrix/Appservices

Features pertaining to the appservice API

  

Matrix/Auth

Features pertaining to authentication

  

Matrix/Client

Features pertaining to client-to-server interactions

  

Matrix/Core

Issues relating to core matrix functionality, such as state resolution and PDU formats

  

Matrix/Federation

Features pertaining to server-to-server interactions

  

Matrix/Hydra

Issues related to room version 12 and related changes (temporary label)

  

Matrix/MSC

Features pertaining to unstable matrix features

  

Matrix/Media

Features pertaining to media interactions

  

Meta

Related to housekeeping, maintenance, or other repo-meta.

  

Meta/CI

Issues related to CI changes

  

Meta/Packaging

Packaging

  

Priority

Blocking

This issue is blocking the next release

  

Priority

High

This issue is very important

  

Priority

Low

This issue is of a rather low priority

  

Security

This item is related to general security

  

Status/Blocked

This pull request or issue is currently blocked from being merged/closed

  

Status

Confirmed

This issue has enough information and is confirmed

  

Status

Duplicate

This issue or pull request already exists

  

Status

Invalid

This issue doesn't seem right

  

Status

Needs Investigation

This issue needs further investigation

  

To-Merge

  

Wont fix

This will not be worked on

  

old/ci/cd

Ci/CD

Archived

  

old/rust

Pull requests that update Rust code

Archived

No labels

Bug

Cherry-picking

Database

Dependencies

Dependencies/Renovate

Difficulty

Easy

Difficulty

Hard

Difficulty

Medium

Documentation

Enhancement

Good first issue

Help wanted

Inherited

Matrix/Administration

Matrix/Appservices

Matrix/Auth

Matrix/Client

Matrix/Core

Matrix/Federation

Matrix/Hydra

Matrix/MSC

Matrix/Media

Meta

Meta/CI

Meta/Packaging

Priority

Blocking

Priority

High

Priority

Low

Security

Status/Blocked

Status

Confirmed

Status

Duplicate

Status

Invalid

Status

Needs Investigation

To-Merge

Wont fix

old/ci/cd

old/rust

Milestone

Clear milestone

No items

No milestone

0.5.0

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

continuwuation/continuwuity!1099

No description provided.