continuwuation/continuwuity
continuwuation/continuwuity
13
35
Fork 34
Code Issues 103 Pull requests 20 Releases 20 Packages 3 Activity Actions

fix: Hydra bugfix sweep #1099

Merged
nex merged 7 commits from nex/fix/event-auth into main 2025-10-28 17:40:48 +00:00
Conversation 6 Commits 7 Files changed 4 +96 -38
nex commented 2025-10-04 01:50:25 +00:00
Owner
Copy link

fixes #1097, fixes #1093, closes #1060 (by removing the logic for now, which was then ultimately fixed by #1126, pending a future replacement via #1061)

Fixes:

  • Banning, unbanning, and then inviting someone did not permit them to join in v12 rooms
  • Being unable to kick or unban a target in a v12 room if you were a creator
  • Being unable to redact events in a v12 room if you were a creator
  • Restricted join rules did not care if the joining user was invited when providing a federated join (make_join)
  • v12-style ownership checks being incorrectly applied to v11 and below room versions, resulting in fleeting authorization errors
fixes #1097, fixes #1093, closes #1060 (by removing the logic for now, which was then ultimately fixed by #1126, pending a future replacement via #1061) Fixes: - Banning, unbanning, and then inviting someone did not permit them to join in v12 rooms - Being unable to kick or unban a target in a v12 room if you were a creator - Being unable to redact events in a v12 room if you were a creator - Restricted join rules did not care if the joining user was invited when providing a federated join (`make_join`) - v12-style ownership checks being incorrectly applied to v11 and below room versions, resulting in fleeting authorization errors
nex requested review from Jade 2025-10-04 20:58:22 +00:00
nex added this to the 0.5.0 milestone 2025-10-04 20:58:23 +00:00
Jade approved these changes 2025-10-04 22:02:16 +00:00
Dismissed
nex changed title from fix: Unbans and kicks incorrectly checked creatorship in !v12 to WIP: fix: Several event auth issues 2025-10-04 23:33:47 +00:00
nex dismissed Jade's review 2025-10-04 23:33:53 +00:00
Reason:

PR scope changed

nex changed title from WIP: fix: Several event auth issues to WIP: fix: Hydra bugfix sweep 2025-10-08 20:46:26 +00:00
nex force-pushed nex/fix/event-auth from 0842b8945a
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 52s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m38s
Details
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 7m33s
Details
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 7m18s
Details
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 16s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 10m22s
Details
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 14m17s
Details
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 14m25s
Details
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 13s
Details
to c4e7e7c655
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 44s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m44s
Details
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 6m8s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 6m55s
Details
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 6m56s
Details
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 14s
Details
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 11m37s
Details
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 11m40s
Details
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 12s
Details
2025-10-08 21:06:57 +00:00 Compare
nex commented 2025-10-12 21:47:01 +00:00
Author
Owner
Copy link

Waiting until #1094 is fixed before un-drafting this (aiming to tackle it in this PR also)

Waiting until #1094 is fixed before un-drafting this (aiming to tackle it in this PR also)
nex force-pushed nex/fix/event-auth from 57e905b7b1
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Successful in 1m3s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m44s
Details
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 5m55s
Details
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 5m51s
Details
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 14s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 9m16s
Details
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 12m21s
Details
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 12m35s
Details
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 13s
Details
to e7b4b45ec4
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Successful in 1m5s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m48s
Details
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 8m11s
Details
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 7m21s
Details
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 22s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 19m21s
Details
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 15m59s
Details
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 16m4s
Details
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 20s
Details
2025-10-15 02:50:02 +00:00 Compare
nex commented 2025-10-15 12:45:30 +00:00
Author
Owner
Copy link

dont merge v12 is broken again lol

dont merge v12 is broken again lol
nex force-pushed nex/fix/event-auth from e7b4b45ec4
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Successful in 1m5s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m48s
Details
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 8m11s
Details
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 7m21s
Details
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 22s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 19m21s
Details
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 15m59s
Details
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 16m4s
Details
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 20s
Details
to 25fe03731a
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Successful in 49s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m43s
Details
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 8m49s
Details
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 8m39s
Details
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 16s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 18m22s
Details
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 15m53s
Details
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 15m57s
Details
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 26s
Details
2025-10-23 17:48:23 +00:00 Compare
nex commented 2025-10-23 20:46:04 +00:00
Author
Owner
Copy link

#1094 should be fixed by another PR and likely won't make it into this one.

#1094 should be fixed by another PR and likely won't make it into this one.
nex commented 2025-10-23 20:46:37 +00:00
Author
Owner
Copy link

This should now be ready for merge. I've tested everything I fixed and everything seems to work as expected

This should now be ready for merge. I've tested everything I fixed and everything seems to work as expected
👍 1
nex changed title from WIP: fix: Hydra bugfix sweep to fix: Hydra bugfix sweep 2025-10-23 20:46:41 +00:00
nex requested review from Owners 2025-10-23 20:46:47 +00:00
Jade approved these changes 2025-10-23 21:21:39 +00:00
src/service/rooms/state_accessor/user_can.rs Outdated
@ -81,2 +89,2 @@
)),
}
Ok(room_create.sender() == sender
|| redacting_event
Jade commented 2025-10-23 21:21:37 +00:00
Owner
Copy link

Additional creators? Unless it's handled earlier

Additional creators? Unless it's handled earlier
nex commented 2025-10-23 21:39:11 +00:00
Author
Owner
Copy link

Handled on line 54

Handled on line 54
Jade commented 2025-10-23 22:50:04 +00:00
Owner
Copy link

Code locality? Never heard of it 😭

Code locality? Never heard of it 😭
nex commented 2025-10-23 22:55:04 +00:00
Author
Owner
Copy link

it doesnt make sense to check ownership twice (in both the "has power level event" branch and the "doesnt have a power level event" branch), but rather just check it before even caring. Also technically saves us a lookup if the room is v12 and the sender is a creator.
Plus it's 30 lines up it's within eye shot 😭

it doesnt make sense to check ownership twice (in both the "has power level event" branch *and* the "doesnt have a power level event" branch), but rather just check it before even caring. Also technically saves us a lookup if the room is v12 and the sender is a creator. Plus it's 30 lines up it's within eye shot 😭
nex marked this conversation as resolved
tcpipuk force-pushed nex/fix/event-auth from f22016edee
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Successful in 50s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m38s
Details
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 7m36s
Details
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 7m21s
Details
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 19s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 15m47s
Details
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 15m1s
Details
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 14m57s
Details
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 14s
Details
to fbf48addc7
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Successful in 45s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m30s
Details
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 5m56s
Details
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 6m14s
Details
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 15s
Details
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 14m55s
Details
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 14m56s
Details
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 15s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 24m14s
Details
Documentation / Build and Deploy Documentation (push) Successful in 52s
Details
Checks / Prek / Pre-commit & Formatting (push) Successful in 1m41s
Details
Release Docker Image / Build linux-amd64 (release) (push) Successful in 8m5s
Details
Release Docker Image / Build linux-arm64 (release) (push) Successful in 7m36s
Details
Release Docker Image / Create Multi-arch Release Manifest (push) Successful in 15s
Details
Checks / Prek / Clippy and Cargo Tests (push) Successful in 33m24s
Details
Release Docker Image / Build linux-amd64 (max-perf) (push) Successful in 15m38s
Details
Release Docker Image / Build linux-arm64 (max-perf) (push) Successful in 14m47s
Details
Release Docker Image / Create Max-Perf Manifest (push) Successful in 16s
Details
2025-10-27 14:34:53 +00:00 Compare
nex merged commit fbf48addc7 into main 2025-10-28 17:40:48 +00:00
nex deleted branch nex/fix/event-auth 2025-10-28 17:40:48 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Jade
Labels
Clear labels   
Bug

Something isn't working as intended

  
Cherry-picking

Commits picked from other conduit projects

  
Database

This requires or includes changes to the database

  
Dependencies

Something dependency related

  
Dependencies/Renovate

Automatic dependency upgrades by Renovate

  
Difficulty
Easy
Low difficulty to implement - touches few parts of the codebase, low complexity

  
Difficulty
Hard
High difficulty to implement - touches many parts of the codebase, high complexity

  
Difficulty
Medium
Medium difficulty to implement - touches more parts of the codebase, higher complexity

  
Documentation

Improvements or additions to documentation

  
Enhancement

New feature or request

  
Good first issue

Good for newcomers

  
Help wanted

Additional eyes and keyboards are required for this one

  
Inherited

Issues that have been inhereted from the project pre-fork

  
Matrix/Administration

Features pertaining to homeserver administration

  
Matrix/Appservices

Features pertaining to the appservice API

  
Matrix/Auth

Features pertaining to authentication

  
Matrix/Client

Features pertaining to client-to-server interactions

  
Matrix/Core

Issues relating to core matrix functionality, such as state resolution and PDU formats

  
Matrix/Federation

Features pertaining to server-to-server interactions

  
Matrix/Hydra

Issues related to room version 12 and related changes (temporary label)

  
Matrix/MSC

Features pertaining to unstable matrix features

  
Matrix/Media

Features pertaining to media interactions

  
Meta

Related to housekeeping, maintenance, or other repo-meta.

  
Meta/CI

Issues related to CI changes

  
Meta/Packaging

Packaging

  
Priority
Blocking
This issue is blocking the next release

  
Priority
High
This issue is very important

  
Priority
Low
This issue is of a rather low priority

  
Security

This item is related to general security

  
Status/Blocked

This pull request or issue is currently blocked from being merged/closed

  
Status
Confirmed
This issue has enough information and is confirmed

  
Status
Duplicate
This issue or pull request already exists

  
Status
Invalid
This issue doesn't seem right

  
Status
Needs Investigation
This issue needs further investigation

  
Support

Questions or support requests

  
To-Merge

   
Wont fix

This will not be worked on

  
old/ci/cd

Ci/CD

Archived

  
old/rust

Pull requests that update Rust code

Archived

No labels
Bug
Cherry-picking
Database
Dependencies
Dependencies/Renovate
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/Federation
Matrix/Hydra
Matrix/MSC
Matrix/Media
Meta
Meta/CI
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status/Blocked
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
Support
To-Merge
Wont fix
old/ci/cd
old/rust
Milestone
Clear milestone
No items
No milestone
0.5.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
continuwuation/continuwuity!1099
No description provided.