continuwuation/continuwuity
continuwuation/continuwuity
11
32
Fork 29
Code Issues 95 Pull requests 18 Releases 19 Packages 4 Activity Actions

feat: Produce more informative errors when uploading media fails #1108

Merged
nex merged 3 commits from nex/feat/create-media into main 2025-10-12 19:42:57 +00:00
Conversation 1 Commits 3 Files changed 3 +33 -11
nex commented 2025-10-09 00:53:40 +00:00
Owner
Copy link

This pull request does the following things:

  • Makes uploads to /_matrix/media/v3/create that fail include a more helpful error message
  • Pro-actively reads the Content-Length header, if provided, to make sure that it doesn't exceed the configured limit. This allows servers to avoid wasting bandwidth and memory by checking if a body is viable before buffering it. Also allows clients that don't check the media config like Cinny to display an "upload failed" message before starting the upload.
This pull request does the following things: - Makes uploads to `/_matrix/media/v3/create` that fail include a more helpful error message - Pro-actively reads the `Content-Length` header, if provided, to make sure that it doesn't exceed the configured limit. This allows servers to avoid wasting bandwidth and memory by checking if a body is viable before buffering it. Also allows clients that don't check the media config like Cinny to display an "upload failed" message before starting the upload.
feat: Produce a more informative error when uploading media fails
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Successful in 48s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m22s
Details
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 6m1s
Details
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 6m9s
Details
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 18s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 9m34s
Details
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 16m36s
Details
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 16m43s
Details
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 17s
Details
8e7f6b2f2e
feat: Produce even more informative errors when saving media fails
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Successful in 51s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m27s
Details
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 6m25s
Details
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 5m53s
Details
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 16s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 9m49s
Details
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 14m24s
Details
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 14m19s
Details
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 14s
Details
eaafa4ce24
nex changed title from feat: Produce a more informative error when uploading media fails to feat: Produce more informative errors when uploading media fails 2025-10-09 02:28:13 +00:00
nex 2025-10-09 02:28:25 +00:00
feat: Proactively read Content-Length to reject oversized uploads
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Successful in 1m14s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m15s
Details
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 7m14s
Details
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 6m40s
Details
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 25s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 10m53s
Details
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 14m1s
Details
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 14m10s
Details
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 15s
Details
1bec9e000f
Jade approved these changes 2025-10-12 12:01:07 +00:00
nex merged commit cb8f36444c into main 2025-10-12 19:42:57 +00:00
nex deleted branch nex/feat/create-media 2025-10-12 19:42:57 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Jade
Labels
Clear labels   
Bug

Something isn't working as intended

  
Cherry-picking

Commits picked from other conduit projects

  
Database

This requires or includes changes to the database

  
Dependencies

Something dependency related

  
Dependencies/Renovate

Automatic dependency upgrades by Renovate

  
Difficulty
Easy
Low difficulty to implement - touches few parts of the codebase, low complexity

  
Difficulty
Hard
High difficulty to implement - touches many parts of the codebase, high complexity

  
Difficulty
Medium
Medium difficulty to implement - touches more parts of the codebase, higher complexity

  
Documentation

Improvements or additions to documentation

  
Enhancement

New feature or request

  
Good first issue

Good for newcomers

  
Help wanted

Additional eyes and keyboards are required for this one

  
Inherited

Issues that have been inhereted from the project pre-fork

  
Matrix/Administration

Features pertaining to homeserver administration

  
Matrix/Appservices

Features pertaining to the appservice API

  
Matrix/Auth

Features pertaining to authentication

  
Matrix/Client

Features pertaining to client-to-server interactions

  
Matrix/Core

Issues relating to core matrix functionality, such as state resolution and PDU formats

  
Matrix/Federation

Features pertaining to server-to-server interactions

  
Matrix/Hydra

Issues related to room version 12 and related changes (temporary label)

  
Matrix/MSC

Features pertaining to unstable matrix features

  
Matrix/Media

Features pertaining to media interactions

  
Meta

Related to housekeeping, maintenance, or other repo-meta.

  
Meta/CI

Issues related to CI changes

  
Meta/Packaging

Packaging

  
Priority
Blocking
This issue is blocking the next release

  
Priority
High
This issue is very important

  
Priority
Low
This issue is of a rather low priority

  
Security

This item is related to general security

  
Status/Blocked

This pull request or issue is currently blocked from being merged/closed

  
Status
Confirmed
This issue has enough information and is confirmed

  
Status
Duplicate
This issue or pull request already exists

  
Status
Invalid
This issue doesn't seem right

  
Status
Needs Investigation
This issue needs further investigation

  
To-Merge

   
Wont fix

This will not be worked on

  
old/ci/cd

Ci/CD

Archived

  
old/rust

Pull requests that update Rust code

Archived

No labels
Bug
Cherry-picking
Database
Dependencies
Dependencies/Renovate
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/Federation
Matrix/Hydra
Matrix/MSC
Matrix/Media
Meta
Meta/CI
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status/Blocked
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
To-Merge
Wont fix
old/ci/cd
old/rust
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
continuwuation/continuwuity!1108
No description provided.