fix(#1134): Update docs and implementation of admin media delete-past-remote-media #1136

Open

oddlid wants to merge 3 commits from oddlid/continuwuity:delete_media into main

pull from: oddlid/continuwuity:delete_media

merge into: continuwuation:main

continuwuation:main

continuwuation:nex/fix/event-auth

continuwuation:renovate/rust-patch-updates

continuwuation:ginger/sync-v3-cleanup

continuwuation:renovate/lock-file-maintenance

continuwuation:renovate/rand-0.x

continuwuation:renovate/opentelemetry-rust-monorepo

continuwuation:renovate/axum-monorepo

continuwuation:jade/flake-clone

continuwuation:ginger/upload-rpms-on-schedule

continuwuation:nex/fix/incoming-fetch

continuwuation:nex/fix/upgrade

continuwuation:tom/ci-fedora-rpm

continuwuation:nex/fed-improvements

continuwuation:jade/ci-release-fix

continuwuation:jade/rocksdb-10-5

continuwuation:illegal-car-mods

continuwuation:ginger/fix-msc4133-migration

continuwuation:ginger/migrate-busted-tz

continuwuation:hydra/public

continuwuation:tom/max-perf-docs

continuwuation:nex/feat/manual-extremities

continuwuation:nex/feat/async-media

continuwuation:nex/feat/fast-joins-hack-do-not-use-DO-NOT-USE

continuwuation:nex/feat/better-logging

continuwuation:trigger-ci-so-latest-isnt-on-illegal-car-mods

continuwuation:nex/feat/pins-backfill

continuwuation:jade/tuwunel-2025-06-old

continuwuation:jade/ai-slop-db-docs

continuwuation:nex/fix-create-auth

continuwuation:jade/version-stats

continuwuation:jade/read-receipts

continuwuation:dahsa_uwu/axum-0.8

continuwuation:jade/rust-toolchain-no-targets

continuwuation:jade/logging-features

continuwuation:jade/syncv5-typing

continuwuation:jade/msc2815

continuwuation:jade/relations

continuwuation:jade/purge-sync-tokens

continuwuation:morguldir/see-eye

continuwuation:jade/css-small-screen

continuwuation:nex/wip-751

continuwuation:tuwunel-rebase

continuwuation:test

continuwuation:oddlid/rename-admin-room-bot

continuwuation:strawberry/nix-ci-stuff

continuwuation:strawberry/valgrind

continuwuation:strawberry/morgs-snake-sync-jason-main

continuwuation:newer-media-endpoints

continuwuation:folly-coroutines-async-io

continuwuation:federation-retry-timer-port

continuwuation:bad-attempt-at-extracting-homeserver-signing-key

continuwuation:room-deletion-attempt-do-not-use

Conversation 3 Commits 3 Files changed 6 +81 -30

oddlid commented 2025-10-23 07:37:23 +00:00

Contributor

Copy link

For default.nix, there's really only 1 change, which is the commenting of line 214 (in the updated version), and a comment of why above. The rest of the changes in that file is just the nix formatters work. If this is undesirable, the whole file can be be excluded from the commit if desirable.

Otherwise, please have a look and see if you think these changes makes both the intent and implementation more clear.
Note that the logic for selecting files before/after is now reversed, as I believe it was not correct in the previous implementation. I've added a unit test to make that clear.

For default.nix, there's really only 1 change, which is the commenting of line 214 (in the updated version), and a comment of why above. The rest of the changes in that file is just the nix formatters work. If this is undesirable, the whole file can be be excluded from the commit if desirable. Otherwise, please have a look and see if you think these changes makes both the intent and implementation more clear. Note that the logic for selecting files before/after is now reversed, as I believe it was not correct in the previous implementation. I've added a unit test to make that clear.

oddlid added 1 commit 2025-10-23 07:37:23 +00:00

fix(#1134): Update docs and implementation of admin media delete-past-remote-media 5f6cd3f34b

Aviac commented 2025-10-23 11:12:43 +00:00

Member

Copy link

Note that there's a bigger nix refactor going on in #1096 which is going to be merged soon

Note that there's a bigger nix refactor going on in https://forgejo.ellis.link/continuwuation/continuwuity/pulls/1096 which is going to be merged soon

oddlid added 1 commit 2025-10-23 11:35:13 +00:00

fix(#1134): Update docs and implementation of admin media delete-past-remote-media ... d47d8adc6d

- Removed default.nix from PR based on comment from Aviac

oddlid commented 2025-10-23 11:38:14 +00:00

Author

Contributor

Copy link

@Aviac wrote in #1136 (comment):

Note that there's a bigger nix refactor going on in #1096 which is going to be merged soon

I've now removed the nix file from the commit

@Aviac wrote in https://forgejo.ellis.link/continuwuation/continuwuity/pulls/1136#issuecomment-21229: > Note that there's a bigger nix refactor going on in #1096 which is going to be merged soon I've now removed the nix file from the commit

Jade reviewed 2025-10-23 16:49:53 +00:00

src/admin/media/mod.rs Outdated

Show outdated Hide outdated

Jade commented 2025-10-23 16:49:53 +00:00

Owner

Copy link

Deletes all remote (and optionally local) media created (before|after) [duration] ago?

anyway, you need to regenerate the admin command docs, which was cargo xtask admin md or something

Deletes all remote (and optionally local) media created (before|after) [duration] ago? anyway, you need to regenerate the admin command docs, which was `cargo xtask admin md` or something

Jade commented 2025-10-23 16:50:20 +00:00

Owner

Copy link

If it makes it clearer, examples might be good

If it makes it clearer, examples might be good

oddlid added 1 commit 2025-10-23 18:39:21 +00:00

fix(#1134): Update docs and implementation of admin media delete-past-remote-media ... 6794e9563f

- Updated doc comments and regenerated admin command docs

All checks were successful

Hide all checks

Documentation / Build and Deploy Documentation (pull_request) Has been skipped

Details

Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m49s

Required

Details

Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 7m47s

Details

Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 7m50s

Details

Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 10s

Details

Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 15m54s

Required

Details

Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 14m59s

Details

Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 15m0s

Details

Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 5s

Details

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u delete_media:oddlid-delete_media

git switch oddlid-delete_media

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Bug

Something isn't working as intended

  

Cherry-picking

Commits picked from other conduit projects

  

Database

This requires or includes changes to the database

  

Dependencies

Something dependency related

  

Dependencies/Renovate

Automatic dependency upgrades by Renovate

  

Difficulty

Easy

Low difficulty to implement - touches few parts of the codebase, low complexity

  

Difficulty

Hard

High difficulty to implement - touches many parts of the codebase, high complexity

  

Difficulty

Medium

Medium difficulty to implement - touches more parts of the codebase, higher complexity

  

Documentation

Improvements or additions to documentation

  

Enhancement

New feature or request

  

Good first issue

Good for newcomers

  

Help wanted

Additional eyes and keyboards are required for this one

  

Inherited

Issues that have been inhereted from the project pre-fork

  

Matrix/Administration

Features pertaining to homeserver administration

  

Matrix/Appservices

Features pertaining to the appservice API

  

Matrix/Auth

Features pertaining to authentication

  

Matrix/Client

Features pertaining to client-to-server interactions

  

Matrix/Core

Issues relating to core matrix functionality, such as state resolution and PDU formats

  

Matrix/Federation

Features pertaining to server-to-server interactions

  

Matrix/Hydra

Issues related to room version 12 and related changes (temporary label)

  

Matrix/MSC

Features pertaining to unstable matrix features

  

Matrix/Media

Features pertaining to media interactions

  

Meta

Related to housekeeping, maintenance, or other repo-meta.

  

Meta/CI

Issues related to CI changes

  

Meta/Packaging

Packaging

  

Priority

Blocking

This issue is blocking the next release

  

Priority

High

This issue is very important

  

Priority

Low

This issue is of a rather low priority

  

Security

This item is related to general security

  

Status/Blocked

This pull request or issue is currently blocked from being merged/closed

  

Status

Confirmed

This issue has enough information and is confirmed

  

Status

Duplicate

This issue or pull request already exists

  

Status

Invalid

This issue doesn't seem right

  

Status

Needs Investigation

This issue needs further investigation

  

To-Merge

  

Wont fix

This will not be worked on

  

old/ci/cd

Ci/CD

Archived

  

old/rust

Pull requests that update Rust code

Archived

No labels

Bug

Cherry-picking

Database

Dependencies

Dependencies/Renovate

Difficulty

Easy

Difficulty

Hard

Difficulty

Medium

Documentation

Enhancement

Good first issue

Help wanted

Inherited

Matrix/Administration

Matrix/Appservices

Matrix/Auth

Matrix/Client

Matrix/Core

Matrix/Federation

Matrix/Hydra

Matrix/MSC

Matrix/Media

Meta

Meta/CI

Meta/Packaging

Priority

Blocking

Priority

High

Priority

Low

Security

Status/Blocked

Status

Confirmed

Status

Duplicate

Status

Invalid

Status

Needs Investigation

To-Merge

Wont fix

old/ci/cd

old/rust

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

3 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

continuwuation/continuwuity!1136

No description provided.