continuwuation/continuwuity
continuwuation/continuwuity
13
35
Fork 34
Code Issues 103 Pull requests 19 Releases 20 Packages 3 Activity Actions

WIP: MSC2815 message undeletion #1162

Draft
Jade wants to merge 3 commits from jade/msc2815 into main
pull from: jade/msc2815
merge into: continuwuation:main
Conversation 0 Commits 3 Files changed 5 +115 -4
Jade commented 2025-11-12 23:17:29 +00:00
Owner
Copy link

Opening this PR to make this old code more findable
This needs:

  • A way to store metadata in pduid_originalcontent rather than just the original content (for the redaction time)
  • a way to differentiate between 'did not recieve original message' and 'hard deleted / too old'
  • manual delete all / delete one
  • automatic deletion of old messages
  • a way to disable it

Alternative implementation strategy would be to not redact the event in the database and run the redaction in the sync / federation code, and only redact when we actually want to delete. However that comes with more footguns & woudn't be downgrade safe.

Opening this PR to make this old code more findable This needs: - A way to store metadata in pduid_originalcontent rather than just the original content (for the redaction time) - a way to differentiate between 'did not recieve original message' and 'hard deleted / too old' - manual delete all / delete one - automatic deletion of old messages - a way to disable it Alternative implementation strategy would be to not redact the event in the database and run the redaction in the sync / federation code, and only redact when we actually want to delete. However that comes with more footguns & woudn't be downgrade safe. 
Still to do:
- Handling the difference between content that we have deleted and
content we never received
- Deleting the original content on command or expiry

Another question is if we have to store the full original content?
Can we get by with just storing the 'content' field?
fix: Don't store events that have already been redacted
Some checks failed
Release Docker Image / define-variables (push) Successful in 4s
Details
Rust Checks / Format (push) Successful in 1m0s
Details
Rust Checks / Clippy (push) Failing after 4m2s
Details
Rust Checks / Cargo Test (push) Successful in 4m33s
Details
Release Docker Image / build-image (linux/amd64, linux-amd64) (push) Successful in 12m56s
Details
Release Docker Image / build-image (linux/arm64, linux-arm64) (push) Successful in 16m1s
Details
Release Docker Image / merge (push) Successful in 41s
Details
Documentation / Build and Deploy Documentation (pull_request) Successful in 27s
Details
aa29b81ef6
 
This prevents clobbering
Some checks are pending
Release Docker Image / define-variables (push) Successful in 4s
Details
Rust Checks / Format (push) Successful in 1m0s
Details
Rust Checks / Clippy (push) Failing after 4m2s
Details
Rust Checks / Cargo Test (push) Successful in 4m33s
Details
Release Docker Image / build-image (linux/amd64, linux-amd64) (push) Successful in 12m56s
Details
Release Docker Image / build-image (linux/arm64, linux-arm64) (push) Successful in 16m1s
Details
Release Docker Image / merge (push) Successful in 41s
Details
Documentation / Build and Deploy Documentation (pull_request) Successful in 27s
Details
Checks / *
Required
This pull request has changes conflicting with the target branch.
  • src/api/client/room/event.rs
  • src/service/rooms/timeline/mod.rs
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin jade/msc2815:jade/msc2815
git switch jade/msc2815
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Bug

Something isn't working as intended

  
Cherry-picking

Commits picked from other conduit projects

  
Database

This requires or includes changes to the database

  
Dependencies

Something dependency related

  
Dependencies/Renovate

Automatic dependency upgrades by Renovate

  
Difficulty
Easy
Low difficulty to implement - touches few parts of the codebase, low complexity

  
Difficulty
Hard
High difficulty to implement - touches many parts of the codebase, high complexity

  
Difficulty
Medium
Medium difficulty to implement - touches more parts of the codebase, higher complexity

  
Documentation

Improvements or additions to documentation

  
Enhancement

New feature or request

  
Good first issue

Good for newcomers

  
Help wanted

Additional eyes and keyboards are required for this one

  
Inherited

Issues that have been inhereted from the project pre-fork

  
Matrix/Administration

Features pertaining to homeserver administration

  
Matrix/Appservices

Features pertaining to the appservice API

  
Matrix/Auth

Features pertaining to authentication

  
Matrix/Client

Features pertaining to client-to-server interactions

  
Matrix/Core

Issues relating to core matrix functionality, such as state resolution and PDU formats

  
Matrix/Federation

Features pertaining to server-to-server interactions

  
Matrix/Hydra

Issues related to room version 12 and related changes (temporary label)

  
Matrix/MSC

Features pertaining to unstable matrix features

  
Matrix/Media

Features pertaining to media interactions

  
Meta

Related to housekeeping, maintenance, or other repo-meta.

  
Meta/CI

Issues related to CI changes

  
Meta/Packaging

Packaging

  
Priority
Blocking
This issue is blocking the next release

  
Priority
High
This issue is very important

  
Priority
Low
This issue is of a rather low priority

  
Security

This item is related to general security

  
Status/Blocked

This pull request or issue is currently blocked from being merged/closed

  
Status
Confirmed
This issue has enough information and is confirmed

  
Status
Duplicate
This issue or pull request already exists

  
Status
Invalid
This issue doesn't seem right

  
Status
Needs Investigation
This issue needs further investigation

  
Support

Questions or support requests

  
To-Merge

   
Wont fix

This will not be worked on

  
old/ci/cd

Ci/CD

Archived

  
old/rust

Pull requests that update Rust code

Archived

No labels
Bug
Cherry-picking
Database
Dependencies
Dependencies/Renovate
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/Federation
Matrix/Hydra
Matrix/MSC
Matrix/Media
Meta
Meta/CI
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status/Blocked
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
Support
To-Merge
Wont fix
old/ci/cd
old/rust
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
continuwuation/continuwuity!1162
No description provided.