fix: remove trailing whitespace from secrets read from secrets file #1209

Merged

nex merged 1 commit from charludo/continuwuity:ch/fix/newline-secrets into main

2025-12-13 16:08:32 +00:00

charludo commented

2025-12-02 11:10:36 +00:00

Contributor

After trying to debug my coturn setup for more hours than I care to admit yesterday evening, it turns out that the issue is that continuwuity reads the turn_secret from turn_secret_file, and then uses the file's entire contents as the secret.
Even using the exact same secrets file in coturn (through agenix, in my case) this leads to problems because both continuwuity and coturn happily start and use the key, but coturn strips the newline, and then the key supposedly shared between the two does not match.

While I could see the argument that this is user error, I don't agree with it; it's unexpected behavior to have to explicitly remove newlines from the secret.

This PR adds that trimming.

After trying to debug my coturn setup for more hours than I care to admit yesterday evening, it turns out that the issue is that continuwuity reads the `turn_secret` from `turn_secret_file`, and then uses the file's entire contents as the secret. Even using the exact same secrets file in coturn (through `agenix`, in my case) this leads to problems because both continuwuity and coturn happily start and use the key, but coturn strips the newline, and then the key supposedly shared between the two does not match. While I could see the argument that this is user error, I don't agree with it; it's unexpected behavior to have to explicitly remove newlines from the secret. This PR adds that trimming.

nex added the

Bug

Matrix/Administration

labels

2025-12-02 11:26:33 +00:00

nex approved these changes

2025-12-02 11:29:01 +00:00

nex left a comment

Owner

LGTM, stripping trailing whitespace is usually an expected behaviour anyway

Jade approved these changes

2025-12-03 01:44:17 +00:00

Jade left a comment

Owner

LGTM, probably something to note in the changelog as it's technically breaking.

charludo commented

2025-12-03 08:45:38 +00:00

Author

Contributor

@Jade wrote in #1209 (comment):

LGTM, probably something to note in the changelog as it's technically breaking.

Sorry, I'm new here - do I need to do anything to make that happen, or is it just a label on the PR or something?

@Jade wrote in https://forgejo.ellis.link/continuwuation/continuwuity/pulls/1209#issuecomment-21988: > LGTM, probably something to note in the changelog as it's technically breaking. Sorry, I'm new here - do I need to do anything to make that happen, or is it just a label on the PR or something?

Jade commented

2025-12-03 11:25:50 +00:00

Owner

Nope, we just have to come back to this when we're writing stuff up

❤️ 1