continuwuation/continuwuity
continuwuation/continuwuity
13
35
Fork 34
Code Issues 103 Pull requests 19 Releases 20 Packages 3 Activity Actions

fix: remove trailing whitespace from secrets read from secrets file #1209

Open
charludo wants to merge 1 commit from charludo/continuwuity:ch/fix/newline-secrets into main
pull from: charludo/continuwuity:ch/fix/newline-secrets
merge into: continuwuation:main
Conversation 4 Commits 1 Files changed 1 +5 -4
charludo commented 2025-12-02 11:10:36 +00:00
First-time contributor
Copy link

After trying to debug my coturn setup for more hours than I care to admit yesterday evening, it turns out that the issue is that continuwuity reads the turn_secret from turn_secret_file, and then uses the file's entire contents as the secret.
Even using the exact same secrets file in coturn (through agenix, in my case) this leads to problems because both continuwuity and coturn happily start and use the key, but coturn strips the newline, and then the key supposedly shared between the two does not match.

While I could see the argument that this is user error, I don't agree with it; it's unexpected behavior to have to explicitly remove newlines from the secret.

This PR adds that trimming.

After trying to debug my coturn setup for more hours than I care to admit yesterday evening, it turns out that the issue is that continuwuity reads the `turn_secret` from `turn_secret_file`, and then uses the file's entire contents as the secret. Even using the exact same secrets file in coturn (through `agenix`, in my case) this leads to problems because both continuwuity and coturn happily start and use the key, but coturn strips the newline, and then the key supposedly shared between the two does not match. While I could see the argument that this is user error, I don't agree with it; it's unexpected behavior to have to explicitly remove newlines from the secret. This PR adds that trimming.
fix: remove trailing whitespace from secrets read from secrets file
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m49s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 12m24s
Details
05bfa1a7c2
nex approved these changes 2025-12-02 11:29:01 +00:00
nex left a comment
Owner
Copy link

LGTM, stripping trailing whitespace is usually an expected behaviour anyway

LGTM, stripping trailing whitespace is usually an expected behaviour anyway
Jade approved these changes 2025-12-03 01:44:17 +00:00
Jade left a comment
Owner
Copy link

LGTM, probably something to note in the changelog as it's technically breaking.

LGTM, probably something to note in the changelog as it's technically breaking.
charludo commented 2025-12-03 08:45:38 +00:00
Author
First-time contributor
Copy link

@Jade wrote in #1209 (comment):

LGTM, probably something to note in the changelog as it's technically breaking.

Sorry, I'm new here - do I need to do anything to make that happen, or is it just a label on the PR or something?

@Jade wrote in https://forgejo.ellis.link/continuwuation/continuwuity/pulls/1209#issuecomment-21988: > LGTM, probably something to note in the changelog as it's technically breaking. Sorry, I'm new here - do I need to do anything to make that happen, or is it just a label on the PR or something?
Jade commented 2025-12-03 11:25:50 +00:00
Owner
Copy link

Nope, we just have to come back to this when we're writing stuff up

Nope, we just have to come back to this when we're writing stuff up
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m49s
Required
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 12m24s
Required
Details
This pull request is blocked because it's outdated.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u ch/fix/newline-secrets:charludo-ch/fix/newline-secrets
git switch charludo-ch/fix/newline-secrets
Sign in to join this conversation.
Reviewers
No reviewers
nex
Jade
Labels
Clear labels   
Bug

Something isn't working as intended

  
Cherry-picking

Commits picked from other conduit projects

  
Database

This requires or includes changes to the database

  
Dependencies

Something dependency related

  
Dependencies/Renovate

Automatic dependency upgrades by Renovate

  
Difficulty
Easy
Low difficulty to implement - touches few parts of the codebase, low complexity

  
Difficulty
Hard
High difficulty to implement - touches many parts of the codebase, high complexity

  
Difficulty
Medium
Medium difficulty to implement - touches more parts of the codebase, higher complexity

  
Documentation

Improvements or additions to documentation

  
Enhancement

New feature or request

  
Good first issue

Good for newcomers

  
Help wanted

Additional eyes and keyboards are required for this one

  
Inherited

Issues that have been inhereted from the project pre-fork

  
Matrix/Administration

Features pertaining to homeserver administration

  
Matrix/Appservices

Features pertaining to the appservice API

  
Matrix/Auth

Features pertaining to authentication

  
Matrix/Client

Features pertaining to client-to-server interactions

  
Matrix/Core

Issues relating to core matrix functionality, such as state resolution and PDU formats

  
Matrix/Federation

Features pertaining to server-to-server interactions

  
Matrix/Hydra

Issues related to room version 12 and related changes (temporary label)

  
Matrix/MSC

Features pertaining to unstable matrix features

  
Matrix/Media

Features pertaining to media interactions

  
Meta

Related to housekeeping, maintenance, or other repo-meta.

  
Meta/CI

Issues related to CI changes

  
Meta/Packaging

Packaging

  
Priority
Blocking
This issue is blocking the next release

  
Priority
High
This issue is very important

  
Priority
Low
This issue is of a rather low priority

  
Security

This item is related to general security

  
Status/Blocked

This pull request or issue is currently blocked from being merged/closed

  
Status
Confirmed
This issue has enough information and is confirmed

  
Status
Duplicate
This issue or pull request already exists

  
Status
Invalid
This issue doesn't seem right

  
Status
Needs Investigation
This issue needs further investigation

  
Support

Questions or support requests

  
To-Merge

   
Wont fix

This will not be worked on

  
old/ci/cd

Ci/CD

Archived

  
old/rust

Pull requests that update Rust code

Archived

No labels
Bug
Cherry-picking
Database
Dependencies
Dependencies/Renovate
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/Federation
Matrix/Hydra
Matrix/MSC
Matrix/Media
Meta
Meta/CI
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status/Blocked
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
Support
To-Merge
Wont fix
old/ci/cd
old/rust
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
continuwuation/continuwuity!1209
No description provided.