continuwuation/continuwuity
continuwuation/continuwuity
14
110
Fork 118
Code Issues 134 Pull requests 20 Releases 36 Packages 3 Activity Actions

WIP: feat: add configurable insecure TLS option for overlay networks #1289

Closed
N4CH723HR3R wants to merge 4 commits from N4CH723HR3R/continuwuity:add-https-ignore into main
pull from: N4CH723HR3R/continuwuity:add-https-ignore
merge into: continuwuation:main
Conversation 5 Commits 4 Files changed 15 +300 -56
N4CH723HR3R commented 2026-01-13 03:06:46 +00:00
First-time contributor
Copy link

This pull request adds a config option to disable TLS checks based on a regex.
Invalid certs are used for servers on overlay networks like i2p or TOR

Closes: #834

Pull request checklist:

  • This pull request targets the main branch, and the branch is named something other than
    main.
  • I have written an appropriate pull request title and my description is clear.
  • I understand I am responsible for the contents of this pull request.
  • I have followed the contributing guidelines:
    • My contribution follows the code style, if applicable.
    • I ran pre-commit checks before opening/drafting this pull request.
    • I have tested my contribution (or proof-read it for documentation-only changes)
      myself, if applicable. This includes ensuring code compiles.
      (it runs via the provided nix shell)
    • My commit messages follow the commit message format and are descriptive.
    • I have written a news fragment for this PR, if applicable.
This pull request adds a config option to disable TLS checks based on a regex. Invalid certs are used for servers on overlay networks like i2p or TOR Closes: #834 **Pull request checklist:** <!-- You need to complete these before your PR can be considered. If you aren't sure about some, feel free to ask for clarification in #dev:continuwuity.org. --> - [x] This pull request targets the `main` branch, and the branch is named something other than `main`. - [x] I have written an appropriate pull request title and my description is clear. - [x] I understand I am responsible for the contents of this pull request. - I have followed the [contributing guidelines][c1]: - [x] My contribution follows the [code style][c2], if applicable. - [x] I ran [pre-commit checks][c1pc] before opening/drafting this pull request. - [x] I have [tested my contribution][c1t] (or proof-read it for documentation-only changes) myself, if applicable. This includes ensuring code compiles. (it runs via the provided nix shell) - [x] My commit messages follow the [commit message format][c1cm] and are descriptive. - [ ] I have written a [news fragment][n1] for this PR, if applicable<!--(can be done after hitting open!)-->. <!-- Notes on these requirements: - While not required, we encourage you to sign your commits with GPG or SSH to attest the authenticity of your changes. - While we allow LLM-assisted contributions, we do not appreciate contributions that are low quality, which is typical of machine-generated contributions that have not had a lot of love and care from a human. Please do not open a PR if all you have done is asked ChatGPT to tidy up the codebase with a +-100,000 diff. - In the case of code style violations, reviewers may leave review comments/change requests indicating what the ideal change would look like. For example, a reviewer may suggest you lower a log level, or use `match` instead of `if/else` etc. - In the case of code style violations, pre-commit check failures, minor things like typos/spelling errors, and in some cases commit format violations, reviewers may modify your branch directly, typically by making changes and adding a commit. Particularly in the latter case, a reviewer may rebase your commits to squash "spammy" ones (like "fix", "fix", "actually fix"), and reword commit messages that don't satisfy the format. - Pull requests MUST pass the `Checks` CI workflows to be capable of being merged. This can only be bypassed in exceptional circumstances. If your CI flakes, let us know in matrix:r/dev:continuwuity.org. - Pull requests have to be based on the latest `main` commit before being merged. If the main branch changes while you're making your changes, you should make sure you rebase on main before opening a PR. Your branch will be rebased on main before it is merged if it has fallen behind. - We typically only do fast-forward merges, so your entire commit log will be included. Once in main, it's difficult to get out cleanly, so put on your best dress, smile for the cameras! --> [c1]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md [c2]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/docs/development/code_style.mdx [c1pc]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#pre-commit-checks [c1t]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#running-tests-locally [c1cm]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#commit-messages [n1]: https://towncrier.readthedocs.io/en/stable/tutorial.html#creating-news-fragments
N4CH723HR3R commented 2026-01-13 03:12:27 +00:00
Author
First-time contributor
Copy link

i still need to write a news fragment, right?

i still need to write a news fragment, right?
N4CH723HR3R force-pushed add-https-ignore from e0f8711074
Some checks are pending
Documentation / Build and Deploy Documentation (pull_request) Waiting to run
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Waiting to run
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Waiting to run
Details
to c429c9ca69
Some checks are pending
Documentation / Build and Deploy Documentation (pull_request) Waiting to run
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Waiting to run
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Waiting to run
Details
2026-01-13 20:49:35 +00:00 Compare
N4CH723HR3R force-pushed add-https-ignore from c429c9ca69
Some checks are pending
Documentation / Build and Deploy Documentation (pull_request) Waiting to run
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Waiting to run
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Waiting to run
Details
to 617538e351
Some checks are pending
Documentation / Build and Deploy Documentation (pull_request) Waiting to run
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Waiting to run
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Waiting to run
Details
2026-01-13 20:55:55 +00:00 Compare
N4CH723HR3R force-pushed add-https-ignore from 617538e351
Some checks are pending
Documentation / Build and Deploy Documentation (pull_request) Waiting to run
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Waiting to run
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Waiting to run
Details
to 01641a8364
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m54s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 22m23s
Details
2026-01-13 21:08:20 +00:00 Compare
ginger added this to the 0.5.5 milestone 2026-01-21 17:38:19 +00:00
N4CH723HR3R force-pushed add-https-ignore from 37ffad89ba
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 50s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 6m53s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 38m2s
Details
to cabe7b4715
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 22s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m23s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 16m55s
Details
2026-01-24 06:43:54 +00:00 Compare
N4CH723HR3R changed title from feat: add configurable insecure TLS option for overlay networks to WIP: feat: add configurable insecure TLS option for overlay networks 2026-01-24 08:42:11 +00:00
Jade modified the milestone from 0.5.5 to (deleted) 2026-02-15 15:55:10 +00:00
nex commented 2026-03-27 00:42:38 +00:00
Owner
Copy link

Are you still interested in working on this? It looks like there's a few merge conflicts now

Are you still interested in working on this? It looks like there's a few merge conflicts now
Henry-Hiles commented 2026-03-27 00:50:53 +00:00
Member
Copy link

@nex wrote in #1289 (comment):

Are you still interested in working on this? It looks like there's a few merge conflicts now

Relaying from Matrix, in case it wasn't seen, @n4ch7:n3831.net wants to work on it tomorrow.

@nex wrote in https://forgejo.ellis.link/continuwuation/continuwuity/pulls/1289#issuecomment-26872: > Are you still interested in working on this? It looks like there's a few merge conflicts now Relaying from Matrix, in case it wasn't seen, `@n4ch7:n3831.net` wants to work on it tomorrow.
👍 1
N4CH723HR3R force-pushed add-https-ignore from cabe7b4715
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 22s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m23s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 16m55s
Details
to 0a2c2fd89e
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Check Changelog / Check for changelog (pull_request_target) Successful in 10s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Failing after 3m31s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m55s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 18m58s
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 7s
Details
2026-03-29 07:59:42 +00:00 Compare
Henry-Hiles commented 2026-06-02 16:05:07 +00:00
Member
Copy link

@N4CH723HR3R are you still working on this?

@N4CH723HR3R are you still working on this?
ginger commented 2026-06-15 16:46:56 +00:00
Owner
Copy link

Closing this PR as it appears to be abandoned.

Closing this PR as it appears to be abandoned.
ginger closed this pull request 2026-06-15 16:46:56 +00:00
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Check Changelog / Check for changelog (pull_request_target) Successful in 10s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Failing after 3m31s
Required
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m55s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 18m58s
Required
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 7s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Abandoned
This pull request appears to be abandoned by its author.

  
Blocked
This pull request or issue is currently blocked from being merged/closed

  
Bug
Something isn't working as intended

  
Changelog
Added
 Changelog entry added

  
Changelog
Missing
 No changelog when one is needed

  
Changelog
None
 Changelog is unnecesary for this change

  
Cherry-picking
Commits picked from other conduit projects

  
Database
This requires or includes changes to the database

  
Dependencies
Something dependency related

  
Dependencies/Renovate
Automatic dependency upgrades by Renovate

  
Difficulty
Easy
 Low difficulty to implement - touches few parts of the codebase, low complexity

  
Difficulty
Hard
 High difficulty to implement - touches many parts of the codebase, high complexity

  
Difficulty
Medium
 Medium difficulty to implement - touches more parts of the codebase, higher complexity

  
Documentation
Improvements or additions to documentation

  
Enhancement
New feature or request

  
Good first issue
Good for newcomers

  
Help wanted
Additional eyes and keyboards are required for this one

  
Inherited
Issues that have been inhereted from the project pre-fork

  
Matrix/Administration
Features pertaining to homeserver administration

  
Matrix/Appservices
Features pertaining to the appservice API

  
Matrix/Auth
Features pertaining to authentication

  
Matrix/Client
Features pertaining to client-to-server interactions

  
Matrix/Core
Issues relating to core matrix functionality, such as state resolution and PDU formats

  
Matrix/E2EE
Issues related to end to end encryption

  
Matrix/Federation
Features pertaining to server-to-server interactions

  
Matrix/Hydra
Issues related to room version 12 and related changes (temporary label)

  
Matrix/MSC
Features pertaining to unstable matrix features

  
Matrix/Media
Features pertaining to media interactions

  
Matrix/T&S
Changes or issues related to trust & safety tooling

  
Merge
This PR is ready to be merged

  
Merge/Manual
This PR should be manually merged

  
Merge/Squash
This PR should be squashed when it is merged

  
Meta
Related to housekeeping, maintenance, or other repo-meta.

  
Meta/CI
Issues related to CI changes

  
Meta/Packaging
Packaging

  
Priority
Blocking
 This issue is blocking the next release

  
Priority
High
 This issue is very important

  
Priority
Low
 This issue is of a rather low priority

  
Security
This item is related to general security

  
Status
Confirmed
 This issue has enough information and is confirmed

  
Status
Duplicate
 This issue or pull request already exists

  
Status
Invalid
 This issue doesn't seem right

  
Status
Needs Investigation
 This issue needs further investigation

  
Support
Questions or support requests

  
bob the builder
pdu logic rewrite starring nexus nicholson

No labels
Abandoned
Blocked
Bug
Changelog
Added
Changelog
Missing
Changelog
None
Cherry-picking
Database
Dependencies
Dependencies/Renovate
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/E2EE
Matrix/Federation
Matrix/Hydra
Matrix/MSC
Matrix/Media
Matrix/T&S
Merge
Merge/Manual
Merge/Squash
Meta
Meta/CI
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
Support
bob the builder
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
continuwuation/continuwuity!1289
No description provided.