continuwuation/continuwuity
continuwuation/continuwuity
13
78
Fork 86
Code Issues 114 Pull requests 41 Releases 27 Packages 3 Activity Actions 3

perf: Optimise account deactivation process #1314

Merged
nex merged 4 commits from nex/feat/faster-deactivations into main 2026-01-30 05:11:31 +00:00
Conversation 3 Commits 4 Files changed 3 +31 -40
nex commented 2026-01-25 15:47:50 +00:00
Owner
Copy link

This pull request optimises the user deactivation process by removing all instances of duplicated work, and changes the process to as follows:

  1. Deactivate the user
  2. Remove global profile
  3. For each room the user is in, drop their power level if possible
  4. For each room the user is in, send a leave event with no profile
  5. Forget all rooms the user is in

This is opposed to the previous flow:

  1. Remove the user's avatar from all rooms
  2. Remove the user's display name from all rooms
  3. Deactivate the user
  4. Remove the user's display name from all rooms (no-op)
  5. Remove the user's avatar from all rooms (no-op)
  6. Remove users' global profile
  7. Drop power levels in each room
  8. Leave each room
  9. Forget each room

I plan to add a way to honour erase requests and also add a way for admins to force the user to rescind all of their invites and redact all of their messages, but that will require database changes which makes that out of scope for this PR.

Pull request checklist:

  • This pull request targets the main branch, and the branch is named something other than
    main.
  • I have written an appropriate pull request title and my description is clear.
  • I understand I am responsible for the contents of this pull request.
  • I have followed the contributing guidelines:
<!-- In order to help reviewers know what your pull request does at a glance, you should ensure that 1. Your PR title is a short, single sentence describing what you changed 2. You have described in more detail what you have changed, why you have changed it, what the intended effect is, and why you think this will be beneficial to the project. If you have made any potentially strange/questionable design choices, but didn't feel they'd benefit from code comments, please don't mention them here - after opening your pull request, go to "files changed", and click on the "+" symbol in the line number gutter, and attach comments to the lines that you think would benefit from some clarification. --> This pull request optimises the user deactivation process by removing all instances of duplicated work, and changes the process to as follows: 1. Deactivate the user 2. Remove global profile 3. For each room the user is in, drop their power level if possible 4. For each room the user is in, send a leave event with no profile 5. Forget all rooms the user is in This is opposed to the previous flow: 1. Remove the user's avatar from all rooms 2. Remove the user's display name from all rooms 3. Deactivate the user 4. Remove the user's display name from all rooms (no-op) 5. Remove the user's avatar from all rooms (no-op) 6. Remove users' global profile 7. Drop power levels in each room 8. Leave each room 9. Forget each room I plan to add a way to honour erase requests and also add a way for admins to force the user to rescind all of their invites and redact all of their messages, but that will require database changes which makes that out of scope for this PR. <!-- Example: This pull request allows us to warp through time and space ten times faster than before by double-inverting the warp drive with hyperheated jump fluid, both making the drive faster and more efficient. This resolves the common issue where we have to wait more than 10 milliseconds to engage, use, and disengage the warp drive when travelling between galaxies. --> <!-- Closes: #... --> <!-- Fixes: #... --> <!-- Uncomment the above line(s) if your pull request fixes an issue or closes another pull request by superseding it. Replace `#...` with the issue/pr number, such as `#123`. --> **Pull request checklist:** <!-- You need to complete these before your PR can be considered. If you aren't sure about some, feel free to ask for clarification in #dev:continuwuity.org. --> - [x] This pull request targets the `main` branch, and the branch is named something other than `main`. - [x] I have written an appropriate pull request title and my description is clear. - [x] I understand I am responsible for the contents of this pull request. - I have followed the [contributing guidelines][c1]: - [x] My contribution follows the [code style][c2], if applicable. - [x] I ran [pre-commit checks][c1pc] before opening/drafting this pull request. - [x] I have [tested my contribution][c1t] (or proof-read it for documentation-only changes) myself, if applicable. This includes ensuring code compiles. - [x] My commit messages follow the [commit message format][c1cm] and are descriptive. - [x] I have written a [news fragment][n1] for this PR, if applicable<!--(can be done after hitting open!)-->. <!-- Notes on these requirements: - While not required, we encourage you to sign your commits with GPG or SSH to attest the authenticity of your changes. - While we allow LLM-assisted contributions, we do not appreciate contributions that are low quality, which is typical of machine-generated contributions that have not had a lot of love and care from a human. Please do not open a PR if all you have done is asked ChatGPT to tidy up the codebase with a +-100,000 diff. - In the case of code style violations, reviewers may leave review comments/change requests indicating what the ideal change would look like. For example, a reviewer may suggest you lower a log level, or use `match` instead of `if/else` etc. - In the case of code style violations, pre-commit check failures, minor things like typos/spelling errors, and in some cases commit format violations, reviewers may modify your branch directly, typically by making changes and adding a commit. Particularly in the latter case, a reviewer may rebase your commits to squash "spammy" ones (like "fix", "fix", "actually fix"), and reword commit messages that don't satisfy the format. - Pull requests MUST pass the `Checks` CI workflows to be capable of being merged. This can only be bypassed in exceptional circumstances. If your CI flakes, let us know in matrix:r/dev:continuwuity.org. - Pull requests have to be based on the latest `main` commit before being merged. If the main branch changes while you're making your changes, you should make sure you rebase on main before opening a PR. Your branch will be rebased on main before it is merged if it has fallen behind. - We typically only do fast-forward merges, so your entire commit log will be included. Once in main, it's difficult to get out cleanly, so put on your best dress, smile for the cameras! --> [c1]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md [c2]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/docs/development/code_style.mdx [c1pc]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#pre-commit-checks [c1t]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#running-tests-locally [c1cm]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#commit-messages [n1]: https://towncrier.readthedocs.io/en/stable/tutorial.html#creating-news-fragments
🎉 1
nex added this to the 0.5.5 milestone 2026-01-25 15:47:50 +00:00
nex requested review from Owners 2026-01-25 16:39:59 +00:00
nex commented 2026-01-25 16:40:41 +00:00
Author
Owner
Copy link

Obviously I'm not willing to test this with a huge account but I gave it a quick burn test on timedout.uk and it's noticeably faster than before.

Obviously I'm not willing to test this with a huge account but I gave it a quick burn test on timedout.uk and it's noticeably faster than before.
ginger reviewed 2026-01-26 18:38:20 +00:00
src/api/client/account.rs Outdated
@ -824,4 +822,1 @@
info!("User {sender_user} deactivated their account.");
if services.server.config.admin_room_notices {
ginger commented 2026-01-26 18:36:34 +00:00
Owner
Copy link

Not sending notices on deactivation to the admin room anymore?

Not sending notices on deactivation to the admin room anymore?
nex commented 2026-01-27 01:27:54 +00:00
Author
Owner
Copy link

I think I meant to send that notice in full_user_deactivate but cut it and forgot to paste it later

I think I meant to send that notice in `full_user_deactivate` but cut it and forgot to paste it later
nex marked this conversation as resolved
src/api/client/account.rs Outdated
@ -920,3 +906,2 @@
for room_id in all_joined_rooms {
let state_lock = services.rooms.state.mutex.lock(room_id).await;
// TODO: Rescind all user invites
ginger commented 2026-01-26 18:37:01 +00:00
Owner
Copy link

I assume this isn't done because we can't revoke invites over federation yet

I assume this isn't done because we can't revoke invites over federation yet
nex commented 2026-01-27 01:26:43 +00:00
Author
Owner
Copy link

No, it's because we don't have the useridroomid_eventid column I want, so finding every invite event sent by the sender will require scanning potentially an unbounded number of events in the database to discover them.

Adding that column later will also allow me to tackle the server-side component of redact-on ban, implement user redactions, and allow for redact-on-deactivate functionality too. But it's too much for a PR that just improves performance.

No, it's because we don't have the `useridroomid_eventid` column I want, so finding every invite event sent by the sender will require scanning potentially an unbounded number of events in the database to discover them. Adding that column later will also allow me to tackle the server-side component of redact-on ban, implement user redactions, and allow for redact-on-deactivate functionality too. But it's too much for a PR that just improves performance.
ginger marked this conversation as resolved
src/api/client/account.rs Outdated
@ -974,1 +962,3 @@
super::leave_all_rooms(services, user_id).boxed().await;
super::update_all_rooms(services, pdu_queue, user_id).await;
for room_id in all_joined_rooms {
services.rooms.state_cache.forget(room_id, user_id);
ginger commented 2026-01-26 18:38:14 +00:00
Owner
Copy link

What does "forget" mean here, exactly?

What does "forget" mean here, exactly?
nex commented 2026-01-27 01:27:16 +00:00
Author
Owner
Copy link

Makes the homeserver "forget" when the user left the room - https://spec.matrix.org/v1.17/client-server-api/#post_matrixclientv3roomsroomidforget.
Just a cache cleanup operation

Makes the homeserver "forget" when the user left the room - https://spec.matrix.org/v1.17/client-server-api/#post_matrixclientv3roomsroomidforget. Just a cache cleanup operation
ginger marked this conversation as resolved
ginger force-pushed nex/feat/faster-deactivations from 9d48d83756
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Successful in 1m30s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m52s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 10m17s
Details
to c193ca2f0e
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 2m17s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m9s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled
Details
2026-01-27 02:48:03 +00:00 Compare
fix: Restore admin room announcement for deactivations
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Successful in 2m23s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 3m10s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 50m13s
Details
f07f0d3ded
nex requested review from ginger 2026-01-27 03:39:47 +00:00
ginger approved these changes 2026-01-29 15:57:11 +00:00
nex merged commit fd9bbb08ed into main 2026-01-30 05:11:31 +00:00
nex deleted branch nex/feat/faster-deactivations 2026-01-30 05:11:31 +00:00
nex modified the milestone from 0.5.5 to 0.5.4 2026-02-08 16:14:30 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
ginger
Labels
Clear labels   
Blocked

This pull request or issue is currently blocked from being merged/closed

  
Bug

Something isn't working as intended

  
Cherry-picking

Commits picked from other conduit projects

  
Database

This requires or includes changes to the database

  
Dependencies

Something dependency related

  
Dependencies/Renovate

Automatic dependency upgrades by Renovate

  
Difficulty
Easy
Low difficulty to implement - touches few parts of the codebase, low complexity

  
Difficulty
Hard
High difficulty to implement - touches many parts of the codebase, high complexity

  
Difficulty
Medium
Medium difficulty to implement - touches more parts of the codebase, higher complexity

  
Documentation

Improvements or additions to documentation

  
Enhancement

New feature or request

  
Good first issue

Good for newcomers

  
Help wanted

Additional eyes and keyboards are required for this one

  
Inherited

Issues that have been inhereted from the project pre-fork

  
Matrix/Administration

Features pertaining to homeserver administration

  
Matrix/Appservices

Features pertaining to the appservice API

  
Matrix/Auth

Features pertaining to authentication

  
Matrix/Client

Features pertaining to client-to-server interactions

  
Matrix/Core

Issues relating to core matrix functionality, such as state resolution and PDU formats

  
Matrix/E2EE

   
Matrix/Federation

Features pertaining to server-to-server interactions

  
Matrix/Hydra

Issues related to room version 12 and related changes (temporary label)

  
Matrix/MSC

Features pertaining to unstable matrix features

  
Matrix/Media

Features pertaining to media interactions

  
Matrix/T&S

Changes or issues related to trust & safety tooling

  
Meta

Related to housekeeping, maintenance, or other repo-meta.

  
Meta/CI

Issues related to CI changes

  
Meta/Packaging

Packaging

  
Priority
Blocking
This issue is blocking the next release

  
Priority
High
This issue is very important

  
Priority
Low
This issue is of a rather low priority

  
Security

This item is related to general security

  
Status
Confirmed
This issue has enough information and is confirmed

  
Status
Duplicate
This issue or pull request already exists

  
Status
Invalid
This issue doesn't seem right

  
Status
Needs Investigation
This issue needs further investigation

  
Support

Questions or support requests

  
To-Merge

   
Wont fix

This will not be worked on

  
old/ci/cd

Ci/CD

Archived

  
old/rust

Pull requests that update Rust code

Archived

No labels
Blocked
Bug
Cherry-picking
Database
Dependencies
Dependencies/Renovate
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/E2EE
Matrix/Federation
Matrix/Hydra
Matrix/MSC
Matrix/Media
Matrix/T&S
Meta
Meta/CI
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
Support
To-Merge
Wont fix
old/ci/cd
old/rust
Milestone
Clear milestone
No items
No milestone
0.5.4
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
continuwuation/continuwuity!1314
No description provided.