continuwuation/continuwuity

Fork 85

perf: Don't attempt to process disconnected rooms #1316

Merged

nex merged 4 commits from nex/perf/dont-process-disconnected-rooms into main

2026-02-03 20:09:42 +00:00

nex commented

2026-01-27 03:19:02 +00:00

Owner

Sometimes we'll continue to receive requests and transaction attempts for rooms we aren't in anymore (i.e. have no local users). This PR adds a quick check to several processing points to short circuit if we don't think we're in the given room.
This primarily reduces resource consumption for left-but-not-banned rooms, but also has the side effect that left rooms are far less likely to state reset users back in. Also prevents us serving corrupted state, lol.

Pull request checklist:

This pull request targets the main branch, and the branch is named something other than
main.
I have written an appropriate pull request title and my description is clear.
I understand I am responsible for the contents of this pull request.
I have followed the contributing guidelines:
- My contribution follows the code style, if applicable.
- I ran pre-commit checks before opening/drafting this pull request.
- I have tested my contribution (or proof-read it for documentation-only changes)
  myself, if applicable. This includes ensuring code compiles.
- My commit messages follow the commit message format and are descriptive.
- I have written a news fragment for this PR, if applicable.

Sometimes we'll continue to receive requests and transaction attempts for rooms we aren't in anymore (i.e. have no local users). This PR adds a quick check to several processing points to short circuit if we don't think we're in the given room. This primarily reduces resource consumption for left-but-not-banned rooms, but also has the side effect that left rooms are *far* less likely to state reset users back in. Also prevents us serving corrupted state, lol.     **Pull request checklist:**  - [x] This pull request targets the `main` branch, and the branch is named something other than `main`. - [x] I have written an appropriate pull request title and my description is clear. - [x] I understand I am responsible for the contents of this pull request. - I have followed the [contributing guidelines][c1]: - [x] My contribution follows the [code style][c2], if applicable. - [x] I ran [pre-commit checks][c1pc] before opening/drafting this pull request. - [x] I have [tested my contribution][c1t] (or proof-read it for documentation-only changes) myself, if applicable. This includes ensuring code compiles. - [x] My commit messages follow the [commit message format][c1cm] and are descriptive. - [x] I have written a [news fragment][n1] for this PR, if applicable.  [c1]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md [c2]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/docs/development/code_style.mdx [c1pc]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#pre-commit-checks [c1t]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#running-tests-locally [c1cm]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#commit-messages [n1]: https://towncrier.readthedocs.io/en/stable/tutorial.html#creating-news-fragments

nex added the

Enhancement

Matrix/Federation

labels

2026-01-27 03:19:02 +00:00

nex requested review from Owners

2026-01-27 03:35:41 +00:00

Aranjedeath approved these changes

2026-01-27 18:08:02 +00:00

Aranjedeath left a comment

Owner

I have been using this in production since last night and I have not noticed new breakage. I might suggest making the logs trace or something instead of debug_warn

nex commented

2026-01-27 19:01:13 +00:00

Author

Owner

I might suggest making the logs trace or something instead of debug_warn

Could probably drop them down to a debug info, but they might actually be important logs that can indicate deeper issues so sticking them lower than debug info is probably too far. Although given the rarity of this during normal operation I think warn is probably fine

> I might suggest making the logs trace or something instead of debug_warn Could probably drop them down to a debug info, but they might actually be important logs that can indicate deeper issues so sticking them lower than debug info is probably too far. Although given the rarity of this during normal operation I think warn is probably fine

Aranjedeath commented

2026-01-27 19:08:21 +00:00

Owner

Slightly more strongly: the objection was to debug_* anything, if they are key federation breakages they should not be compiled out in release builds

nex force-pushed nex/perf/dont-process-disconnected-rooms from 8f35c489a2

Documentation / Build and Deploy Documentation (pull_request) Successful in 2m59s

Details

Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m11s

Details

Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 43m2s

Details

to d248cdc808

Documentation / Build and Deploy Documentation (pull_request) Successful in 1m14s

Details

Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m0s

Details

Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 28m18s

Details

2026-01-27 23:26:53 +00:00

Compare

ginger approved these changes

2026-01-29 16:00:37 +00:00

ginger left a comment

Owner

the changes look good, but it bothers me that we're repeating the same check across fourteen files. maybe in the future we could use axum middleware to share these checks across multiple routes?

nex commented

2026-01-29 18:24:00 +00:00

Author

Owner

Looks like it works as expected in the wild:

2026-01-29T16:35:11.533473Z  WARN conduwuit_service::sending::sender: error sending PDU $8Kb-74J9A93-N1DzjwYU7U13Zixn6u6yJOulSJ0fmPo to remote server: "M_NOT_FOUND: This server is not participating in that room." txn_id=jVncN4haQB25KrS1wGhH7z6ToooRLXE3B1T4ft3ICZ4 server=timedout.uk
2026-01-29T16:35:20.326403Z  WARN conduwuit_service::sending::sender: error sending PDU $05QJ12R4qHAPqMYxV3RtsWwTLInivXdk85_hQXtCJXU to remote server: "M_NOT_FOUND: This server is not participating in that room." txn_id=Pt-sU-c6zX0368weIHWCHfOVQVKuDZ32gp50zzmh1qo server=timedout.uk
2026-01-29T16:35:33.740786Z  WARN conduwuit_service::sending::sender: error sending PDU $1Tf7QPl8hDZS3vbdquMbipRrVQQcJ6U7jI2lr1O5XvQ to remote server: "M_NOT_FOUND: This server is not participating in that room." txn_id=eG17S2YAAA2HsJuSRX5JMzmPhqEFrVw5UoqWUhQ2dFY server=explodie.org
2026-01-29T16:35:33.740812Z  WARN conduwuit_service::sending::sender: error sending PDU $7ucHMeI2sQSeyWHil6nLV8w01hUn-ET-Y982E3n7voU to remote server: "M_NOT_FOUND: This server is not participating in that room." txn_id=eG17S2YAAA2HsJuSRX5JMzmPhqEFrVw5UoqWUhQ2dFY server=explodie.org
2026-01-29T16:35:33.740820Z  WARN conduwuit_service::sending::sender: error sending PDU $sB6tCdbHSUvzLmt5aCEMbhbYqkksSnkMONXsNV2spnY to remote server: "M_NOT_FOUND: This server is not participating in that room." txn_id=eG17S2YAAA2HsJuSRX5JMzmPhqEFrVw5UoqWUhQ2dFY server=explodie.org
2026-01-29T16:54:44.068288Z  WARN conduwuit_service::sending::sender: error sending PDU $4reyfoKHJvzShn4pEsQvV4fCctKKDBOJqjwJ_gc2Mjg to remote server: "M_NOT_FOUND: This server is not participating in that room." txn_id=J7F14YA_JUxB1weXJSLm8GSYCMNkw7gM3qPaPv4ug_Q server=explodie.org

those are presumably all profile updates from my recent globalnick change, I know the first one is in a room that state resets frequently and timedout.uk most certainly isn't in anymore, but used to be, and looks to be from my server's POV. As expected, timedout.uk still isn't in that first room, which i think it would've been otherwise.

Looks like it works as expected in the wild: ``` 2026-01-29T16:35:11.533473Z WARN conduwuit_service::sending::sender: error sending PDU $8Kb-74J9A93-N1DzjwYU7U13Zixn6u6yJOulSJ0fmPo to remote server: "M_NOT_FOUND: This server is not participating in that room." txn_id=jVncN4haQB25KrS1wGhH7z6ToooRLXE3B1T4ft3ICZ4 server=timedout.uk 2026-01-29T16:35:20.326403Z WARN conduwuit_service::sending::sender: error sending PDU $05QJ12R4qHAPqMYxV3RtsWwTLInivXdk85_hQXtCJXU to remote server: "M_NOT_FOUND: This server is not participating in that room." txn_id=Pt-sU-c6zX0368weIHWCHfOVQVKuDZ32gp50zzmh1qo server=timedout.uk 2026-01-29T16:35:33.740786Z WARN conduwuit_service::sending::sender: error sending PDU $1Tf7QPl8hDZS3vbdquMbipRrVQQcJ6U7jI2lr1O5XvQ to remote server: "M_NOT_FOUND: This server is not participating in that room." txn_id=eG17S2YAAA2HsJuSRX5JMzmPhqEFrVw5UoqWUhQ2dFY server=explodie.org 2026-01-29T16:35:33.740812Z WARN conduwuit_service::sending::sender: error sending PDU $7ucHMeI2sQSeyWHil6nLV8w01hUn-ET-Y982E3n7voU to remote server: "M_NOT_FOUND: This server is not participating in that room." txn_id=eG17S2YAAA2HsJuSRX5JMzmPhqEFrVw5UoqWUhQ2dFY server=explodie.org 2026-01-29T16:35:33.740820Z WARN conduwuit_service::sending::sender: error sending PDU $sB6tCdbHSUvzLmt5aCEMbhbYqkksSnkMONXsNV2spnY to remote server: "M_NOT_FOUND: This server is not participating in that room." txn_id=eG17S2YAAA2HsJuSRX5JMzmPhqEFrVw5UoqWUhQ2dFY server=explodie.org 2026-01-29T16:54:44.068288Z WARN conduwuit_service::sending::sender: error sending PDU $4reyfoKHJvzShn4pEsQvV4fCctKKDBOJqjwJ_gc2Mjg to remote server: "M_NOT_FOUND: This server is not participating in that room." txn_id=J7F14YA_JUxB1weXJSLm8GSYCMNkw7gM3qPaPv4ug_Q server=explodie.org ``` those are presumably all profile updates from my recent globalnick change, I know the first one is in a room that state resets frequently and timedout.uk most certainly isn't in anymore, but used to be, and looks to be from my server's POV. As expected, timedout.uk still isn't in that first room, which i think it would've been otherwise.

nex merged commit 082ed5b70c into main

2026-02-03 20:09:42 +00:00

nex deleted branch nex/perf/dont-process-disconnected-rooms

2026-02-03 20:09:42 +00:00

nex added this to the 0.5.4 milestone

2026-02-08 16:14:30 +00:00