continuwuation/continuwuity
continuwuation/continuwuity
16
60
Fork 64
Code Issues 99 Pull requests 31 Releases 26 Packages 3 Activity Actions 10

feat(admin): Add resolver cache flush command #1349

Merged
nex merged 2 commits from Omar007/continuwuity:feature/flush-cache into main 2026-02-10 22:55:54 +00:00
Conversation 6 Commits 2 Files changed 3 +39 -1
Omar007 commented 2026-02-10 15:26:33 +00:00
Contributor
Copy link

This command allows an admin to flush a specific server from the resolver caches or flush the whole cache.

Pull request checklist:

  • This pull request targets the main branch, and the branch is named something other than
    main.
  • I have written an appropriate pull request title and my description is clear.
  • I understand I am responsible for the contents of this pull request.
  • I have followed the contributing guidelines:
This command allows an admin to flush a specific server from the resolver caches or flush the whole cache. **Pull request checklist:** - [x] This pull request targets the `main` branch, and the branch is named something other than `main`. - [x] I have written an appropriate pull request title and my description is clear. - [x] I understand I am responsible for the contents of this pull request. - I have followed the [contributing guidelines][c1]: - [x] My contribution follows the [code style][c2], if applicable. - [x] I ran [pre-commit checks][c1pc] before opening/drafting this pull request. - [x] I have [tested my contribution][c1t] (or proof-read it for documentation-only changes) myself, if applicable. This includes ensuring code compiles. - [x] My commit messages follow the [commit message format][c1cm] and are descriptive. - [x] I have written a [news fragment][n1] for this PR, if applicable<!--(can be done after hitting open!)-->. [c1]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md [c2]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/docs/development/code_style.mdx [c1pc]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#pre-commit-checks [c1t]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#running-tests-locally [c1cm]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#commit-messages [n1]: https://towncrier.readthedocs.io/en/stable/tutorial.html#creating-news-fragments
feat(admin): Add resolver cache flush command
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been cancelled
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Has been cancelled
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled
Details
e9a92f1289 
This command allows an admin to flush a specific server
from the resolver caches or flush the whole cache.
Omar007 force-pushed feature/flush-cache from e9a92f1289
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been cancelled
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Has been cancelled
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled
Details
to 37a66e5f80
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m38s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 18m23s
Details
2026-02-10 15:29:11 +00:00 Compare
nex added this to the 0.5.5 milestone 2026-02-10 19:51:22 +00:00
nex approved these changes 2026-02-10 19:51:33 +00:00
nex left a comment
Owner
Copy link

Looks good to me

Looks good to me
Jade approved these changes 2026-02-10 19:51:53 +00:00
ginger approved these changes 2026-02-10 19:52:37 +00:00
Aranjedeath reviewed 2026-02-10 19:56:56 +00:00
docs/reference/admin/query.md Outdated
@ -114,1 +114,4 @@
### `!admin query resolver flush-cache`
Flush a given server from the resolver caches or flush them completely
Aranjedeath commented 2026-02-10 19:56:56 +00:00
Owner
Copy link

can this include an example with all, or a domain, specified

can this include an example with all, or a domain, specified
Omar007 commented 2026-02-10 21:09:05 +00:00
Author
Contributor
Copy link

Done.

Done.
Omar007 force-pushed feature/flush-cache from 37a66e5f80
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m38s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 18m23s
Details
to e9c93c12a0
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m46s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 8m3s
Details
2026-02-10 21:08:44 +00:00 Compare
Omar007 force-pushed feature/flush-cache from e9c93c12a0
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m46s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 8m3s
Details
to ae16a45515
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m39s
Details
Release Docker Image / Build linux-amd64 (release) (push) Waiting to run
Details
Release Docker Image / Build linux-arm64 (release) (push) Waiting to run
Details
Release Docker Image / Create Multi-arch Release Manifest (push) Blocked by required conditions
Details
Release Docker Image / Build linux-amd64 (max-perf) (push) Blocked by required conditions
Details
Release Docker Image / Build linux-arm64 (max-perf) (push) Blocked by required conditions
Details
Release Docker Image / Create Max-Perf Manifest (push) Blocked by required conditions
Details
Documentation / Build and Deploy Documentation (push) Has been cancelled
Details
Checks / Prek / Clippy and Cargo Tests (push) Has been cancelled
Details
Checks / Prek / Pre-commit & Formatting (push) Has been cancelled
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 21m59s
Details
2026-02-10 22:07:44 +00:00 Compare
Omar007 reviewed 2026-02-10 22:08:48 +00:00
src/admin/query/resolver.rs
@ -7,6 +7,7 @@ use crate::{admin_command, admin_command_dispatch};
#[admin_command_dispatch]
#[derive(Debug, Subcommand)]
#[allow(clippy::enum_variant_names)]
Omar007 commented 2026-02-10 22:08:48 +00:00
Author
Contributor
Copy link

Ran tests and pre-commit checks locally and those were all good but saw the clippy workflow fail. I assume we don't want to rename all commands to avoid a suffix or prefix so I've added #[allow(clippy::enum_variant_names)] here.
Is this OK?

Ran tests and pre-commit checks locally and those were all good but saw the clippy workflow fail. I assume we don't want to rename all commands to avoid a suffix or prefix so I've added `#[allow(clippy::enum_variant_names)]` here. Is this OK?
Jade commented 2026-02-10 22:41:52 +00:00
Owner
Copy link

Yeah that's fine. Lots of the admin commands could do with renaming tbh but that would break muscle memory, and this case seems fine to me

Yeah that's fine. Lots of the admin commands could do with renaming tbh but that would break muscle memory, and this case seems fine to me
nex scheduled this pull request to auto merge when all checks succeed 2026-02-10 22:52:04 +00:00
nex merged commit ae16a45515 into main 2026-02-10 22:55:54 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
nex
Jade
ginger
Aranjedeath
Labels
Clear labels   
Blocked

This pull request or issue is currently blocked from being merged/closed

  
Bug

Something isn't working as intended

  
Cherry-picking

Commits picked from other conduit projects

  
Database

This requires or includes changes to the database

  
Dependencies

Something dependency related

  
Dependencies/Renovate

Automatic dependency upgrades by Renovate

  
Difficulty
Easy
Low difficulty to implement - touches few parts of the codebase, low complexity

  
Difficulty
Hard
High difficulty to implement - touches many parts of the codebase, high complexity

  
Difficulty
Medium
Medium difficulty to implement - touches more parts of the codebase, higher complexity

  
Documentation

Improvements or additions to documentation

  
Enhancement

New feature or request

  
Good first issue

Good for newcomers

  
Help wanted

Additional eyes and keyboards are required for this one

  
Inherited

Issues that have been inhereted from the project pre-fork

  
Matrix/Administration

Features pertaining to homeserver administration

  
Matrix/Appservices

Features pertaining to the appservice API

  
Matrix/Auth

Features pertaining to authentication

  
Matrix/Client

Features pertaining to client-to-server interactions

  
Matrix/Core

Issues relating to core matrix functionality, such as state resolution and PDU formats

  
Matrix/Federation

Features pertaining to server-to-server interactions

  
Matrix/Hydra

Issues related to room version 12 and related changes (temporary label)

  
Matrix/MSC

Features pertaining to unstable matrix features

  
Matrix/Media

Features pertaining to media interactions

  
Meta

Related to housekeeping, maintenance, or other repo-meta.

  
Meta/CI

Issues related to CI changes

  
Meta/Packaging

Packaging

  
Priority
Blocking
This issue is blocking the next release

  
Priority
High
This issue is very important

  
Priority
Low
This issue is of a rather low priority

  
Security

This item is related to general security

  
Status
Confirmed
This issue has enough information and is confirmed

  
Status
Duplicate
This issue or pull request already exists

  
Status
Invalid
This issue doesn't seem right

  
Status
Needs Investigation
This issue needs further investigation

  
Support

Questions or support requests

  
To-Merge

   
Wont fix

This will not be worked on

  
old/ci/cd

Ci/CD

Archived

  
old/rust

Pull requests that update Rust code

Archived

No labels
Blocked
Bug
Cherry-picking
Database
Dependencies
Dependencies/Renovate
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/Federation
Matrix/Hydra
Matrix/MSC
Matrix/Media
Meta
Meta/CI
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
Support
To-Merge
Wont fix
old/ci/cd
old/rust
Milestone
Clear milestone
No items
No milestone
0.5.5
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
continuwuation/continuwuity!1349
No description provided.