continuwuation/continuwuity
continuwuation/continuwuity
14
76
Fork 81
Code Issues 106 Pull requests 38 Releases 27 Packages 3 Activity Actions 2

Add TLS options for LDAP #1389

Open
getz wants to merge 1 commit from getz/continuwuity:ldap-tls into main
pull from: getz/continuwuity:ldap-tls
merge into: continuwuation:main
Conversation 2 Commits 1 Files changed 2 +37 -5
getz commented 2026-02-16 00:38:25 +00:00
First-time contributor
Copy link

Optional StartTLS for LDAP and add option to skip TLS verification.

@RatCornu would you mind taking a look.

Optional StartTLS for LDAP and add option to skip TLS verification. @RatCornu would you mind taking a look.
Add LDAP options for TLS
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 5m16s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 14m13s
Details
0ae4eccf97 
Optional StartTLS for LDAP and add option to skip TLS verification.
Jade reviewed 2026-02-16 01:01:13 +00:00
src/service/users/mod.rs
@ -1400,2 +1419,3 @@
let (conn, mut ldap) = Self::create_ldap_connection(config, uri.as_str())
.await
.map_err(|e| err!(Ldap(error!(?user_dn, "LDAP connection setup error: {e}"))))?;
.map_err(|e| err!(Ldap(error!(%user_dn, "{e}"))))?;
Jade commented 2026-02-16 01:01:13 +00:00
Owner
Copy link

Why remove the error messages?

Why remove the error messages?
getz commented 2026-02-16 01:03:52 +00:00
Author
First-time contributor
Copy link

It's not removed look at the function created.

It's not removed look at the function created.
Jade commented 2026-02-16 01:05:14 +00:00
Owner
Copy link

In which case the double-mapping of the error is unnecesary

In which case the double-mapping of the error is unnecesary
nex commented 2026-03-03 18:41:12 +00:00
Owner
Copy link

@Jade wrote in #1389/files (comment):

In which case the double-mapping of the error is unnecesary

double-mapping is required to retain the user_dn thingy

@Jade wrote in https://forgejo.ellis.link/continuwuation/continuwuity/pulls/1389/files#issuecomment-24296: > In which case the double-mapping of the error is unnecesary double-mapping is required to retain the user_dn thingy
RatCornu commented 2026-02-16 08:48:42 +00:00
Contributor
Copy link

This looks good to me: maybe it can be a good idea to add that both options are less secure than using TLS but I don't know the codebase enough to say if it's needed or not

This looks good to me: maybe it can be a good idea to add that both options are less secure than using TLS but I don't know the codebase enough to say if it's needed or not
ginger added this to the next milestone 2026-02-20 14:13:37 +00:00
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 5m16s
Required
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 14m13s
Required
Details
This pull request is blocked because it's outdated.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u ldap-tls:getz-ldap-tls
git switch getz-ldap-tls
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Blocked

This pull request or issue is currently blocked from being merged/closed

  
Bug

Something isn't working as intended

  
Cherry-picking

Commits picked from other conduit projects

  
Database

This requires or includes changes to the database

  
Dependencies

Something dependency related

  
Dependencies/Renovate

Automatic dependency upgrades by Renovate

  
Difficulty
Easy
Low difficulty to implement - touches few parts of the codebase, low complexity

  
Difficulty
Hard
High difficulty to implement - touches many parts of the codebase, high complexity

  
Difficulty
Medium
Medium difficulty to implement - touches more parts of the codebase, higher complexity

  
Documentation

Improvements or additions to documentation

  
Enhancement

New feature or request

  
Good first issue

Good for newcomers

  
Help wanted

Additional eyes and keyboards are required for this one

  
Inherited

Issues that have been inhereted from the project pre-fork

  
Matrix/Administration

Features pertaining to homeserver administration

  
Matrix/Appservices

Features pertaining to the appservice API

  
Matrix/Auth

Features pertaining to authentication

  
Matrix/Client

Features pertaining to client-to-server interactions

  
Matrix/Core

Issues relating to core matrix functionality, such as state resolution and PDU formats

  
Matrix/E2EE

   
Matrix/Federation

Features pertaining to server-to-server interactions

  
Matrix/Hydra

Issues related to room version 12 and related changes (temporary label)

  
Matrix/MSC

Features pertaining to unstable matrix features

  
Matrix/Media

Features pertaining to media interactions

  
Matrix/T&S

Changes or issues related to trust & safety tooling

  
Meta

Related to housekeeping, maintenance, or other repo-meta.

  
Meta/CI

Issues related to CI changes

  
Meta/Packaging

Packaging

  
Priority
Blocking
This issue is blocking the next release

  
Priority
High
This issue is very important

  
Priority
Low
This issue is of a rather low priority

  
Security

This item is related to general security

  
Status
Confirmed
This issue has enough information and is confirmed

  
Status
Duplicate
This issue or pull request already exists

  
Status
Invalid
This issue doesn't seem right

  
Status
Needs Investigation
This issue needs further investigation

  
Support

Questions or support requests

  
To-Merge

   
Wont fix

This will not be worked on

  
old/ci/cd

Ci/CD

Archived

  
old/rust

Pull requests that update Rust code

Archived

No labels
Blocked
Bug
Cherry-picking
Database
Dependencies
Dependencies/Renovate
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/E2EE
Matrix/Federation
Matrix/Hydra
Matrix/MSC
Matrix/Media
Matrix/T&S
Meta
Meta/CI
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
Support
To-Merge
Wont fix
old/ci/cd
old/rust
Milestone
Clear milestone
No items
No milestone
next
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
continuwuation/continuwuity!1389
No description provided.