fix: Crash before starting on OpenBSD #1421

katie · 2026-02-19T14:02:11Z

katie commented

2026-02-19 14:02:11 +00:00

This calculates the max number of senders using core count only when we actually know how many cores there are.

core_affinity doesn't return any cores on OpenBSD, so otherwise we try to clamp(1, 0), which blows up when the bounds are asserted.

A better fix would be adding OpenBSD support to that crate, but that seems hard and still only fixes one unsupported platform.

I also thought about updating available_parallelism instead to never return zero, but the cause of the issue is the odd "conservative" bound and how it's used, so this seemed like a better place to put it. That function is used in other places as well, and I didn't want to introduce weird side effects.

This pull request targets the main branch, and the branch is named something other than
main.
I have written an appropriate pull request title and my description is clear.
I understand I am responsible for the contents of this pull request.
I have followed the contributing guidelines:
- My contribution follows the code style, if applicable.
- I ran pre-commit checks before opening/drafting this pull request.
- I have tested my contribution (or proof-read it for documentation-only changes)
  myself, if applicable. This includes ensuring code compiles.
- My commit messages follow the commit message format and are descriptive.
- I have written a news fragment for this PR, if applicable.

This calculates the max number of senders using core count only when we actually know how many cores there are. core_affinity doesn't return any cores on OpenBSD, so otherwise we try to `clamp(1, 0)`, which blows up when the bounds are asserted. A better fix would be adding OpenBSD support to that crate, but that seems hard and still only fixes one unsupported platform. I also thought about updating `available_parallelism` instead to never return zero, but the cause of the issue is the odd "conservative" bound and how it's used, so this seemed like a better place to put it. That function is used in other places as well, and I didn't want to introduce weird side effects.       - [x] This pull request targets the `main` branch, and the branch is named something other than `main`. - [x] I have written an appropriate pull request title and my description is clear. - [x] I understand I am responsible for the contents of this pull request. - I have followed the [contributing guidelines][c1]: - [x] My contribution follows the [code style][c2], if applicable. - [x] I ran [pre-commit checks][c1pc] before opening/drafting this pull request. - [x] I have [tested my contribution][c1t] (or proof-read it for documentation-only changes) myself, if applicable. This includes ensuring code compiles. - [x] My commit messages follow the [commit message format][c1cm] and are descriptive. - [x] I have written a [news fragment][n1] for this PR, if applicable.  [c1]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md [c2]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/docs/development/code_style.mdx [c1pc]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#pre-commit-checks [c1t]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#running-tests-locally [c1cm]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#commit-messages [n1]: https://towncrier.readthedocs.io/en/stable/tutorial.html#creating-news-fragments

katie added 1 commit

2026-02-19 14:02:11 +00:00

fix: Crash before starting on OpenBSD

Documentation / Build and Deploy Documentation (pull_request) Blocked by required conditions

Details

Checks / Prek / Pre-commit & Formatting (pull_request) Blocked by required conditions

Details

Checks / Prek / Clippy and Cargo Tests (pull_request) Blocked by required conditions

Details

02bec04209

core_affinity doesn't return any cores on OpenBSD, so we try to
clamp(1, 0). This is Less Good than fixing that crate, but at
least allows the server to start up.

katie added 1 commit

2026-02-19 14:05:17 +00:00

docs: Add news fragment

Documentation / Build and Deploy Documentation (pull_request) Has been skipped

Details

Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 5m7s

Details

Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 37m32s

Details

416d0b57c9

ginger approved these changes

2026-02-19 18:54:57 +00:00

nex added the

Bug

label

2026-02-19 21:23:50 +00:00

nex requested changes

2026-02-19 21:50:21 +00:00

Dismissed

nex left a comment

Looks good, I just think the news fragment could be clearer

changelog.d/1421.bugfix Outdated

					
				@ -0,0 +1 @@

				Fixed a crash on startup when running on OpenBSD. Contributed by @katie.

This is quite generic and will lose context when it makes its way into the changelog. I'd suggest describing the specific conditions that caused the crash.

katie marked this conversation as resolved