fix(sync): don't override sliding sync v5 list range start to zero #1445

Merged

ginger merged 1 commit from 0xnim/continuwuity:fix/sync-v5-dont-force-zero into main

2026-02-24 13:59:34 +00:00

0xnim commented

2026-02-23 22:27:06 +00:00

Contributor

This pull request fixes the sliding sync v5 list range start always being
overwritten to 0, causing the server to process and return rooms from the
beginning of the list regardless of the client's requested range. A client
requesting ranges [[20, 49]] would receive rooms 0–49 instead of just 20–49.

The start is now clamped to the list length instead of being zeroed, matching
the expected MSC4186 behavior.

Fixes: #1444

Pull request checklist:

This pull request targets the main branch, and the branch is named something other than
main.
I have written an appropriate pull request title and my description is clear.
I understand I am responsible for the contents of this pull request.
I have followed the contributing guidelines:
- My contribution follows the code style, if applicable.
- I ran pre-commit checks before opening/drafting this pull request.
- I have tested my contribution (or proof-read it for documentation-only changes)
  myself, if applicable. This includes ensuring code compiles.
- My commit messages follow the commit message format and are descriptive.
- I have written a news fragment for this PR, if applicable.

This pull request fixes the sliding sync v5 list range start always being overwritten to `0`, causing the server to process and return rooms from the beginning of the list regardless of the client's requested range. A client requesting ranges `[[20, 49]]` would receive rooms 0–49 instead of just 20–49. The start is now clamped to the list length instead of being zeroed, matching the expected MSC4186 behavior.   Fixes: #1444  **Pull request checklist:**  - [X] This pull request targets the `main` branch, and the branch is named something other than `main`. - [X] I have written an appropriate pull request title and my description is clear. - [X] I understand I am responsible for the contents of this pull request. - I have followed the [contributing guidelines][c1]: - [X] My contribution follows the [code style][c2], if applicable. - [X] I ran [pre-commit checks][c1pc] before opening/drafting this pull request. - [X] I have [tested my contribution][c1t] (or proof-read it for documentation-only changes) myself, if applicable. This includes ensuring code compiles. - [X] My commit messages follow the [commit message format][c1cm] and are descriptive. - [X] I have written a [news fragment][n1] for this PR, if applicable.  [c1]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md [c2]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/docs/development/code_style.mdx [c1pc]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#pre-commit-checks [c1t]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#running-tests-locally [c1cm]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#commit-messages [n1]: https://towncrier.readthedocs.io/en/stable/tutorial.html#creating-news-fragments

0xnim added 1 commit

2026-02-23 22:27:06 +00:00