continuwuation/continuwuity
continuwuation/continuwuity
14
77
Fork 81
Code Issues 106 Pull requests 37 Releases 27 Packages 3 Activity Actions 1

feat(url-preview): Optionally download audio/video files for url preview requests #1473

Open
trashpanda wants to merge 6 commits from trashpanda/continuwuity:trashpanda/url-preview-videos into main
pull from: trashpanda/continuwuity:trashpanda/url-preview-videos
merge into: continuwuation:main
Conversation 3 Commits 6 Files changed 5 +239 -23
trashpanda commented 2026-02-28 07:05:27 +00:00
Contributor
Copy link

This pull request adds audio and video files to URL previews and downloads them, if they are present and the config option is enabled.

Pull request checklist:

  • This pull request targets the main branch, and the branch is named something other than
    main.
  • I have written an appropriate pull request title and my description is clear.
  • I understand I am responsible for the contents of this pull request.
  • I have followed the contributing guidelines:
This pull request adds audio and video files to URL previews and downloads them, if they are present and the config option is enabled. **Pull request checklist:** - [x] This pull request targets the `main` branch, and the branch is named something other than `main`. - [x] I have written an appropriate pull request title and my description is clear. - [x] I understand I am responsible for the contents of this pull request. - I have followed the [contributing guidelines][c1]: - [x] My contribution follows the [code style][c2], if applicable. - [x] I ran [pre-commit checks][c1pc] before opening/drafting this pull request. - [x] I have [tested my contribution][c1t] (or proof-read it for documentation-only changes) myself, if applicable. This includes ensuring code compiles. - [x] My commit messages follow the [commit message format][c1cm] and are descriptive. - [ ] I have written a [news fragment][n1] for this PR, if applicable<!--(can be done after hitting open!)-->. [c1]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md [c2]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/docs/development/code_style.mdx [c1pc]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#pre-commit-checks [c1t]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#running-tests-locally [c1cm]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#commit-messages [n1]: https://towncrier.readthedocs.io/en/stable/tutorial.html#creating-news-fragments
feat(url-preview): Optionally download audio/video files for url preview requests
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m34s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled
Details
53df59b9a0
fix: Update example config
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m28s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 15m53s
Details
fa47417cdc
Henry-Hiles requested changes 2026-02-28 15:14:59 +00:00
Dismissed
Henry-Hiles left a comment
Contributor
Copy link

Can we check file size against max_request_size before downloading? Just to stop someone sending, e.g. a 20gb video and filling up a servers disk space.

Can we check file size against `max_request_size` before downloading? Just to stop someone sending, e.g. a 20gb video and filling up a servers disk space.
fix: Refactor and block media downloads larger than max_request_size
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Has been cancelled
Details
8e7e81453e
fix: Clippy lints
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 3m21s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 17m54s
Details
0b666fc948
fix: Retrieve content_type and video width/height
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 3m3s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 17m42s
Details
5b712416c5
trashpanda changed title from WIP: feat(url-preview): Optionally download audio/video files for url preview requests to feat(url-preview): Optionally download audio/video files for url preview requests 2026-03-02 03:40:08 +00:00
ginger force-pushed trashpanda/url-preview-videos from 5b712416c5
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 3m3s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 17m42s
Details
to 01d6d6e3d8
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 4m22s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 38m41s
Details
2026-03-04 14:51:26 +00:00 Compare
ginger approved these changes 2026-03-04 14:55:33 +00:00
src/service/globals/mod.rs
@ -143,2 +143,4 @@
}
pub fn url_preview_allow_audio_video(&self) -> bool {
self.server.config.url_preview_allow_audio_video
ginger commented 2026-03-04 14:54:28 +00:00
Owner
Copy link

I really need to remove all these functions from globals. problems for a future PR

I really need to remove all these functions from globals. problems for a future PR
Henry-Hiles approved these changes 2026-03-04 19:09:27 +00:00
Henry-Hiles left a comment
Contributor
Copy link

LGTM, but I don't really do rust so most of this is magic to me :3

LGTM, but I don't really do rust so most of this is magic to me :3
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 4m22s
Required
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 38m41s
Required
Details
This pull request is blocked because it's outdated.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u trashpanda/url-preview-videos:trashpanda-trashpanda/url-preview-videos
git switch trashpanda-trashpanda/url-preview-videos
Sign in to join this conversation.
Reviewers
No reviewers
ginger
Henry-Hiles
Labels
Clear labels   
Blocked

This pull request or issue is currently blocked from being merged/closed

  
Bug

Something isn't working as intended

  
Cherry-picking

Commits picked from other conduit projects

  
Database

This requires or includes changes to the database

  
Dependencies

Something dependency related

  
Dependencies/Renovate

Automatic dependency upgrades by Renovate

  
Difficulty
Easy
Low difficulty to implement - touches few parts of the codebase, low complexity

  
Difficulty
Hard
High difficulty to implement - touches many parts of the codebase, high complexity

  
Difficulty
Medium
Medium difficulty to implement - touches more parts of the codebase, higher complexity

  
Documentation

Improvements or additions to documentation

  
Enhancement

New feature or request

  
Good first issue

Good for newcomers

  
Help wanted

Additional eyes and keyboards are required for this one

  
Inherited

Issues that have been inhereted from the project pre-fork

  
Matrix/Administration

Features pertaining to homeserver administration

  
Matrix/Appservices

Features pertaining to the appservice API

  
Matrix/Auth

Features pertaining to authentication

  
Matrix/Client

Features pertaining to client-to-server interactions

  
Matrix/Core

Issues relating to core matrix functionality, such as state resolution and PDU formats

  
Matrix/E2EE

   
Matrix/Federation

Features pertaining to server-to-server interactions

  
Matrix/Hydra

Issues related to room version 12 and related changes (temporary label)

  
Matrix/MSC

Features pertaining to unstable matrix features

  
Matrix/Media

Features pertaining to media interactions

  
Matrix/T&S

Changes or issues related to trust & safety tooling

  
Meta

Related to housekeeping, maintenance, or other repo-meta.

  
Meta/CI

Issues related to CI changes

  
Meta/Packaging

Packaging

  
Priority
Blocking
This issue is blocking the next release

  
Priority
High
This issue is very important

  
Priority
Low
This issue is of a rather low priority

  
Security

This item is related to general security

  
Status
Confirmed
This issue has enough information and is confirmed

  
Status
Duplicate
This issue or pull request already exists

  
Status
Invalid
This issue doesn't seem right

  
Status
Needs Investigation
This issue needs further investigation

  
Support

Questions or support requests

  
To-Merge

   
Wont fix

This will not be worked on

  
old/ci/cd

Ci/CD

Archived

  
old/rust

Pull requests that update Rust code

Archived

No labels
Blocked
Bug
Cherry-picking
Database
Dependencies
Dependencies/Renovate
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/E2EE
Matrix/Federation
Matrix/Hydra
Matrix/MSC
Matrix/Media
Matrix/T&S
Meta
Meta/CI
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
Support
To-Merge
Wont fix
old/ci/cd
old/rust
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
continuwuation/continuwuity!1473
No description provided.