continuwuation/continuwuity
continuwuation/continuwuity
13
79
Fork 85
Code Issues 117 Pull requests 43 Releases 27 Packages 3 Activity Actions 5

fix: Invalidate space hierarchy cache on room join/leave events #1524

Open
javif89 wants to merge 2 commits from javif89/continuwuity:fix/invalidate-hierarchy-cache-on-room-event into main
pull from: javif89/continuwuity:fix/invalidate-hierarchy-cache-on-room-event
merge into: continuwuation:main
Conversation 1 Commits 2 Files changed 6 +75 -34
javif89 commented 2026-03-10 03:58:53 +00:00
First-time contributor
Copy link

This pull request adds SpaceRoomHierarchy cache invalidation on room join/leave events.

This change should prevent potentially dead rooms from showing up in clients, and make it easier
to make decisions based on a room's member count returned from the /[room id]/hierarchy endpoint.

I moved the roomid_spacehierarchy_cache up a level to the state_cache so it could be accessed in update_joined_count.
Otherwise we would have to invalidate the cache in any other spot where the member count might change.

Closes #1522

Pull request checklist:

  • This pull request targets the main branch, and the branch is named something other than
    main.
  • I have written an appropriate pull request title and my description is clear.
  • I understand I am responsible for the contents of this pull request.
  • I have followed the contributing guidelines:
This pull request adds `SpaceRoomHierarchy` cache invalidation on room join/leave events. This change should prevent potentially dead rooms from showing up in clients, and make it easier to make decisions based on a room's member count returned from the `/[room id]/hierarchy` endpoint. I moved the `roomid_spacehierarchy_cache` up a level to the `state_cache` so it could be accessed in `update_joined_count`. Otherwise we would have to invalidate the cache in any other spot where the member count might change. Closes #1522 **Pull request checklist:** - [x] This pull request targets the `main` branch, and the branch is named something other than `main`. - [x] I have written an appropriate pull request title and my description is clear. - [x] I understand I am responsible for the contents of this pull request. - I have followed the [contributing guidelines][c1]: - [x] My contribution follows the [code style][c2], if applicable. - [x] I ran [pre-commit checks][c1pc] before opening/drafting this pull request. - [x] I have [tested my contribution][c1t] (or proof-read it for documentation-only changes) myself, if applicable. This includes ensuring code compiles. - [x] My commit messages follow the [commit message format][c1cm] and are descriptive. - [ ] I have written a [news fragment][n1] for this PR, if applicable<!--(can be done after hitting open!)-->. [c1]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md [c2]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/docs/development/code_style.mdx [c1pc]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#pre-commit-checks [c1t]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#running-tests-locally [c1cm]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#commit-messages [n1]: https://towncrier.readthedocs.io/en/stable/tutorial.html#creating-news-fragments
fix: Invalidate space hierarchy cache on room join/leave events
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been cancelled
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Has been cancelled
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled
Details
Update flake hashes / update-flake-hashes (pull_request) Has been cancelled
Details
e5ccee1b99
ginger requested changes 2026-03-11 12:51:50 +00:00
ginger left a comment
Owner
Copy link

a few preliminary thoughts

a few preliminary thoughts
.pre-commit-config.yaml Outdated
@ -40,7 +40,7 @@ repos:
hooks:
- id: cargo-fmt
name: cargo fmt
entry: cargo +nightly fmt --
ginger commented 2026-03-11 12:48:18 +00:00
Owner
Copy link

this is supposed to use nightly

this is supposed to use nightly
javif89 commented 2026-03-11 21:07:31 +00:00
Author
First-time contributor
Copy link

Reverted 👍

Reverted 👍
nex marked this conversation as resolved
nix/shells/default.nix Outdated
@ -21,8 +21,28 @@
pkgs.liburing
pkgs.rust-jemalloc-sys-unprefixed
rocksdbAllFeatures
# Pre commit support
ginger commented 2026-03-11 12:48:42 +00:00
Owner
Copy link

these nix changes should go in their own PR

these nix changes should go in their own PR
javif89 commented 2026-03-11 21:07:37 +00:00
Author
First-time contributor
Copy link

Reverted

Reverted
nex marked this conversation as resolved
chore: Restore pre-commit config and nix shell to previous state
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m56s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 16m4s
Details
f402aaa84d
javif89 changed title from WIP: fix: Invalidate space hierarchy cache on room join/leave events to fix: Invalidate space hierarchy cache on room join/leave events 2026-03-11 21:07:14 +00:00
javif89 requested review from ginger 2026-03-12 16:10:58 +00:00
javif89 force-pushed fix/invalidate-hierarchy-cache-on-room-event from f402aaa84d
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m56s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 16m4s
Details
to 582e2aa9a8
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 3m4s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 14m52s
Details
2026-03-15 00:55:27 +00:00 Compare
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 3m4s
Required
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 14m52s
Required
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u fix/invalidate-hierarchy-cache-on-room-event:javif89-fix/invalidate-hierarchy-cache-on-room-event
git switch javif89-fix/invalidate-hierarchy-cache-on-room-event
Sign in to join this conversation.
Reviewers
No reviewers
ginger
Labels
Clear labels   
Blocked

This pull request or issue is currently blocked from being merged/closed

  
Bug

Something isn't working as intended

  
Cherry-picking

Commits picked from other conduit projects

  
Database

This requires or includes changes to the database

  
Dependencies

Something dependency related

  
Dependencies/Renovate

Automatic dependency upgrades by Renovate

  
Difficulty
Easy
Low difficulty to implement - touches few parts of the codebase, low complexity

  
Difficulty
Hard
High difficulty to implement - touches many parts of the codebase, high complexity

  
Difficulty
Medium
Medium difficulty to implement - touches more parts of the codebase, higher complexity

  
Documentation

Improvements or additions to documentation

  
Enhancement

New feature or request

  
Good first issue

Good for newcomers

  
Help wanted

Additional eyes and keyboards are required for this one

  
Inherited

Issues that have been inhereted from the project pre-fork

  
Matrix/Administration

Features pertaining to homeserver administration

  
Matrix/Appservices

Features pertaining to the appservice API

  
Matrix/Auth

Features pertaining to authentication

  
Matrix/Client

Features pertaining to client-to-server interactions

  
Matrix/Core

Issues relating to core matrix functionality, such as state resolution and PDU formats

  
Matrix/E2EE

   
Matrix/Federation

Features pertaining to server-to-server interactions

  
Matrix/Hydra

Issues related to room version 12 and related changes (temporary label)

  
Matrix/MSC

Features pertaining to unstable matrix features

  
Matrix/Media

Features pertaining to media interactions

  
Matrix/T&S

Changes or issues related to trust & safety tooling

  
Meta

Related to housekeeping, maintenance, or other repo-meta.

  
Meta/CI

Issues related to CI changes

  
Meta/Packaging

Packaging

  
Priority
Blocking
This issue is blocking the next release

  
Priority
High
This issue is very important

  
Priority
Low
This issue is of a rather low priority

  
Security

This item is related to general security

  
Status
Confirmed
This issue has enough information and is confirmed

  
Status
Duplicate
This issue or pull request already exists

  
Status
Invalid
This issue doesn't seem right

  
Status
Needs Investigation
This issue needs further investigation

  
Support

Questions or support requests

  
To-Merge

   
Wont fix

This will not be worked on

  
old/ci/cd

Ci/CD

Archived

  
old/rust

Pull requests that update Rust code

Archived

No labels
Blocked
Bug
Cherry-picking
Database
Dependencies
Dependencies/Renovate
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/E2EE
Matrix/Federation
Matrix/Hydra
Matrix/MSC
Matrix/Media
Matrix/T&S
Meta
Meta/CI
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
Support
To-Merge
Wont fix
old/ci/cd
old/rust
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
continuwuation/continuwuity!1524
No description provided.