continuwuation/continuwuity
continuwuation/continuwuity
15
87
Fork 101
Code Issues 130 Pull requests 19 Releases 29 Packages 3 Activity Actions 10

feat: Add option for a noindex meta tag on the HTML index page #1531

Merged
ginger merged 27 commits from s1lv3r/continuwuity:1527-prevent-search-engine-indexing into ginger/password-reset 2026-03-18 16:12:40 +00:00
Conversation 11 Commits 27 Files changed 8 +98 -36
s1lv3r commented 2026-03-11 15:01:35 +00:00
Contributor
Copy link

Adds a new config option index_page_allow_indexing which defaults to false.

Fixes: !1527

News-fragment is TODO

Pull request checklist:

  • This pull request targets the main branch, and the branch is named something other than
    main.
  • I have written an appropriate pull request title and my description is clear.
  • I understand I am responsible for the contents of this pull request.
  • I have followed the contributing guidelines:
Adds a new config option `index_page_allow_indexing` which defaults to false. Fixes: !1527 News-fragment is TODO <!-- In order to help reviewers know what your pull request does at a glance, you should ensure that 1. Your PR title is a short, single sentence describing what you changed 2. You have described in more detail what you have changed, why you have changed it, what the intended effect is, and why you think this will be beneficial to the project. If you have made any potentially strange/questionable design choices, but didn't feel they'd benefit from code comments, please don't mention them here - after opening your pull request, go to "files changed", and click on the "+" symbol in the line number gutter, and attach comments to the lines that you think would benefit from some clarification. --> <!-- Example: This pull request allows us to warp through time and space ten times faster than before by double-inverting the warp drive with hyperheated jump fluid, both making the drive faster and more efficient. This resolves the common issue where we have to wait more than 10 milliseconds to engage, use, and disengage the warp drive when travelling between galaxies. --> <!-- Closes: #... --> <!-- Fixes: #... --> <!-- Uncomment the above line(s) if your pull request fixes an issue or closes another pull request by superseding it. Replace `#...` with the issue/pr number, such as `#123`. --> **Pull request checklist:** <!-- You need to complete these before your PR can be considered. If you aren't sure about some, feel free to ask for clarification in #dev:continuwuity.org. --> - [x] This pull request targets the `main` branch, and the branch is named something other than `main`. - [x] I have written an appropriate pull request title and my description is clear. - [x] I understand I am responsible for the contents of this pull request. - I have followed the [contributing guidelines][c1]: - [x] My contribution follows the [code style][c2], if applicable. - [x] I ran [pre-commit checks][c1pc] before opening/drafting this pull request. - [x] I have [tested my contribution][c1t] (or proof-read it for documentation-only changes) myself, if applicable. This includes ensuring code compiles. - [x] My commit messages follow the [commit message format][c1cm] and are descriptive. - [ ] I have written a [news fragment][n1] for this PR, if applicable<!--(can be done after hitting open!)-->. <!-- Notes on these requirements: - While not required, we encourage you to sign your commits with GPG or SSH to attest the authenticity of your changes. - While we allow LLM-assisted contributions, we do not appreciate contributions that are low quality, which is typical of machine-generated contributions that have not had a lot of love and care from a human. Please do not open a PR if all you have done is asked ChatGPT to tidy up the codebase with a +-100,000 diff. - In the case of code style violations, reviewers may leave review comments/change requests indicating what the ideal change would look like. For example, a reviewer may suggest you lower a log level, or use `match` instead of `if/else` etc. - In the case of code style violations, pre-commit check failures, minor things like typos/spelling errors, and in some cases commit format violations, reviewers may modify your branch directly, typically by making changes and adding a commit. Particularly in the latter case, a reviewer may rebase your commits to squash "spammy" ones (like "fix", "fix", "actually fix"), and reword commit messages that don't satisfy the format. - Pull requests MUST pass the `Checks` CI workflows to be capable of being merged. This can only be bypassed in exceptional circumstances. If your CI flakes, let us know in matrix:r/dev:continuwuity.org. - Pull requests have to be based on the latest `main` commit before being merged. If the main branch changes while you're making your changes, you should make sure you rebase on main before opening a PR. Your branch will be rebased on main before it is merged if it has fallen behind. - We typically only do fast-forward merges, so your entire commit log will be included. Once in main, it's difficult to get out cleanly, so put on your best dress, smile for the cameras! --> [c1]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md [c2]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/docs/development/code_style.mdx [c1pc]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#pre-commit-checks [c1t]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#running-tests-locally [c1cm]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#commit-messages [n1]: https://towncrier.readthedocs.io/en/stable/tutorial.html#creating-news-fragments
Jade approved these changes 2026-03-11 15:06:50 +00:00
Jade left a comment
Copy link

Feel like this is going to have some conflicts with #1484 but otherwise looks good

Feel like this is going to have some conflicts with #1484 but otherwise looks good
s1lv3r commented 2026-03-11 15:10:53 +00:00
Author
Contributor
Copy link

Hm yeah, you might be right.. Unsure what the best way to solve it is, possibly make this PR based on that one instead and wait for it to be merged first? Alternatively the changes are smallish, so wouldn't be too difficult to update that one if this gets merged first.

cc. @ginger, you might have feedback here?

Hm yeah, you might be right.. Unsure what the best way to solve it is, possibly make this PR based on that one instead and wait for it to be merged first? Alternatively the changes are smallish, so wouldn't be too difficult to update that one if this gets merged first. cc. @ginger, you might have feedback here?
Jade commented 2026-03-11 15:13:14 +00:00
Owner
Copy link

You can probably make a pull request against ginger's branch so it gets merged in there. Not sure if you can edit this one though

You can probably make a pull request against ginger's branch so it gets merged in there. Not sure if you can edit this one though
s1lv3r commented 2026-03-11 15:14:05 +00:00
Author
Contributor
Copy link

I'm able to change the target of this one, gimme a sec + time to fix conflicts

I'm able to change the target of this one, gimme a sec + time to fix conflicts
s1lv3r changed target branch from main to ginger/password-reset 2026-03-11 15:14:26 +00:00
Henry-Hiles requested changes 2026-03-11 15:28:31 +00:00
docs/advanced/delegation.mdx Outdated
@ -111,4 +111,1 @@
"base_url": "https://matrix.example.com/"
},
"org.matrix.msc3575.proxy": {
"url": "https://matrix.example.com/"
Henry-Hiles commented 2026-03-11 15:28:29 +00:00
Contributor
Copy link

This doesn't seem related?

This doesn't seem related?
s1lv3r commented 2026-03-11 15:30:07 +00:00
Author
Contributor
Copy link

i believe its due to changing the target branch, this one is technically ahead of ginger/password-reset. I'm working on rebasing but its taking a sec, will likely be fixed when i push an updated branch

i believe its due to changing the target branch, this one is technically ahead of ginger/password-reset. I'm working on rebasing but its taking a sec, will likely be fixed when i push an updated branch
Jade commented 2026-03-11 15:35:36 +00:00
Owner
Copy link

Yep. Three commits ahead

Yep. Three commits ahead
Jade marked this conversation as resolved
s1lv3r force-pushed 1527-prevent-search-engine-indexing from 15a8cfe3d1
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m48s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 16m28s
Details
to 8575d8f3ff
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Has been cancelled
Details
2026-03-11 15:50:57 +00:00 Compare
s1lv3r force-pushed 1527-prevent-search-engine-indexing from 8575d8f3ff
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Has been cancelled
Details
to ded23b56ac
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Has been cancelled
Details
2026-03-11 15:52:29 +00:00 Compare
fix: Fix logic error
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 3m12s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 19m20s
Details
86699add33
s1lv3r commented 2026-03-11 15:55:57 +00:00
Author
Contributor
Copy link

It doesn't error anymore, but I was unable to find a way to avoid specifying allow_indexing on every template. A solution like conduwuit_build_metadata::version_tag() won't work as these return static values from what i can see, and services.config.index_page_allow_indexing is dynamic.

It doesn't error anymore, but I was unable to find a way to avoid specifying `allow_indexing` on every template. A solution like `conduwuit_build_metadata::version_tag()` won't work as these return static values from what i can see, and `services.config.index_page_allow_indexing` is dynamic.
nex approved these changes 2026-03-13 12:04:44 +00:00
ginger commented 2026-03-13 13:03:08 +00:00
Owner
Copy link

I need to take a look at this to see if there's a way to not pass allow_indexing to every template

I need to take a look at this to see if there's a way to not pass `allow_indexing` to every template
feat: Use a context struct to store global template context
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Has been cancelled
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled
Details
9a65e558e3
chore: Update news fragment
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m48s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 13m32s
Details
6134917e65
ginger requested changes 2026-03-18 14:28:55 +00:00
Dismissed
conduwuit-example.toml Outdated
@ -1802,0 +1802,4 @@
# Allow or disallow search engine crawling by adding
# `<meta name="robots" content="noindex" />` to the index page.
#
#index_page_allow_indexing = false
ginger commented 2026-03-18 14:28:37 +00:00
Owner
Copy link

This option is weirdly named, since it applies to all pages, not just the index

This option is weirdly named, since it applies to all pages, not just the index
s1lv3r commented 2026-03-18 14:31:27 +00:00
Author
Contributor
Copy link

That's a good point, will update to allow_web_indexing once I'm on my pc

That's a good point, will update to `allow_web_indexing` once I'm on my pc
s1lv3r marked this conversation as resolved
chore: Merge branch 'ginger/password-reset' into 1527-prevent-search-engine-indexing
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 3m16s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled
Details
30199f9d33
chore: Rename option index_page_allow_indexing to allow_web_indexing
Some checks are pending
Documentation / Build and Deploy Documentation (pull_request) Waiting to run
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Waiting to run
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Waiting to run
Details
cbdcd4a774
ginger requested changes 2026-03-18 16:01:30 +00:00
Dismissed
src/core/config/mod.rs Outdated
@ -2094,2 +2094,4 @@
pub force_disable_first_run_mode: bool,
/// Allow or disallow search engine crawling by adding
/// `<meta name="robots" content="noindex" />` to the index page.
ginger commented 2026-03-18 16:01:29 +00:00
Owner
Copy link

this doc comment is still incorrect :(

this doc comment is still incorrect :(
s1lv3r marked this conversation as resolved
ginger force-pushed 1527-prevent-search-engine-indexing from 52b36f3ff2
Some checks are pending
Documentation / Build and Deploy Documentation (pull_request) Waiting to run
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Waiting to run
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Waiting to run
Details
to 82ad7515ce
Some checks failed
Update flake hashes / update-flake-hashes (pull_request) Waiting to run
Details
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m42s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 24m33s
Details
2026-03-18 16:09:03 +00:00 Compare
ginger approved these changes 2026-03-18 16:11:07 +00:00
ginger left a comment
Copy link

image

![image](/attachments/7d567909-b3c3-4584-ad8e-b59092db9d82)
image.png
457 KiB
ginger merged commit 82ad7515ce into ginger/password-reset 2026-03-18 16:12:40 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Jade
Henry-Hiles
nex
ginger
Labels
Clear labels   
Blocked
This pull request or issue is currently blocked from being merged/closed

  
Bug
Something isn't working as intended

  
Changelog
Added
 Changelog entry added

  
Changelog
Missing
 No changelog when one is needed

  
Changelog
None
 Changelog is unnecesary for this change

  
Cherry-picking
Commits picked from other conduit projects

  
Database
This requires or includes changes to the database

  
Dependencies
Something dependency related

  
Dependencies/Renovate
Automatic dependency upgrades by Renovate

  
Difficulty
Easy
 Low difficulty to implement - touches few parts of the codebase, low complexity

  
Difficulty
Hard
 High difficulty to implement - touches many parts of the codebase, high complexity

  
Difficulty
Medium
 Medium difficulty to implement - touches more parts of the codebase, higher complexity

  
Documentation
Improvements or additions to documentation

  
Enhancement
New feature or request

  
Good first issue
Good for newcomers

  
Help wanted
Additional eyes and keyboards are required for this one

  
Inherited
Issues that have been inhereted from the project pre-fork

  
Matrix/Administration
Features pertaining to homeserver administration

  
Matrix/Appservices
Features pertaining to the appservice API

  
Matrix/Auth
Features pertaining to authentication

  
Matrix/Client
Features pertaining to client-to-server interactions

  
Matrix/Core
Issues relating to core matrix functionality, such as state resolution and PDU formats

  
Matrix/E2EE
Issues related to end to end encryption

  
Matrix/Federation
Features pertaining to server-to-server interactions

  
Matrix/Hydra
Issues related to room version 12 and related changes (temporary label)

  
Matrix/MSC
Features pertaining to unstable matrix features

  
Matrix/Media
Features pertaining to media interactions

  
Matrix/T&S
Changes or issues related to trust & safety tooling

  
Merge
This PR is ready to be merged

  
Merge/Manual
This PR should be manually merged

  
Merge/Squash
This PR should be squashed when it is merged

  
Meta
Related to housekeeping, maintenance, or other repo-meta.

  
Meta/CI
Issues related to CI changes

  
Meta/Packaging
Packaging

  
Priority
Blocking
 This issue is blocking the next release

  
Priority
High
 This issue is very important

  
Priority
Low
 This issue is of a rather low priority

  
Security
This item is related to general security

  
Status
Confirmed
 This issue has enough information and is confirmed

  
Status
Duplicate
 This issue or pull request already exists

  
Status
Invalid
 This issue doesn't seem right

  
Status
Needs Investigation
 This issue needs further investigation

  
Support
Questions or support requests

  
Wont fix
This will not be worked on

  
old/ci/cd
Ci/CD

Archived

  
old/rust
Pull requests that update Rust code

Archived

No labels
Blocked
Bug
Changelog
Added
Changelog
Missing
Changelog
None
Cherry-picking
Database
Dependencies
Dependencies/Renovate
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/E2EE
Matrix/Federation
Matrix/Hydra
Matrix/MSC
Matrix/Media
Matrix/T&S
Merge
Merge/Manual
Merge/Squash
Meta
Meta/CI
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
Support
Wont fix
old/ci/cd
old/rust
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
continuwuation/continuwuity!1531
No description provided.