Realized code for fix did in fact require a check for
`join_authorized_via_users_server` before stripping. Otherwise,
waste processing power, most of the time.
Signed-off-by: Jonathan Sutton <jonathansutton91@proton.me>
Removed extra clone() and made membership_content mutable, to change
contents and reserialize to json.
Signed-off-by: Jonathan Sutton <jonathansutton91@proton.me>
Some clients were sending join_authorized_via_users_server when they
were already in the room, to change nicknames. This caused an undesirable
error, so a check for if they were already in the room was moved and
changed to strip from metadata before attempting to process metadata.
Signed-off-by: Jonathan Sutton <jonathansutton91@proton.me>