fix(room_member): Strip join_authorized_via_users_server (#1542) #1547

Merged
ginger merged 7 commits from Partha/continuwuity:bugfix/1542-room-member-strip into main 2026-03-24 13:11:26 +00:00

2026-03-23

Jonathan Sutton
fix(room_member): Strip join_authorized_via_users_server (#1542)
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 3m5s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 25m19s
Realized code for fix did in fact require a check for
`join_authorized_via_users_server` before stripping. Otherwise,
waste processing power, most of the time.

Signed-off-by: Jonathan Sutton <jonathansutton91@proton.me>
2026-03-23 21:15:31 +00:00
Jonathan Sutton
fix(room_member): Strip join_authorized_via_users_server (#1542)
Fixed test.

Signed-off-by: Jonathan Sutton <jonathansutton91@proton.me>
2026-03-23 21:15:31 +00:00
Jonathan Sutton
fix(room_member): Strip join_authorized_via_users_server (#1542)
Added test.

Signed-off-by: Jonathan Sutton <jonathansutton91@proton.me>
2026-03-23 21:15:31 +00:00
Jonathan Sutton
fix(room_member): Strip join_authorized_via_users_server (#1542)
Removed extra clone() and made membership_content mutable, to change
contents and reserialize to json.

Signed-off-by: Jonathan Sutton <jonathansutton91@proton.me>
2026-03-23 21:15:31 +00:00
Jonathan Sutton
fix(room_member): Strip join_authorized_via_users_server (#1542)
Added news fragment.

Signed-off-by: Jonathan Sutton <jonathansutton91@proton.me>
2026-03-23 21:15:31 +00:00
Jonathan Sutton
fix(room_member): Strip join_authorized_via_users_server (#1542)
Actually implemented fix. Modified json if user was already a member.

Signed-off-by: Jonathan Sutton <jonathansutton91@proton.me>
2026-03-23 21:15:31 +00:00
Jonathan Sutton
fix(room_member): Strip join_authorized_via_users_server (#1542)
Some clients were sending join_authorized_via_users_server when they
were already in the room, to change nicknames. This caused an undesirable
error, so a check for if they were already in the room was moved and
changed to strip from metadata before attempting to process metadata.

Signed-off-by: Jonathan Sutton <jonathansutton91@proton.me>
2026-03-23 21:15:31 +00:00