Fix caching server name resolution for SRV-only servers #1615

Merged

Aranjedeath merged 1 commit from tulir/continuwuity:fix-srv-only-cache into main

2026-04-06 19:57:06 +00:00

tulir commented

2026-04-06 11:21:53 +00:00

Contributor

The cursed resolver will cache the SRV result for the server_name domain, but this early cache was preventing that. Since all the actual_dest_* methods already call query_and_cache, there shouldn't be any need to call it beforehand.

Pull request checklist:

This pull request targets the main branch, and the branch is named something other than
main.
I have written an appropriate pull request title and my description is clear.
I understand I am responsible for the contents of this pull request.
I have followed the contributing guidelines:
- My contribution follows the code style, if applicable.
- I ran pre-commit checks before opening/drafting this pull request.
- I have tested my contribution (or proof-read it for documentation-only changes)
  myself, if applicable. This includes ensuring code compiles.
- My commit messages follow the commit message format and are descriptive.
- I have written a news fragment for this PR, if applicable.

The cursed resolver will cache the SRV result for the server_name domain, but this early cache was preventing that. Since all the `actual_dest_*` methods already call query_and_cache, there shouldn't be any need to call it beforehand. **Pull request checklist:**  - [x] This pull request targets the `main` branch, and the branch is named something other than `main`. - [x] I have written an appropriate pull request title and my description is clear. - [x] I understand I am responsible for the contents of this pull request. - I have followed the [contributing guidelines][c1]: - [x] My contribution follows the [code style][c2], if applicable. - [ ] I ran [pre-commit checks][c1pc] before opening/drafting this pull request. - [x] I have [tested my contribution][c1t] (or proof-read it for documentation-only changes) myself, if applicable. This includes ensuring code compiles. - [ ] My commit messages follow the [commit message format][c1cm] and are descriptive. - [x] I have written a [news fragment][n1] for this PR, if applicable. [c1]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md [c2]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/docs/development/code_style.mdx [c1pc]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#pre-commit-checks [c1t]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#running-tests-locally [c1cm]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#commit-messages [n1]: https://towncrier.readthedocs.io/en/stable/tutorial.html#creating-news-fragments

tulir added 1 commit

2026-04-06 11:21:53 +00:00

Fix caching server name resolution for SRV-only servers

Check Changelog / Check for changelog (pull_request_target) Successful in 10s

Details

Documentation / Build and Deploy Documentation (pull_request) Has been cancelled

Details

Checks / Prek / Pre-commit & Formatting (pull_request) Has been cancelled

Details

Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled

Details

ab12ab727b

The cursed resolver will cache the SRV result for the server_name
domain, but this early cache was preventing that. Since all the
`actual_dest_*` methods already call query_and_cache, there shouldn't
be any need to call it beforehand.

tulir added 1 commit

2026-04-06 12:28:30 +00:00

Add newsfile

Check Changelog / Check for changelog (pull_request_target) Successful in 9s

Details

Documentation / Build and Deploy Documentation (pull_request) Has been skipped

Details

Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 3m7s

Details

Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled

Details

71524384e3