fix: "Sender must be a local user" error for make_* federation routes #1623

Merged

nex merged 4 commits from nex/fix/make-xyz-sender-error into main

2026-04-08 17:17:15 +00:00

nex commented

2026-04-07 17:34:52 +00:00

Owner

This pull request fixes a bug introduced in 688cd8f46a that resulted in make_join, make_knock, and make_leave all not working. This PR separates the event creation function into its own one, and delegates hashing and signing (which these endpoints do not need to do) to the original function. This allows us to thus create unsigned and unhashed events, which can then be returned to these endpoints.

Pull request checklist:

This pull request targets the main branch, and the branch is named something other than
main.
I have written an appropriate pull request title and my description is clear.
I understand I am responsible for the contents of this pull request.
I have followed the contributing guidelines:
- My contribution follows the code style, if applicable.
- I ran pre-commit checks before opening/drafting this pull request.
- I have tested my contribution (or proof-read it for documentation-only changes)
  myself, if applicable. This includes ensuring code compiles.
- My commit messages follow the commit message format and are descriptive.
- I have written a news fragment for this PR, if applicable.

This pull request fixes a bug introduced in 688cd8f46a69bbc7b31e1668df5f7ca4e751eb82 that resulted in `make_join`, `make_knock`, and `make_leave` all not working. This PR separates the event creation function into its own one, and delegates hashing and signing (which these endpoints do not need to do) to the original function. This allows us to thus create unsigned and unhashed events, which can then be returned to these endpoints.     **Pull request checklist:**  - [x] This pull request targets the `main` branch, and the branch is named something other than `main`. - [x] I have written an appropriate pull request title and my description is clear. - [x] I understand I am responsible for the contents of this pull request. - I have followed the [contributing guidelines][c1]: - [x] My contribution follows the [code style][c2], if applicable. - [x] I ran [pre-commit checks][c1pc] before opening/drafting this pull request. - [x] I have [tested my contribution][c1t] (or proof-read it for documentation-only changes) myself, if applicable. This includes ensuring code compiles. - [x] My commit messages follow the [commit message format][c1cm] and are descriptive. - [x] I have written a [news fragment][n1] for this PR, if applicable.  [c1]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md [c2]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/docs/development/code_style.mdx [c1pc]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#pre-commit-checks [c1t]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#running-tests-locally [c1cm]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#commit-messages [n1]: https://towncrier.readthedocs.io/en/stable/tutorial.html#creating-news-fragments