fix: nix build and devshell on darwin #1628
Labels
No labels
Blocked
Bug
Changelog
Added
Changelog
Missing
Changelog
None
Cherry-picking
Database
Dependencies
Dependencies/Renovate
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/E2EE
Matrix/Federation
Matrix/Hydra
Matrix/MSC
Matrix/Media
Matrix/T&S
Merge
Merge/Manual
Merge/Squash
Meta
Meta/CI
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
Support
Wont fix
old/ci/cd
old/rust
No milestone
No project
No assignees
5 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
continuwuation/continuwuity!1628
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "Henry-Hiles/continuwuity:quad/fix/nix-darwin"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Co-authored-by: thetayloredman nutdriver716@gmail.com
This pull request fixes the nix devshell on Darwin systems by making jemalloc and liburing only added as an input on Linux, supersedes #1608. This PR also makes
nix buildwork to build a binary on darwin by skipping the patchelf step on Darwin, and fixing theplatformsmeta attribute.Pull request checklist:
mainbranch, and the branch is named something other thanmain.myself, if applicable. This includes ensuring code compiles.
Since I don't have a darwin/macos system, myself, I'd greatly appreciate if someone else is able to test this.
Otherwise, I can spin up a VM, but it would be nice for someone to test on regular macos.
To be honest, this can also be merged without testing, it doesn't affect Linux, and certainly makes MacOS closer to building than it would be otherwise, so it can be merged and further changes can be made later.
You've got a spurious newline in your co-authored-by
@Jade wrote in #1628 (comment):
oops :3
a2f9d36b8f810fe11faf@Jade wrote in #1628 (comment):
Fixed!
@Henry-Hiles naur
Darwin 25.3.0 arm64
nix (Nix) 2.31.3+1
@thetayloredman wrote in #1628 (comment):
Huh. Can you give me a log with
--show-trace?fix: devshell on darwinto WIP: fix: devshell on darwinNevermind, I found it
810fe11faf7ba0cf474eWIP: fix: devshell on darwinto fix: devshell on darwinFixed now?
Cargo test passes on linux.
Waiting for testing by LogN.
nix build gives me this error:
Just needs fixing at
platforms = lib.platforms.linux;I'll do it in a minute.
EDIT: Done.
fix: devshell on darwinto fix: nix stuff on darwinDevshell confirmed working on MacOS by LogN and Odd. Nix build is being tested.
Tested by Odd, nix builds works. Ready for merge.
fix: nix stuff on darwinto fix: nix build and devshell on darwin