continuwuation/continuwuity
continuwuation/continuwuity
16
91
Fork 105
Code Issues 127 Pull requests 27 Releases 30 Packages 3 Activity Actions 11

feat(nix): add release-high-perf and release-max-perf build to flake outputs #1659

Merged
Jade merged 2 commits from Aviac/continuwuity:nix-high-perf into main 2026-04-20 17:49:03 +00:00
Conversation 15 Commits 2 Files changed 2 +21 -1
Aviac commented 2026-04-14 06:24:27 +00:00
Member
Copy link

This pull request adds a new package output to the nix flake with a high performance profile build of continuwuity. This takes longer to build but is supposedly more performant as the name suggests.

Pull request checklist:

  • This pull request targets the main branch, and the branch is named something other than
    main.
  • I have written an appropriate pull request title and my description is clear.
  • I understand I am responsible for the contents of this pull request.
  • I have followed the contributing guidelines:
    • My contribution follows the code style, if applicable.
    • I ran pre-commit checks before opening/drafting this pull request.
    • I have tested my contribution (or proof-read it for documentation-only changes)
      myself, if applicable. This includes ensuring code compiles.
      - the nix package builds as expected
    • My commit messages follow the commit message format and are descriptive.
    • I have written a news fragment for this PR, if applicable.
<!-- In order to help reviewers know what your pull request does at a glance, you should ensure that 1. Your PR title is a short, single sentence describing what you changed 2. You have described in more detail what you have changed, why you have changed it, what the intended effect is, and why you think this will be beneficial to the project. If you have made any potentially strange/questionable design choices, but didn't feel they'd benefit from code comments, please don't mention them here - after opening your pull request, go to "files changed", and click on the "+" symbol in the line number gutter, and attach comments to the lines that you think would benefit from some clarification. --> This pull request adds a new package output to the nix flake with a high performance profile build of continuwuity. This takes longer to build but is supposedly more performant as the name suggests. <!-- Example: This pull request allows us to warp through time and space ten times faster than before by double-inverting the warp drive with hyperheated jump fluid, both making the drive faster and more efficient. This resolves the common issue where we have to wait more than 10 milliseconds to engage, use, and disengage the warp drive when travelling between galaxies. --> <!-- Closes: #... --> <!-- Fixes: #... --> <!-- Uncomment the above line(s) if your pull request fixes an issue or closes another pull request by superseding it. Replace `#...` with the issue/pr number, such as `#123`. --> **Pull request checklist:** <!-- You need to complete these before your PR can be considered. If you aren't sure about some, feel free to ask for clarification in #dev:continuwuity.org. --> - [x] This pull request targets the `main` branch, and the branch is named something other than `main`. - [x] I have written an appropriate pull request title and my description is clear. - [x] I understand I am responsible for the contents of this pull request. - I have followed the [contributing guidelines][c1]: - [x] My contribution follows the [code style][c2], if applicable. - [ ] I ran [pre-commit checks][c1pc] before opening/drafting this pull request. - [x] I have [tested my contribution][c1t] (or proof-read it for documentation-only changes) myself, if applicable. This includes ensuring code compiles. - the nix package builds as expected - [x] My commit messages follow the [commit message format][c1cm] and are descriptive. - [ ] I have written a [news fragment][n1] for this PR, if applicable<!--(can be done after hitting open!)-->. <!-- Notes on these requirements: - While not required, we encourage you to sign your commits with GPG or SSH to attest the authenticity of your changes. - While we allow LLM-assisted contributions, we do not appreciate contributions that are low quality, which is typical of machine-generated contributions that have not had a lot of love and care from a human. Please do not open a PR if all you have done is asked ChatGPT to tidy up the codebase with a +-100,000 diff. - In the case of code style violations, reviewers may leave review comments/change requests indicating what the ideal change would look like. For example, a reviewer may suggest you lower a log level, or use `match` instead of `if/else` etc. - In the case of code style violations, pre-commit check failures, minor things like typos/spelling errors, and in some cases commit format violations, reviewers may modify your branch directly, typically by making changes and adding a commit. Particularly in the latter case, a reviewer may rebase your commits to squash "spammy" ones (like "fix", "fix", "actually fix"), and reword commit messages that don't satisfy the format. - Pull requests MUST pass the `Checks` CI workflows to be capable of being merged. This can only be bypassed in exceptional circumstances. If your CI flakes, let us know in matrix:r/dev:continuwuity.org. - Pull requests have to be based on the latest `main` commit before being merged. If the main branch changes while you're making your changes, you should make sure you rebase on main before opening a PR. Your branch will be rebased on main before it is merged if it has fallen behind. - We typically only do fast-forward merges, so your entire commit log will be included. Once in main, it's difficult to get out cleanly, so put on your best dress, smile for the cameras! --> [c1]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md [c2]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/docs/development/code_style.mdx [c1pc]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#pre-commit-checks [c1t]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#running-tests-locally [c1cm]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#commit-messages [n1]: https://towncrier.readthedocs.io/en/stable/tutorial.html#creating-news-fragments
feat(nix): add release-high-perf build to flake outputs
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 9s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m51s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m34s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 8m1s
Details
c05a2abe03
Henry-Hiles commented 2026-04-14 13:49:03 +00:00
Member
Copy link

Other than slightly longer build times, is there a reason users wouldnt want to get this build over default?

Other than slightly longer build times, is there a reason users wouldnt want to get this build over default?
feat(nix): also add release-max-perf package build to flake outputs
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m16s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m43s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 13m30s
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 9s
Details
3aff19a7db
Aviac changed title from feat(nix): add release-high-perf build to flake outputs to feat(nix): add release-high-perf and release-max-perf build to flake outputs 2026-04-14 14:13:38 +00:00
Henry-Hiles commented 2026-04-14 20:55:10 +00:00
Member
Copy link

I'm tempted to just default to max-perf, and then only allow the others through an override.

I'm tempted to just default to max-perf, and then only allow the others through an override.
Henry-Hiles reviewed 2026-04-14 21:10:17 +00:00
nix/packages/continuwuity.nix Outdated
@ -35,6 +36,7 @@ let
env = {
ROCKSDB_INCLUDE_DIR = "${rocksdb}/include";
ROCKSDB_LIB_DIR = "${rocksdb}/lib";
CARGO_PROFILE = profile;
Henry-Hiles commented 2026-04-14 21:10:17 +00:00
Member
Copy link

Changes in this file are definitely good, should be added.

Changes in this file are definitely good, should be added.
Henry-Hiles reviewed 2026-04-14 21:10:55 +00:00
nix/packages/default.nix Outdated
@ -16,0 +20,4 @@
max-perf = pkgs.callPackage ./continuwuity.nix {
inherit self craneLib;
profile = "release-max-perf";
};
Henry-Hiles commented 2026-04-14 21:10:55 +00:00
Member
Copy link

What I'm not sure about is adding these. Maybe. I prefer to have one default and let people override, they can just continuwuity.override { profile = "release-max-perf"; } after all. Not certain if this should be done.

What I'm not sure about is adding these. Maybe. I prefer to have one default and let people `override`, they can just `continuwuity.override { profile = "release-max-perf"; }` after all. Not certain if this should be done.
Henry-Hiles commented 2026-04-14 21:12:03 +00:00
Member
Copy link

@Henry-Hiles wrote in #1659 (comment):

Other than slightly longer build times, is there a reason users wouldnt want to get this build over default?

Okay, based on feedback from Jade we won't make it default.

@Henry-Hiles wrote in https://forgejo.ellis.link/continuwuation/continuwuity/pulls/1659#issuecomment-28000: > Other than slightly longer build times, is there a reason users wouldnt want to get this build over default? Okay, based on feedback from Jade we won't make it default.
Henry-Hiles commented 2026-04-14 21:12:31 +00:00
Member
Copy link

The only thing to decide now is do we bother having other packages as presets with profile set, or do we just allow users to override?

The only thing to decide now is do we bother having other packages as presets with profile set, or do we just allow users to override?
Aviac commented 2026-04-19 16:53:27 +00:00
Author
Member
Copy link

@Henry-Hiles wrote in #1659 (comment):

The only thing to decide now is do we bother having other packages as presets with profile set, or do we just allow users to override?

tbh I'd say packages are better for discoverability. If I wouldn't do the PR and noone would tell me about the option, I wouldn't think about it. You have to both discover:

  • that the feature exists in the rust project
  • that the override exists to enable the feature in the nix package

I guess only a few people would get this far. On the other had, if we ever would remove or rename the package, some downstream users might have breakages but I think this is okish? I can only imagine that some self-updating systems might get stuck but that shouldn't take their service down. I would consider this a user (admin) error if your system is this fragile.

@Henry-Hiles wrote in https://forgejo.ellis.link/continuwuation/continuwuity/pulls/1659#issuecomment-28043: > The only thing to decide now is do we bother having other packages as presets with profile set, or do we just allow users to override? tbh I'd say packages are better for discoverability. If I wouldn't do the PR and noone would tell me about the option, I wouldn't think about it. You have to both discover: - that the feature exists in the rust project - that the override exists to enable the feature in the nix package I guess only a few people would get this far. On the other had, if we ever would remove or rename the package, some downstream users might have breakages but I think this is okish? I can only imagine that some self-updating systems might get stuck but that shouldn't take their service down. I would consider this a user (admin) error if your system is this fragile.
Henry-Hiles commented 2026-04-19 17:16:03 +00:00
Member
Copy link

@Aviac wrote in #1659 (comment):

@Henry-Hiles wrote in #1659 (comment):

The only thing to decide now is do we bother having other packages as presets with profile set, or do we just allow users to override?

tbh I'd say packages are better for discoverability. If I wouldn't do the PR and noone would tell me about the option, I wouldn't think about it. You have to both discover:

* that the feature exists in the rust project

* that the override exists to enable the feature in the nix package

I guess only a few people would get this far. On the other had, if we ever would remove or rename the package, some downstream users might have breakages but I think this is okish? I can only imagine that some self-updating systems might get stuck but that shouldn't take their service down. I would consider this a user (admin) error if your system is this fragile.

Okay, I agree. Last thing then, is there a big difference between high-perf and max-perf? Do we just want to provide one, and let users override if they want a different one?

@Aviac wrote in https://forgejo.ellis.link/continuwuation/continuwuity/pulls/1659#issuecomment-28280: > @Henry-Hiles wrote in #1659 (comment): > > > The only thing to decide now is do we bother having other packages as presets with profile set, or do we just allow users to override? > > tbh I'd say packages are better for discoverability. If I wouldn't do the PR and noone would tell me about the option, I wouldn't think about it. You have to both discover: > > * that the feature exists in the rust project > > * that the override exists to enable the feature in the nix package > > > I guess only a few people would get this far. On the other had, if we ever would remove or rename the package, some downstream users might have breakages but I think this is okish? I can only imagine that some self-updating systems might get stuck but that shouldn't take their service down. I would consider this a user (admin) error if your system is this fragile. Okay, I agree. Last thing then, is there a big difference between high-perf and max-perf? Do we just want to provide one, and let users override if they want a different one?
Aviac commented 2026-04-20 06:14:05 +00:00
Author
Member
Copy link

Okay, I agree. Last thing then, is there a big difference between high-perf and max-perf? Do we just want to provide one, and let users override if they want a different one?

Yeah I think max-perf might be enough. I'll add a comment to let users know they might choose different options anyhow

> Okay, I agree. Last thing then, is there a big difference between high-perf and max-perf? Do we just want to provide one, and let users override if they want a different one? Yeah I think max-perf might be enough. I'll add a comment to let users know they might choose different options anyhow
Aviac force-pushed nix-high-perf from 3aff19a7db
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m16s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m43s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 13m30s
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 9s
Details
to dc241fada1
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 36s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m19s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m49s
Details
Deploy Element Web / 🏗️ Build and Deploy (pull_request) Failing after 7m31s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 9m59s
Details
2026-04-20 06:25:25 +00:00 Compare
Aviac force-pushed nix-high-perf from dc241fada1
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 36s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m19s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m49s
Details
Deploy Element Web / 🏗️ Build and Deploy (pull_request) Failing after 7m31s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 9m59s
Details
to ec7b56a54e
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 34s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m16s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m51s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 8m0s
Details
Deploy Element Web / 🏗️ Build and Deploy (pull_request) Failing after 8m16s
Details
2026-04-20 07:23:36 +00:00 Compare
Aviac force-pushed nix-high-perf from ec7b56a54e
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 34s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m16s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m51s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 8m0s
Details
Deploy Element Web / 🏗️ Build and Deploy (pull_request) Failing after 8m16s
Details
to 19d24e1fb2
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 34s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m19s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m45s
Details
Deploy Element Web / 🏗️ Build and Deploy (pull_request) Failing after 7m44s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 8m54s
Details
2026-04-20 07:38:22 +00:00 Compare
Henry-Hiles approved these changes 2026-04-20 12:58:39 +00:00
Dismissed
Henry-Hiles left a comment
Copy link

LGTM!

LGTM!
Henry-Hiles commented 2026-04-20 13:00:46 +00:00
Member
Copy link

The last thing would be putting this in docs, but I can do that myself.

The last thing would be putting this in docs, but I can do that myself.
Henry-Hiles commented 2026-04-20 13:01:39 +00:00
Member
Copy link

Oh, if you are enabling h3, can you just do it in the default build? Jade approved me doing that.

Oh, if you are enabling h3, can you just do it in the default build? Jade approved me doing that.
Aviac force-pushed nix-high-perf from 44990d0592
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 35s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m20s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m47s
Details
Deploy Element Web / 🏗️ Build and Deploy (pull_request) Failing after 7m38s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 9m3s
Details
to 7081d26f86
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 8s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m17s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m47s
Details
Deploy Element Web / 🏗️ Build and Deploy (pull_request) Has been cancelled
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled
Details
2026-04-20 13:15:00 +00:00 Compare
Henry-Hiles requested changes 2026-04-20 13:18:13 +00:00
Dismissed
nix/packages/default.nix Outdated
@ -16,0 +28,4 @@
# - release-high-perf
max-perf = self'.packages.default.override {
profile = "release-max-perf";
cargoExtraArgs = "-F http3";
Henry-Hiles commented 2026-04-20 13:18:11 +00:00
Member
Copy link

you dont need this again :)

you dont need this again :)
Aviac force-pushed nix-high-perf from 7081d26f86
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 8s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m17s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m47s
Details
Deploy Element Web / 🏗️ Build and Deploy (pull_request) Has been cancelled
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled
Details
to c195f6dddc
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 8s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m18s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m47s
Details
Deploy Element Web / 🏗️ Build and Deploy (pull_request) Failing after 7m37s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 8m37s
Details
2026-04-20 13:22:19 +00:00 Compare
Henry-Hiles approved these changes 2026-04-20 13:24:27 +00:00
Henry-Hiles left a comment
Copy link

IMO the comments should be removed and added to docs, but I can do that myself in a separate PR.

IMO the comments should be removed and added to docs, but I can do that myself in a separate PR.
👍 1
Jade approved these changes 2026-04-20 17:48:55 +00:00
Jade merged commit 027f6a4b02 into main 2026-04-20 17:49:03 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Henry-Hiles
Jade
Labels
Clear labels   
Blocked
This pull request or issue is currently blocked from being merged/closed

  
Bug
Something isn't working as intended

  
Changelog
Added
 Changelog entry added

  
Changelog
Missing
 No changelog when one is needed

  
Changelog
None
 Changelog is unnecesary for this change

  
Cherry-picking
Commits picked from other conduit projects

  
Database
This requires or includes changes to the database

  
Dependencies
Something dependency related

  
Dependencies/Renovate
Automatic dependency upgrades by Renovate

  
Difficulty
Easy
 Low difficulty to implement - touches few parts of the codebase, low complexity

  
Difficulty
Hard
 High difficulty to implement - touches many parts of the codebase, high complexity

  
Difficulty
Medium
 Medium difficulty to implement - touches more parts of the codebase, higher complexity

  
Documentation
Improvements or additions to documentation

  
Enhancement
New feature or request

  
Good first issue
Good for newcomers

  
Help wanted
Additional eyes and keyboards are required for this one

  
Inherited
Issues that have been inhereted from the project pre-fork

  
Matrix/Administration
Features pertaining to homeserver administration

  
Matrix/Appservices
Features pertaining to the appservice API

  
Matrix/Auth
Features pertaining to authentication

  
Matrix/Client
Features pertaining to client-to-server interactions

  
Matrix/Core
Issues relating to core matrix functionality, such as state resolution and PDU formats

  
Matrix/E2EE
Issues related to end to end encryption

  
Matrix/Federation
Features pertaining to server-to-server interactions

  
Matrix/Hydra
Issues related to room version 12 and related changes (temporary label)

  
Matrix/MSC
Features pertaining to unstable matrix features

  
Matrix/Media
Features pertaining to media interactions

  
Matrix/T&S
Changes or issues related to trust & safety tooling

  
Merge
This PR is ready to be merged

  
Merge/Manual
This PR should be manually merged

  
Merge/Squash
This PR should be squashed when it is merged

  
Meta
Related to housekeeping, maintenance, or other repo-meta.

  
Meta/CI
Issues related to CI changes

  
Meta/Packaging
Packaging

  
Priority
Blocking
 This issue is blocking the next release

  
Priority
High
 This issue is very important

  
Priority
Low
 This issue is of a rather low priority

  
Security
This item is related to general security

  
Status
Confirmed
 This issue has enough information and is confirmed

  
Status
Duplicate
 This issue or pull request already exists

  
Status
Invalid
 This issue doesn't seem right

  
Status
Needs Investigation
 This issue needs further investigation

  
Support
Questions or support requests

  
Wont fix
This will not be worked on

  
old/ci/cd
Ci/CD

Archived

  
old/rust
Pull requests that update Rust code

Archived

No labels
Blocked
Bug
Changelog
Added
Changelog
Missing
Changelog
None
Cherry-picking
Database
Dependencies
Dependencies/Renovate
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/E2EE
Matrix/Federation
Matrix/Hydra
Matrix/MSC
Matrix/Media
Matrix/T&S
Merge
Merge/Manual
Merge/Squash
Meta
Meta/CI
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
Support
Wont fix
old/ci/cd
old/rust
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
continuwuation/continuwuity!1659
No description provided.