CI: Remove the broken clang installation step #1855

Merged
Jade merged 1 commit from spaetz/continuwuity:spaetz-patch-1 into main 2026-06-19 11:23:53 +00:00
Member

tomfos.tr act-runner images removed the possibility on Feb 19, 2026 to install the latest LLVM using an installer script in git.tomfos.tr/tom/act-runner@01782867ce.
I built the Debian/Ubuntu CI with the distribution repository clang, and both Debian and Ubuntu latest built fine, so let us also remove the detection and just live with the distro's clang package.
Debian Trixie has clang 1.19 and Ubuntu resolute has Clang 1.21.

If this ever becomes a problem and we need a different version we would need to reintroduce
this step but install clang directly using the LLVM deb repo (https://apt.llvm.org/#ubuntu), installing the clang version that we actually need. Or we would have to reintroduce the installation via the installation scripts that Tom has cut out of their runner image.

This pull request would fix the broken build-Debian CI run (ubuntu-latest is broken as there is no clang-23 package available) and I am not sure that we actually need clang 23(?!)

Pull request checklist:

  • This pull request targets the main branch, and the branch is named something other than
    main.
  • I have written an appropriate pull request title and my description is clear.
  • I understand I am responsible for the contents of this pull request.
  • I have followed the contributing guidelines:
tomfos.tr act-runner images removed the possibility on Feb 19, 2026 to install the latest LLVM using an installer script in https://git.tomfos.tr/tom/act-runner/commit/01782867ce50c4d81302f27b8bbe9a7a48e46581. I built the Debian/Ubuntu CI with the distribution repository clang, and both Debian and Ubuntu latest built fine, so let us also remove the detection and just live with the distro's clang package. Debian Trixie has clang 1.19 and Ubuntu resolute has Clang 1.21. If this ever becomes a problem and we need a different version we would need to reintroduce this step but install clang directly using the LLVM deb repo (https://apt.llvm.org/#ubuntu), installing the clang version that we actually need. Or we would have to reintroduce the installation via the installation scripts that Tom has cut out of their runner image. This pull request would fix the broken build-Debian CI run (ubuntu-latest is broken as there is no clang-23 package available) and I am not sure that we actually need clang 23(?!) <!-- In order to help reviewers know what your pull request does at a glance, you should ensure that 1. Your PR title is a short, single sentence describing what you changed 2. You have described in more detail what you have changed, why you have changed it, what the intended effect is, and why you think this will be beneficial to the project. --> **Pull request checklist:** <!-- You need to complete these before your PR can be considered. If you aren't sure about some, feel free to ask for clarification in #dev:continuwuity.org. --> - [X] This pull request targets the `main` branch, and the branch is named something other than `main`. - [X] I have written an appropriate pull request title and my description is clear. - [X] I understand I am responsible for the contents of this pull request. - I have followed the [contributing guidelines][c1]: - [X] My contribution follows the [code style][c2], if applicable. - [X] I ran [pre-commit checks][c1pc] before opening/drafting this pull request. - [X] I have [tested my contribution][c1t] (or proof-read it for documentation-only changes) myself, if applicable. This includes ensuring code compiles. - [X] My commit messages follow the [commit message format][c1cm] and are descriptive. <!-- Notes on these requirements: - While not required, we encourage you to sign your commits with GPG or SSH to attest the authenticity of your changes. - While we allow LLM-assisted contributions, we do not appreciate contributions that are low quality, which is typical of machine-generated contributions that have not had a lot of love and care from a human. Please do not open a PR if all you have done is asked ChatGPT to tidy up the codebase with a +-100,000 diff. - In the case of code style violations, reviewers may leave review comments/change requests indicating what the ideal change would look like. For example, a reviewer may suggest you lower a log level, or use `match` instead of `if/else` etc. - In the case of code style violations, pre-commit check failures, minor things like typos/spelling errors, and in some cases commit format violations, reviewers may modify your branch directly, typically by making changes and adding a commit. Particularly in the latter case, a reviewer may rebase your commits to squash "spammy" ones (like "fix", "fix", "actually fix"), and reword commit messages that don't satisfy the format. - Pull requests MUST pass the `Checks` CI workflows to be capable of being merged. This can only be bypassed in exceptional circumstances. If your CI flakes, let us know in matrix:r/dev:continuwuity.org. - Pull requests have to be based on the latest `main` commit before being merged. If the main branch changes while you're making your changes, you should make sure you rebase on main before opening a PR. Your branch will be rebased on main before it is merged if it has fallen behind. - We typically only do fast-forward merges, so your entire commit log will be included. Once in main, it's difficult to get out cleanly, so put on your best dress, smile for the cameras! --> [c1]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md [c2]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/docs/development/code_style.mdx [c1pc]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#pre-commit-checks [c1t]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#running-tests-locally [c1cm]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#commit-messages
CI: Remove the clang detection
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Auto Labeler / Apply labels based on changed files (pull_request_target) Successful in 2s
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 7s
Checks / Prek / Check changed files (pull_request) Successful in 6s
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been skipped
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m9s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m22s
f265c836fa
tomfos.tr act-runner image removed the possibility to install the latest LLVM using an installer script, so let us also remove the detection and just live with the distro's clang image.
Jade merged commit 252ebb4642 into main 2026-06-19 11:23:53 +00:00
Jade deleted branch spaetz-patch-1 2026-06-19 11:23:54 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
continuwuation/continuwuity!1855
No description provided.