ci: Remove Fedora packaging workflow #1924

Merged
ginger merged 1 commit from julian45/continuwuity:julian/nuke-cicd-fedora into main 2026-07-09 18:40:56 +00:00
Member

This pull request removes the Fedora packaging and publishing workflow from CI. Said workflow is no longer required, as Terra now distributes both stable-release and nightly packages, including for EL-family distros as well.
(I just fixed an issue with the continuwuity-nightly update process in Terra this morning, so I'll keep this PR in WIP until I confirm after a nightly run that new nightlies are in fact being built & distributed. Later edit: Terra stuff has been sorted out :3)

The intent is for this PR to be merged prior to the next stable release. This will require drawing some attention in the release notes, but it forces RPM deployers to make the change in order to update.
Other options discussed but dismissed included:

  • "Copying" the latest release from Terra's repo to ours (straight RPM copying would generate errors for deployers due to RPM signing key mismatches; rebuilding from the SRPM in our CI would require significant futzing with this workflow to install Terra-specific build toolchain and RPM macros that aren't worth the trouble)
  • Letting this workflow stick around until after the next release (doesn't generate sufficient justification to make the upgrade)

Pull request checklist:

  • This pull request targets the main branch, and the branch is named something other than
    main.
  • I have written an appropriate pull request title and my description is clear.
  • I understand I am responsible for the contents of this pull request.
  • I have followed the contributing guidelines:
<!-- In order to help reviewers know what your pull request does at a glance, you should ensure that 1. Your PR title is a short, single sentence describing what you changed 2. You have described in more detail what you have changed, why you have changed it, what the intended effect is, and why you think this will be beneficial to the project. If you have made any potentially strange/questionable design choices, but didn't feel they'd benefit from code comments, please don't mention them here - after opening your pull request, go to "files changed", and click on the "+" symbol in the line number gutter, and attach comments to the lines that you think would benefit from some clarification. --> This pull request removes the Fedora packaging and publishing workflow from CI. Said workflow is no longer required, as Terra now distributes both stable-release and nightly packages, including for EL-family distros as well. (~~I just fixed an issue with the continuwuity-nightly update process in Terra this morning, so I'll keep this PR in WIP until I confirm after a nightly run that new nightlies are in fact being built & distributed.~~ Later edit: Terra stuff has been sorted out :3) **The intent is for this PR to be merged *prior* to the next stable release.** This will require drawing some attention in the release notes, but it forces RPM deployers to make the change in order to update. Other options [discussed](matrix:roomid/ksTlboXVgcyWjv5GrlEeKyQuJ8ZCprnwQx2b6-BQ44Q/e/491vMyoJILkhFka6fwPkT01x873sBTQ4YIbPjFrzDzw?via=julian45.net&via=explodie.org&via=federated.nexus) but dismissed included: - "Copying" the latest release from Terra's repo to ours (straight RPM copying would generate errors for deployers due to RPM signing key mismatches; rebuilding from the SRPM in our CI would require significant futzing with this workflow to install Terra-specific build toolchain and RPM macros that aren't worth the trouble) - Letting this workflow stick around until after the next release (doesn't generate sufficient justification to make the upgrade) <!-- Example: This pull request allows us to warp through time and space ten times faster than before by double-inverting the warp drive with hyperheated jump fluid, both making the drive faster and more efficient. This resolves the common issue where we have to wait more than 10 milliseconds to engage, use, and disengage the warp drive when travelling between galaxies. --> <!-- Closes: #... --> <!-- Fixes: #... --> <!-- Uncomment the above line(s) if your pull request fixes an issue or closes another pull request by superseding it. Replace `#...` with the issue/pr number, such as `#123`. --> **Pull request checklist:** <!-- You need to complete these before your PR can be considered. If you aren't sure about some, feel free to ask for clarification in #dev:continuwuity.org. --> - [x] This pull request targets the `main` branch, and the branch is named something other than `main`. - [x] I have written an appropriate pull request title and my description is clear. - [x] I understand I am responsible for the contents of this pull request. - I have followed the [contributing guidelines][c1]: - [x] My contribution follows the [code style][c2], if applicable. - [x] I ran [pre-commit checks][c1pc] before opening/drafting this pull request. - [x] I have [tested my contribution][c1t] (or proof-read it for documentation-only changes) myself, if applicable. This includes ensuring code compiles. - [x] My commit messages follow the [commit message format][c1cm] and are descriptive. <!-- Notes on these requirements: - While not required, we encourage you to sign your commits with GPG or SSH to attest the authenticity of your changes. - While we allow LLM-assisted contributions, we do not appreciate contributions that are low quality, which is typical of machine-generated contributions that have not had a lot of love and care from a human. Please do not open a PR if all you have done is asked ChatGPT to tidy up the codebase with a +-100,000 diff. - In the case of code style violations, reviewers may leave review comments/change requests indicating what the ideal change would look like. For example, a reviewer may suggest you lower a log level, or use `match` instead of `if/else` etc. - In the case of code style violations, pre-commit check failures, minor things like typos/spelling errors, and in some cases commit format violations, reviewers may modify your branch directly, typically by making changes and adding a commit. Particularly in the latter case, a reviewer may rebase your commits to squash "spammy" ones (like "fix", "fix", "actually fix"), and reword commit messages that don't satisfy the format. - Pull requests MUST pass the `Checks` CI workflows to be capable of being merged. This can only be bypassed in exceptional circumstances. If your CI flakes, let us know in matrix:r/dev:continuwuity.org. - Pull requests have to be based on the latest `main` commit before being merged. If the main branch changes while you're making your changes, you should make sure you rebase on main before opening a PR. Your branch will be rebased on main before it is merged if it has fallen behind. - We typically only do fast-forward merges, so your entire commit log will be included. Once in main, it's difficult to get out cleanly, so put on your best dress, smile for the cameras! --> [c1]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md [c2]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/docs/development/code_style.mdx [c1pc]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#pre-commit-checks [c1t]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#running-tests-locally [c1cm]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#commit-messages
ci: Remove Fedora packaging workflow
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Auto Labeler / Apply labels based on changed files (pull_request_target) Successful in 4s
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 6s
Checks / Prek / Check changed files (pull_request) Successful in 6s
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been skipped
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 51s
065914a0fe
No longer needed because Terra now distributes both stable and nightly
releases for Fedora- & EL-family distributions.
Contributor

This should get its own changelog.d

This should get its own changelog.d
Author
Member

@stratself wrote in #1924 (comment):

This should get its own changelog.d

Should it, though? By our contributing guide and CI checks, removal of a CI workflow alone doesn’t inherently warrant a changelog.d entry. I did say when opening the PR (and also in the dev room too) that attention would need to be drawn in the release notes to make sure prior users of these packages make the switch to Terra, but that can be done in the freeform part above changelog entries.
That said, if it is decided that it warrants a changelog entry, I suppose that out of the types enumerated in the contributing guide, it’d be misc?

@stratself wrote in https://forgejo.ellis.link/continuwuation/continuwuity/pulls/1924#issuecomment-31436: > This should get its own changelog.d Should it, though? By our contributing guide and CI checks, removal of a CI workflow alone doesn’t inherently warrant a changelog.d entry. I *did* say when opening the PR (and also in the dev room too) that attention would need to be drawn in the release notes to make sure prior users of these packages make the switch to Terra, but that can be done in the freeform part above changelog entries. That said, if it *is* decided that it warrants a changelog entry, I suppose that out of the types enumerated in the contributing guide, it’d be `misc`?
Contributor

I agree the freeform could be used, but it could miss out on some entries. Having inline report of significant removals would make it more complete, and allow for contribs to explain the breaking effect of their changes too. This is also inline with other projects like Codeberg changelogs

If it were me I'd likely do it as such:

ci: Remove Fedora packages. **Breaking**: Fedora packages will mot be provided on the forge - use Terra instead. Contributed by @julian45

Maintainers have final discretion tho

I agree the freeform could be used, but it could miss out on some entries. Having inline report of significant removals would make it more complete, and allow for contribs to explain the breaking effect of their changes too. This is also inline with other projects like [Codeberg changelogs](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/release-notes-published/15.0.0.md) If it were me I'd likely do it as such: ``` ci: Remove Fedora packages. **Breaking**: Fedora packages will mot be provided on the forge - use Terra instead. Contributed by @julian45 ``` Maintainers have final discretion tho
ginger changed title from WIP: ci: Remove Fedora packaging workflow to ci: Remove Fedora packaging workflow 2026-07-09 18:12:25 +00:00
ginger added this to the 26.6.0 milestone 2026-07-09 18:12:29 +00:00
ginger changed title from ci: Remove Fedora packaging workflow to WIP: ci: Remove Fedora packaging workflow 2026-07-09 18:15:19 +00:00
julian45 changed title from WIP: ci: Remove Fedora packaging workflow to ci: Remove Fedora packaging workflow 2026-07-09 18:40:09 +00:00
ginger approved these changes 2026-07-09 18:40:37 +00:00
julian45 force-pushed julian/nuke-cicd-fedora from 065914a0fe
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Auto Labeler / Apply labels based on changed files (pull_request_target) Successful in 4s
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 6s
Checks / Prek / Check changed files (pull_request) Successful in 6s
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been skipped
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 51s
to 3ad229a2bc
Some checks failed
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 7s
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Checks / Prek / Check changed files (pull_request) Successful in 6s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m4s
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m26s
Documentation / Build and Deploy Documentation (push) Successful in 1m15s
Checks / Prek / Check changed files (push) Successful in 7s
Release Docker Image / Build linux-amd64 (release) (push) Failing after 38s
Release Docker Image / Build linux-arm64 (release) (push) Failing after 30s
Release Docker Image / Create Multi-arch Release Manifest (push) Has been skipped
Release Docker Image / Build linux-amd64 (max-perf) (push) Has been skipped
Release Docker Image / Build linux-arm64 (max-perf) (push) Has been skipped
Release Docker Image / Create Max-Perf Manifest (push) Has been skipped
Release Docker Image / Mirror Images (push) Has been skipped
Checks / Prek / Pre-commit & Formatting (push) Successful in 2m8s
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been skipped
Checks / Prek / Clippy and Cargo Tests (push) Has been skipped
Release Docker Image / Release Binaries (push) Has been skipped
2026-07-09 18:40:44 +00:00
Compare
ginger merged commit 3ad229a2bc into main 2026-07-09 18:40:56 +00:00
julian45 deleted branch julian/nuke-cicd-fedora 2026-07-09 18:47:03 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
continuwuation/continuwuity!1924
No description provided.