feat: Enable direct_tls and more logging by default #1933

Merged
Jade merged 1 commit from jade/default-features into main 2026-07-09 21:46:38 +00:00
Owner

Disables additional logging on maxprf builds

(direct_tls is for complement, so it works on default builds)

Disables additional logging on maxprf builds (direct_tls is for complement, so it works on default builds)
feat: Enable direct_tls and more logging by default
Some checks failed
Auto Labeler / Apply labels based on changed files (pull_request_target) Successful in 5s
Checks / Changelog / Check changelog is added (pull_request_target) Failing after 6s
Documentation / Build and Deploy Documentation (pull_request) Successful in 1m13s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 58s
Checks / Prek / Check changed files (pull_request) Successful in 6s
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled
980e4c378c
Disables additional logging on maxprf builds
@ -42,12 +42,12 @@ assets = [
[features]
default = [
"standard",
"release_max_log_level",
Member

I believe this means that all nix builds will have this off, is that expected?

I believe this means that all nix builds will have this off, is that expected?
Author
Owner

Uh it's basically a minor performance optimisation at the expense of debugability, i could probably add it to maxperf one sec

Uh it's basically a minor performance optimisation at the expense of debugability, i could probably add it to maxperf one sec
Member

Hmm maybe I misunderstand, wouldn't you NOT want to enable release_max_log_level on maxperf, and instead only enable it on regular release?

Hmm maybe I misunderstand, wouldn't you NOT want to enable `release_max_log_level` on maxperf, and instead only enable it on regular release?
Author
Owner

Other way around

Other way around
Jade force-pushed jade/default-features from 980e4c378c
Some checks failed
Auto Labeler / Apply labels based on changed files (pull_request_target) Successful in 5s
Checks / Changelog / Check changelog is added (pull_request_target) Failing after 6s
Documentation / Build and Deploy Documentation (pull_request) Successful in 1m13s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 58s
Checks / Prek / Check changed files (pull_request) Successful in 6s
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled
to d567e816fa
Some checks failed
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 5s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 56s
Documentation / Build and Deploy Documentation (pull_request) Successful in 1m16s
Checks / Prek / Check changed files (pull_request) Successful in 6s
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m24s
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled
2026-07-09 21:38:24 +00:00
Compare
Jade force-pushed jade/default-features from d567e816fa
Some checks failed
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 5s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 56s
Documentation / Build and Deploy Documentation (pull_request) Successful in 1m16s
Checks / Prek / Check changed files (pull_request) Successful in 6s
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m24s
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled
to 5d2e840859
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 1m14s
Checks / Prek / Check changed files (pull_request) Successful in 6s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 59s
Documentation / Build and Deploy Documentation (push) Successful in 1m14s
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m26s
Checks / Prek / Check changed files (push) Successful in 5s
Release Docker Image / Build linux-amd64 (release) (push) Failing after 33s
Checks / Prek / Pre-commit & Formatting (push) Successful in 55s
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 6s
Release Docker Image / Build linux-arm64 (release) (push) Failing after 30s
Release Docker Image / Create Multi-arch Release Manifest (push) Has been skipped
Release Docker Image / Build linux-amd64 (max-perf) (push) Has been skipped
Release Docker Image / Build linux-arm64 (max-perf) (push) Has been skipped
Release Docker Image / Create Max-Perf Manifest (push) Has been skipped
Release Docker Image / Mirror Images (push) Has been skipped
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 9m16s
Checks / Prek / Clippy and Cargo Tests (push) Successful in 9m39s
Release Docker Image / Release Binaries (push) Has been skipped
2026-07-09 21:44:31 +00:00
Compare
ginger approved these changes 2026-07-09 21:44:59 +00:00
ginger left a comment

remarkable that this requires four changed files

remarkable that this requires four changed files
Jade merged commit 5d2e840859 into main 2026-07-09 21:46:38 +00:00
Jade deleted branch jade/default-features 2026-07-09 21:46:38 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
continuwuation/continuwuity!1933
No description provided.