feat: Move client IP log into router #1973

Merged

nex merged 2 commits from nex/feat/global-ip-span into main

2026-07-17 12:57:49 +00:00

nex commented

2026-07-12 16:32:25 +00:00

Owner

This pull request moves the connecting IP log field out of individual routes and instead attaches it globally to the router, resulting in logs like

2026-07-12T14:41:23.948139Z TRACE router{method=GET path=/_matrix/client/v3/sync ip="127.0.0.1"}:sync{since=349}: conduwuit_service::sync: Waking user's sync loops user="@alice:alice.localhost:18448"

which means the connecting IP is always visible in logs.

Pull request checklist:

This pull request targets the main branch, and the branch is named something other than
main.
I have written an appropriate pull request title and my description is clear.
I understand I am responsible for the contents of this pull request.
I have followed the contributing guidelines:
- My contribution follows the code style, if applicable.
- I ran pre-commit checks before opening/drafting this pull request.
- I have tested my contribution (or proof-read it for documentation-only changes)
  myself, if applicable. This includes ensuring code compiles.
- My commit messages follow the commit message format and are descriptive.

This pull request moves the connecting IP log field out of individual routes and instead attaches it globally to the router, resulting in logs like ``` 2026-07-12T14:41:23.948139Z TRACE router{method=GET path=/_matrix/client/v3/sync ip="127.0.0.1"}:sync{since=349}: conduwuit_service::sync: Waking user's sync loops user="@alice:alice.localhost:18448" ``` which means the connecting IP is always visible in logs. **Pull request checklist:**  - [x] This pull request targets the `main` branch, and the branch is named something other than `main`. - [x] I have written an appropriate pull request title and my description is clear. - [x] I understand I am responsible for the contents of this pull request. - I have followed the [contributing guidelines][c1]: - [x] My contribution follows the [code style][c2], if applicable. - [x] I ran [pre-commit checks][c1pc] before opening/drafting this pull request. - [x] I have [tested my contribution][c1t] (or proof-read it for documentation-only changes) myself, if applicable. This includes ensuring code compiles. - [x] My commit messages follow the [commit message format][c1cm] and are descriptive.  [c1]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md [c2]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/docs/development/code_style.mdx [c1pc]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#pre-commit-checks [c1t]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#running-tests-locally [c1cm]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#commit-messages

Rows
Columns