continuwuation/continuwuity
continuwuation/continuwuity
15
108
Fork 116
Code Issues 125 Pull requests 24 Releases 35 Packages 3 Activity Actions 2

feat: Allow multiple options in request_ip_source #1985

Open
Omar007 wants to merge 2 commits from Omar007/continuwuity:feature/ip-src-fallback into main
pull from: Omar007/continuwuity:feature/ip-src-fallback
merge into: continuwuation:main
Conversation 8 Commits 2 Files changed 34 +132 -93

2 commits

Author SHA1 Message Date
Omar Pakker
a12805e0c9 chore: Add towncrier news fragment
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 6s
Details
Checks / Prek / Check changed files (pull_request) Successful in 4s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 58s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m12s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 11m8s
Details
2026-07-14 20:28:57 +02:00
Omar Pakker
ec8947f5d3 feat: Allow multiple options in request_ip_source 
Only allowing a single option prevents results in requests being denied if
the singular selected source option isn't used for every single request flow.
This means you need to choose between selecting the right IP or properly
separating your infrastructure traffic. You can't have both;
running edge traffic through a reverse proxy with proper IP resolution,
as well as appservices isolated internally is not possible at the same time.

By allowing multiple options to be set, this limitation is resolved and
it becomes possible to have client IP resolution behind reverse proxies,
as well as allow for direct internal connections for appservices.

Options are evaluated in order. If all fail, the request still fails.
 2026-07-14 20:28:53 +02:00