fix(sync): Stop waking sync loops when removing to-device events #2007

Merged

Aranjedeath merged 1 commit from eleboucher/continuwuity:fix/sync-todevice-wake-loop into main

2026-07-16 21:55:57 +00:00

eleboucher commented

2026-07-16 20:18:34 +00:00

Contributor

The /sync waker is keyed per-user, not per-device. Every build_sync_events ends by calling remove_to_device_events, which called sync.wake(user_id) unconditionally. With two devices, each device's sync wakes the other's parked long-poll, which rebuilds and wakes back .

Reporter's diagnostics confirmed it: ~3,400 /sync requests over 242s (~14/sec) and CPU going from 0.003 to 0.825 cores.

Fixes: #2006

Pull request checklist:

This pull request targets the main branch, and the branch is named something other than
main.
I have written an appropriate pull request title and my description is clear.
I understand I am responsible for the contents of this pull request.
I have followed the contributing guidelines:
- My contribution follows the code style, if applicable.
- I ran pre-commit checks before opening/drafting this pull request.
- I have tested my contribution (or proof-read it for documentation-only changes)
  myself, if applicable. This includes ensuring code compiles.
- My commit messages follow the commit message format and are descriptive.

The /sync waker is keyed per-user, not per-device. Every build_sync_events ends by calling remove_to_device_events, which called sync.wake(user_id) unconditionally. With two devices, each device's sync wakes the other's parked long-poll, which rebuilds and wakes back . Reporter's diagnostics confirmed it: ~3,400 /sync requests over 242s (~14/sec) and CPU going from 0.003 to 0.825 cores.  Fixes: #2006    **Pull request checklist:**  - [x] This pull request targets the `main` branch, and the branch is named something other than `main`. - [x] I have written an appropriate pull request title and my description is clear. - [x] I understand I am responsible for the contents of this pull request. - I have followed the [contributing guidelines][c1]: - [x] My contribution follows the [code style][c2], if applicable. - [x] I ran [pre-commit checks][c1pc] before opening/drafting this pull request. - [x] I have [tested my contribution][c1t] (or proof-read it for documentation-only changes) myself, if applicable. This includes ensuring code compiles. - [x] My commit messages follow the [commit message format][c1cm] and are descriptive.  [c1]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md [c2]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/docs/development/code_style.mdx [c1pc]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#pre-commit-checks [c1t]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#running-tests-locally [c1cm]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#commit-messages

eleboucher added 1 commit

2026-07-16 20:18:34 +00:00

fix(sync): Stop waking sync loops when removing to-device events

Auto Labeler / Apply labels based on changed files (pull_request_target) Successful in 2s

Details

Documentation / Build and Deploy Documentation (pull_request) Has been skipped

Details

Checks / Changelog / Check changelog is added (pull_request_target) Successful in 6s

Details

Checks / Prek / Check changed files (pull_request) Successful in 5s

Details

Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m28s