continuwuation/continuwuity
continuwuation/continuwuity
14
110
Fork 118
Code Issues 132 Pull requests 19 Releases 36 Packages 3 Activity Actions

feat: implement optional support for MSC4495 (Selective Presence) #2034

Open
thetayloredman wants to merge 11 commits from thetayloredman/continuwuity:presence-v2/msc4495 into main
pull from: thetayloredman/continuwuity:presence-v2/msc4495
merge into: continuwuation:main
Conversation 3 Commits 11 Files changed 26 +757 -133
thetayloredman commented 2026-07-22 20:46:33 +00:00
Contributor
Copy link

This pull request adds experimental support for inbound and outbound MSC4495: Selective Presence (rendered; a component of Presence v2).

This PR is reviewable on a commit-by-commit basis (and I recommend doing so).

Selective Presence allows users to control the recipients of their presence for the sake of substantial performance and privacy improvements.

Currently, this feature is optional as no client has support yet.

Blocked on the following:

Pull request checklist:

  • This pull request targets the main branch, and the branch is named something other than
    main.
  • I have written an appropriate pull request title and my description is clear.
  • I understand I am responsible for the contents of this pull request.
  • I have followed the contributing guidelines:
This pull request adds experimental support for inbound and outbound [MSC4495: Selective Presence](https://github.com/matrix-org/matrix-spec-proposals/pull/4495) ([rendered](https://github.com/thetayloredman/matrix-spec-proposals/blob/presence-v2/selective/proposals/4495-selective-presence.md); a component of [Presence v2](https://ispresencefixedyet.com)). This PR is reviewable on a commit-by-commit basis (and I recommend doing so). Selective Presence allows users to control the recipients of their presence for the sake of substantial performance and privacy improvements. Currently, this feature is optional as no client has support yet. **Blocked on the following:** * [x] PR to Ruma upstream: https://github.com/ruma/ruma/pull/2546 * [x] Ruma `3ad0471` making it into main: #2049 **Pull request checklist:** <!-- You need to complete these before your PR can be considered. If you aren't sure about some, feel free to ask for clarification in #dev:continuwuity.org. --> - [x] This pull request targets the `main` branch, and the branch is named something other than `main`. - [x] I have written an appropriate pull request title and my description is clear. - [x] I understand I am responsible for the contents of this pull request. - I have followed the [contributing guidelines][c1]: - [x] My contribution follows the [code style][c2], if applicable. - [x] I ran [pre-commit checks][c1pc] before opening/drafting this pull request. - [x] I have [tested my contribution][c1t] (or proof-read it for documentation-only changes) myself, if applicable. This includes ensuring code compiles. - [x] My commit messages follow the [commit message format][c1cm] and are descriptive. <!-- Notes on these requirements: - While not required, we encourage you to sign your commits with GPG or SSH to attest the authenticity of your changes. - While we allow LLM-assisted contributions, we do not appreciate contributions that are low quality, which is typical of machine-generated contributions that have not had a lot of love and care from a human. Please do not open a PR if all you have done is asked ChatGPT to tidy up the codebase with a +-100,000 diff. - In the case of code style violations, reviewers may leave review comments/change requests indicating what the ideal change would look like. For example, a reviewer may suggest you lower a log level, or use `match` instead of `if/else` etc. - In the case of code style violations, pre-commit check failures, minor things like typos/spelling errors, and in some cases commit format violations, reviewers may modify your branch directly, typically by making changes and adding a commit. Particularly in the latter case, a reviewer may rebase your commits to squash "spammy" ones (like "fix", "fix", "actually fix"), and reword commit messages that don't satisfy the format. - Pull requests MUST pass the `Checks` CI workflows to be capable of being merged. This can only be bypassed in exceptional circumstances. If your CI flakes, let us know in matrix:r/dev:continuwuity.org. - Pull requests have to be based on the latest `main` commit before being merged. If the main branch changes while you're making your changes, you should make sure you rebase on main before opening a PR. Your branch will be rebased on main before it is merged if it has fallen behind. - We typically only do fast-forward merges, so your entire commit log will be included. Once in main, it's difficult to get out cleanly, so put on your best dress, smile for the cameras! --> [c1]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md [c2]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/docs/development/code_style.mdx [c1pc]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#pre-commit-checks [c1t]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#running-tests-locally [c1cm]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#commit-messages
👀 1 
Pending upstream PR #2546
This commit adds the config option `enable_msc4495_selective_presence`,
which will allow server operators to toggle MSC4495 before it is merged
into the spec. As this proposal is likely to break people's workflow up
until clients adequately support it, this gate is enabled for now.

We also pave the framework for future optional MSCs, by allowing the
`unstable_features()` function to take in a `Config` instance. This is
also propagated to callsites where it is used for path building by Ruma.
This commit adds the MSC4495 `userid_recipients` column, along with
the `PresenceRecipients` type and utilities.

For local users, this stores the user's most recently sent presence
recipients stream, and all remote and local users in their recipients set.

For remote users, this stores all local users in the recipient set as of
the last received presence EDU.

Additionally, utility functions for calculating and applying updates
are added.
This commit adds logic for MSC4495 to the presence module, specifically
calculating a user's desired recipient user set given their `m.presence.sharing`
account_data alongside hints in rooms they are a member of.
Adds `!admin debug recalculate-presence-recipients` and
`!admin query get-recipient-users`.
Adds the `presence_recipients` federation query endpoint, used by remote
servers to query the recipients of a local user in the case of a break
in the stream of EDU updates.
This commit applies recipient lists as access control to presence down `/sync`
and the `/client/users/{userId}/status` endpoint.
feat: handle outbound Selective Presence
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Auto Labeler / Apply labels based on changed files (pull_request_target) Successful in 3s
Details
Checks / Changelog / Check changelog is added (pull_request_target) Failing after 7s
Details
Checks / Prek / Check changed files (pull_request) Successful in 5s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m7s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Failing after 1m11s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled
Details
36d8118eb6
 
This commit moves responsibility for sending presence EDUs out of the
sender's `select_edus_presence` function, and instead to a push approach
from the presence module. Upon `set_presence` for a local user, the presence
module calculates the user's recipient set (if selective presence is enabled)
and then applies that information to outbound presence EDUs.
nex reviewed 2026-07-22 20:48:41 +00:00
src/core/config/mod.rs Outdated
@ -1491,0 +1494,4 @@
/// by default. Users will need to use MSC4495-compatible clients to explicitly
/// opt in to presence sharing with other users.
///
/// If this is enabled, you probably also want to set `allow_outgoing_presence`.
nex commented 2026-07-22 20:48:41 +00:00
Owner
Copy link

consistency nit:

- /// If this is enabled, you probably also want to set `allow_outgoing_presence`.
+ /// This option has no effect if `allow_outgoing_presence` is not enabled.
consistency nit: ```diff - /// If this is enabled, you probably also want to set `allow_outgoing_presence`. + /// This option has no effect if `allow_outgoing_presence` is not enabled. ```
thetayloredman commented 2026-07-22 21:14:53 +00:00
Author
Contributor
Copy link

Technically Selective Presence can be used locally only just fine. I've removed the line entirely, there was little point in it

Technically Selective Presence can be used locally only just fine. I've removed the line entirely, there was little point in it
thetayloredman marked this conversation as resolved
chore: add changelog fragment
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 6s
Details
Checks / Prek / Check changed files (pull_request) Successful in 5s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m16s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Failing after 1m39s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 11m16s
Details
99093551ec
chore: address CI failure and code review comment
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Check changed files (pull_request) Successful in 5s
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 6s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m9s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Failing after 1m18s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 8m9s
Details
62a3f42104
thetayloredman force-pushed presence-v2/msc4495 from 62a3f42104
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Check changed files (pull_request) Successful in 5s
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 6s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m9s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Failing after 1m18s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 8m9s
Details
to 2b04c909e5
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Check changed files (pull_request) Successful in 5s
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 6s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m8s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Failing after 1m20s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled
Details
2026-07-22 22:40:13 +00:00 Compare
thetayloredman force-pushed presence-v2/msc4495 from 2b04c909e5
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Check changed files (pull_request) Successful in 5s
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 6s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m8s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Failing after 1m20s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled
Details
to 5df240c824
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Check changed files (pull_request) Successful in 5s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m17s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m14s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 8m35s
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 12s
Details
2026-07-22 22:41:54 +00:00 Compare
thetayloredman force-pushed presence-v2/msc4495 from 5df240c824
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Check changed files (pull_request) Successful in 5s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m17s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m14s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 8m35s
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 12s
Details
to 32403f67f3
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 6s
Details
Checks / Prek / Check changed files (pull_request) Successful in 5s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m9s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m14s
Details
Deploy Element Web / 🏗️ Build and Deploy (pull_request) Failing after 6m43s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled
Details
2026-07-27 01:45:47 +00:00 Compare
thetayloredman force-pushed presence-v2/msc4495 from 32403f67f3
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 6s
Details
Checks / Prek / Check changed files (pull_request) Successful in 5s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m9s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m14s
Details
Deploy Element Web / 🏗️ Build and Deploy (pull_request) Failing after 6m43s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled
Details
to 03f2ac12f4
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Check changed files (pull_request) Successful in 5s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m9s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m35s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 8m50s
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 6s
Details
2026-07-27 01:55:09 +00:00 Compare
thetayloredman commented 2026-07-27 01:55:18 +00:00
Author
Contributor
Copy link

This PR is now using upstream Ruma, as merged in #2049.

This PR is now using upstream Ruma, as merged in #2049.
thetayloredman changed title from WIP: feat: implement optional support for MSC4495 (Selective Presence) to feat: implement optional support for MSC4495 (Selective Presence) 2026-07-27 01:55:22 +00:00
nex commented 2026-07-27 19:51:17 +00:00
Owner
Copy link

I'm inclined to say we should wait on merging this into main until at least one client supports it, so that we avoid having (temporarily) dead code to keep up with, especially given the size of the change. The PR can still be deployed if a client wishes to use it.

I'm inclined to say we should wait on merging this into main until at least one client supports it, so that we avoid having (temporarily) dead code to keep up with, especially given the size of the change. The PR can still be deployed if a client wishes to use it.
👍 1
thetayloredman force-pushed presence-v2/msc4495 from 03f2ac12f4
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Check changed files (pull_request) Successful in 5s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m9s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m35s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 8m50s
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 6s
Details
to 05637acc6c
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 6s
Details
Checks / Prek / Check changed files (pull_request) Successful in 6s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 56s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m21s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 9m13s
Details
2026-07-28 00:48:01 +00:00 Compare
thetayloredman force-pushed presence-v2/msc4495 from 05637acc6c
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 6s
Details
Checks / Prek / Check changed files (pull_request) Successful in 6s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 56s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m21s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 9m13s
Details
to b553c1f0da
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Check changed files (pull_request) Successful in 5s
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 12s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m15s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m6s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 11m6s
Details
2026-07-28 01:47:46 +00:00 Compare
thetayloredman force-pushed presence-v2/msc4495 from b553c1f0da
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Check changed files (pull_request) Successful in 5s
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 12s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m15s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m6s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 11m6s
Details
to 4bb690ecd9
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Check changed files (pull_request) Successful in 5s
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 6s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m12s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m10s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 8m30s
Details
2026-07-28 03:45:07 +00:00 Compare
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Check changed files (pull_request) Successful in 5s
Required
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 6s
Required
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m12s
Required
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m10s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 8m30s
Required
Details
This pull request is blocked because it's outdated.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u presence-v2/msc4495:thetayloredman-presence-v2/msc4495
git switch thetayloredman-presence-v2/msc4495
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Abandoned
This pull request appears to be abandoned by its author.

  
Blocked
This pull request or issue is currently blocked from being merged/closed

  
Bug
Something isn't working as intended

  
Changelog
Added
 Changelog entry added

  
Changelog
Missing
 No changelog when one is needed

  
Changelog
None
 Changelog is unnecesary for this change

  
Cherry-picking
Commits picked from other conduit projects

  
Database
This requires or includes changes to the database

  
Dependencies
Something dependency related

  
Dependencies/Renovate
Automatic dependency upgrades by Renovate

  
Difficulty
Easy
 Low difficulty to implement - touches few parts of the codebase, low complexity

  
Difficulty
Hard
 High difficulty to implement - touches many parts of the codebase, high complexity

  
Difficulty
Medium
 Medium difficulty to implement - touches more parts of the codebase, higher complexity

  
Documentation
Improvements or additions to documentation

  
Enhancement
New feature or request

  
Good first issue
Good for newcomers

  
Help wanted
Additional eyes and keyboards are required for this one

  
Inherited
Issues that have been inhereted from the project pre-fork

  
Matrix/Administration
Features pertaining to homeserver administration

  
Matrix/Appservices
Features pertaining to the appservice API

  
Matrix/Auth
Features pertaining to authentication

  
Matrix/Client
Features pertaining to client-to-server interactions

  
Matrix/Core
Issues relating to core matrix functionality, such as state resolution and PDU formats

  
Matrix/E2EE
Issues related to end to end encryption

  
Matrix/Federation
Features pertaining to server-to-server interactions

  
Matrix/Hydra
Issues related to room version 12 and related changes (temporary label)

  
Matrix/MSC
Features pertaining to unstable matrix features

  
Matrix/Media
Features pertaining to media interactions

  
Matrix/T&S
Changes or issues related to trust & safety tooling

  
Merge
This PR is ready to be merged

  
Merge/Manual
This PR should be manually merged

  
Merge/Squash
This PR should be squashed when it is merged

  
Meta
Related to housekeeping, maintenance, or other repo-meta.

  
Meta/CI
Issues related to CI changes

  
Meta/Packaging
Packaging

  
Priority
Blocking
 This issue is blocking the next release

  
Priority
High
 This issue is very important

  
Priority
Low
 This issue is of a rather low priority

  
Security
This item is related to general security

  
Status
Confirmed
 This issue has enough information and is confirmed

  
Status
Duplicate
 This issue or pull request already exists

  
Status
Invalid
 This issue doesn't seem right

  
Status
Needs Investigation
 This issue needs further investigation

  
Support
Questions or support requests

  
bob the builder
pdu logic rewrite starring nexus nicholson

No labels
Abandoned
Blocked
Bug
Changelog
Added
Changelog
Missing
Changelog
None
Cherry-picking
Database
Dependencies
Dependencies/Renovate
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/E2EE
Matrix/Federation
Matrix/Hydra
Matrix/MSC
Matrix/Media
Matrix/T&S
Merge
Merge/Manual
Merge/Squash
Meta
Meta/CI
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
Support
bob the builder
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
continuwuation/continuwuity!2034
No description provided.