fix: Deliver simplified sliding sync account data without hanging #2048

eleboucher · 2026-07-26T13:50:37Z

eleboucher commented

2026-07-26 13:50:37 +00:00

Fixed simplified sliding sync holding account data for up to 30 seconds before delivering it, because the long-poll idle check ignored the account_data extension. Encryption setup and cross-signing resets appeared to hang, as each of their account data writes waited a full poll cycle for its echo.

Pull request checklist:

This pull request targets the main branch, and the branch is named something other than
main.
I have written an appropriate pull request title and my description is clear.
I understand I am responsible for the contents of this pull request.
I have followed the contributing guidelines:
- My contribution follows the code style, if applicable.
- I ran pre-commit checks before opening/drafting this pull request.
- I have tested my contribution (or proof-read it for documentation-only changes)
  myself, if applicable. This includes ensuring code compiles.
- My commit messages follow the commit message format and are descriptive.

Fixed simplified sliding sync holding account data for up to 30 seconds before delivering it, because the long-poll idle check ignored the `account_data` extension. Encryption setup and cross-signing resets appeared to hang, as each of their account data writes waited a full poll cycle for its echo.     **Pull request checklist:**  - [x] This pull request targets the `main` branch, and the branch is named something other than `main`. - [x] I have written an appropriate pull request title and my description is clear. - [x] I understand I am responsible for the contents of this pull request. - I have followed the [contributing guidelines][c1]: - [x] My contribution follows the [code style][c2], if applicable. - [x] I ran [pre-commit checks][c1pc] before opening/drafting this pull request. - [x] I have [tested my contribution][c1t] (or proof-read it for documentation-only changes) myself, if applicable. This includes ensuring code compiles. - [ ] My commit messages follow the [commit message format][c1cm] and are descriptive.  [c1]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md [c2]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/docs/development/code_style.mdx [c1pc]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#pre-commit-checks [c1t]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#running-tests-locally [c1cm]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#commit-messages

eleboucher added 1 commit

2026-07-26 13:50:37 +00:00

fix: Deliver simplified sliding sync account data without hanging

Documentation / Build and Deploy Documentation (pull_request) Has been skipped

Details

Auto Labeler / Apply labels based on changed files (pull_request_target) Successful in 3s

Details

Checks / Changelog / Check changelog is added (pull_request_target) Successful in 6s

Details

Checks / Prek / Check changed files (pull_request) Successful in 5s

Details

Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m3s

Details

Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled

Details

70313ea928

forgejo-actions added the

Changelog

Added

label

2026-07-26 13:50:44 +00:00

nex requested changes

2026-07-26 13:52:45 +00:00

Dismissed

src/api/client/sync/v5.rs Outdated

					
				@ -211,0 +211,4 @@

							.values()

							.all(Vec::is_empty);

					if no_account_data

probably a good idea to put each of these condition checks in their own variables if we're adding more, so the if statement looks more like if no_account_data && no_room_data && no_to_device_messages

probably a good idea to put each of these condition checks in their own variables if we're adding more, so the `if` statement looks more like `if no_account_data && no_room_data && no_to_device_messages`