fix: Don't treat policy server signing keys as required for signature verification #2058

Merged

nex merged 2 commits from nex/fix/skip-notary-ps-key into main

2026-07-27 16:01:34 +00:00

nex commented

2026-07-27 15:13:56 +00:00

Owner

I noticed my server kept asking notaries for the ed25519:policy_server signing key, which the spec says is not supposed to be queried as it's in the room state (and also not required for general signature verification). This PR just filters out that specific key.

This will break servers that use the key ID ed25519:policy_server as their primary signing key ID but frankly if someone's doing that then that sounds like their problem.

Pull request checklist:

This pull request targets the main branch, and the branch is named something other than
main.
I have written an appropriate pull request title and my description is clear.
I understand I am responsible for the contents of this pull request.
I have followed the contributing guidelines:
- My contribution follows the code style, if applicable.
- I ran pre-commit checks before opening/drafting this pull request.
- I have tested my contribution (or proof-read it for documentation-only changes)
  myself, if applicable. This includes ensuring code compiles.
- My commit messages follow the commit message format and are descriptive.

I noticed my server kept asking notaries for the `ed25519:policy_server` signing key, which the spec says is not supposed to be queried as it's in the room state (and also not required for general signature verification). This PR just filters out that specific key. This will break servers that use the key ID `ed25519:policy_server` as their primary signing key ID but frankly if someone's doing that then that sounds like their problem.     **Pull request checklist:**  - [x] This pull request targets the `main` branch, and the branch is named something other than `main`. - [x] I have written an appropriate pull request title and my description is clear. - [x] I understand I am responsible for the contents of this pull request. - I have followed the [contributing guidelines][c1]: - [x] My contribution follows the [code style][c2], if applicable. - [x] I ran [pre-commit checks][c1pc] before opening/drafting this pull request. - [ ] I have [tested my contribution][c1t] (or proof-read it for documentation-only changes) myself, if applicable. This includes ensuring code compiles. - [x] My commit messages follow the [commit message format][c1cm] and are descriptive.  [c1]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md [c2]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/docs/development/code_style.mdx [c1pc]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#pre-commit-checks [c1t]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#running-tests-locally [c1cm]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#commit-messages

Rows
Columns