continuwuation/continuwuity
continuwuation/continuwuity
16
112
Fork 125
Code Issues 136 Pull requests 26 Releases 40 Packages 3 Activity Actions 4

feat(push): Add MSC4174 web push #2122

Open
eleboucher wants to merge 1 commit from eleboucher/continuwuity:feat/msc4174-webpush into main
pull from: eleboucher/continuwuity:feat/msc4174-webpush
merge into: continuwuation:main
Conversation 13 Commits 1 Files changed 23 +1836 -242
eleboucher commented 2026-08-10 11:55:07 +00:00
Contributor
Copy link

This pull request implement the MSC4174, tested e2e with complement

Fixes: #1849

Pull request checklist:

  • This pull request targets the main branch, and the branch is named something other than
    main.
  • I have written an appropriate pull request title and my description is clear.
  • I understand I am responsible for the contents of this pull request.
  • I have followed the contributing guidelines:
<!-- In order to help reviewers know what your pull request does at a glance, you should ensure that 1. Your PR title is a short, single sentence describing what you changed 2. You have described in more detail what you have changed, why you have changed it, what the intended effect is, and why you think this will be beneficial to the project. If you have made any potentially strange/questionable design choices, but didn't feel they'd benefit from code comments, please don't mention them here - after opening your pull request, go to "files changed", and click on the "+" symbol in the line number gutter, and attach comments to the lines that you think would benefit from some clarification. --> This pull request implement the MSC4174, tested e2e with complement <!-- Example: This pull request allows us to warp through time and space ten times faster than before by double-inverting the warp drive with hyperheated jump fluid, both making the drive faster and more efficient. This resolves the common issue where we have to wait more than 10 milliseconds to engage, use, and disengage the warp drive when travelling between galaxies. --> <!-- Closes: #... --> Fixes: #1849 <!-- Uncomment the above line(s) if your pull request fixes an issue or closes another pull request by superseding it. Replace `#...` with the issue/pr number, such as `#123`. --> **Pull request checklist:** <!-- You need to complete these before your PR can be considered. If you aren't sure about some, feel free to ask for clarification in #dev:continuwuity.org. --> - [x] This pull request targets the `main` branch, and the branch is named something other than `main`. - [x] I have written an appropriate pull request title and my description is clear. - [x] I understand I am responsible for the contents of this pull request. - I have followed the [contributing guidelines][c1]: - [x] My contribution follows the [code style][c2], if applicable. - [x] I ran [pre-commit checks][c1pc] before opening/drafting this pull request. - [x] I have [tested my contribution][c1t] (or proof-read it for documentation-only changes) myself, if applicable. This includes ensuring code compiles. - [x] My commit messages follow the [commit message format][c1cm] and are descriptive. <!-- Notes on these requirements: - While not required, we encourage you to sign your commits with GPG or SSH to attest the authenticity of your changes. - While we allow LLM-assisted contributions, we do not appreciate contributions that are low quality, which is typical of machine-generated contributions that have not had a lot of love and care from a human. Please do not open a PR if all you have done is asked ChatGPT to tidy up the codebase with a +-100,000 diff. - In the case of code style violations, reviewers may leave review comments/change requests indicating what the ideal change would look like. For example, a reviewer may suggest you lower a log level, or use `match` instead of `if/else` etc. - In the case of code style violations, pre-commit check failures, minor things like typos/spelling errors, and in some cases commit format violations, reviewers may modify your branch directly, typically by making changes and adding a commit. Particularly in the latter case, a reviewer may rebase your commits to squash "spammy" ones (like "fix", "fix", "actually fix"), and reword commit messages that don't satisfy the format. - Pull requests MUST pass the `Checks` CI workflows to be capable of being merged. This can only be bypassed in exceptional circumstances. If your CI flakes, let us know in matrix:r/dev:continuwuity.org. - Pull requests have to be based on the latest `main` commit before being merged. If the main branch changes while you're making your changes, you should make sure you rebase on main before opening a PR. Your branch will be rebased on main before it is merged if it has fallen behind. - We typically only do fast-forward merges, so your entire commit log will be included. Once in main, it's difficult to get out cleanly, so put on your best dress, smile for the cameras! --> [c1]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md [c2]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/docs/development/code_style.mdx [c1pc]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#pre-commit-checks [c1t]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#running-tests-locally [c1cm]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#commit-messages
feat(push): Add MSC4174 web push
All checks were successful
Auto Labeler / Apply labels based on changed files (pull_request_target) Successful in 3s
Details
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Check changed files (pull_request) Successful in 5s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m13s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m20s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 9m23s
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 7s
Details
5a2f881a26
Henry-Hiles commented 2026-08-11 14:11:32 +00:00
Member
Copy link

Re: Requested for review

I haven't the Rust knowledge to confidently say the code is good, but it seems alright.

I've spun up a Continuwuity on localhost, but haven't actually tested web push yet. I'll need to implement it in Nexus for this, and that means waiting for Tulir to implement needed stuff on Gomuks too, so it may take a little time.

Re: Requested for review I haven't the Rust knowledge to confidently say the code is good, but it seems alright. I've spun up a Continuwuity on localhost, but haven't actually tested web push yet. I'll need to implement it in Nexus for this, and that means waiting for Tulir to implement needed stuff on Gomuks too, so it may take a little time.
nex commented 2026-08-11 14:12:34 +00:00
Owner
Copy link

I requested your review because you mentioned you were going to test this locally ahead of merge, so any issues you find will be valuable to hear as part of the code review process itself :)

I requested your review because you mentioned you were going to test this locally ahead of merge, so any issues you find will be valuable to hear as part of the code review process itself :)
❤️ 1
eleboucher commented 2026-08-11 14:13:13 +00:00
Author
Contributor
Copy link

i will also try to implement the part on sable

i will also try to implement the part on sable
❤️ 1
nex requested changes 2026-08-11 14:25:28 +00:00
nex left a comment
Copy link

Mostly just code style concerns, I don't see anything functionally wrong here (checks out with passing complement tests)

Mostly just code style concerns, I don't see anything functionally wrong here (checks out with passing complement tests)
src/api/client/push.rs Outdated
@ -484,0 +530,4 @@
Err!(Request(NotFound("No pusher with this app ID exists.")))
},
| ActivationOutcome::UnknownToken =>
Err(activation_token_error(&UNKNOWN_ACTIVATION_TOKEN, "Unknown activation token.")),
nex commented 2026-08-11 14:15:54 +00:00
Owner
Copy link

Couldn't this just be inlined into an Err!() macro call? rather than calling an entire function?

Couldn't this just be inlined into an `Err!()` macro call? rather than calling an entire function?
eleboucher marked this conversation as resolved
src/api/client/push.rs Outdated
@ -484,0 +531,4 @@
},
| ActivationOutcome::UnknownToken =>
Err(activation_token_error(&UNKNOWN_ACTIVATION_TOKEN, "Unknown activation token.")),
| ActivationOutcome::Expired => Err(activation_token_error(
nex commented 2026-08-11 14:15:59 +00:00
Owner
Copy link

Same here

Same here
Henry-Hiles commented 2026-08-13 14:22:11 +00:00
Member
Copy link

I see this was marked as resolved, but I don't see a new commit? Same goes for the other resolved conversations.

I see this was marked as resolved, but I don't see a new commit? Same goes for the other resolved conversations.
eleboucher commented 2026-08-13 14:52:58 +00:00
Author
Contributor
Copy link

damn i must be blind or stupid

damn i must be blind or stupid
Henry-Hiles marked this conversation as resolved
src/api/client/push.rs Outdated
@ -484,0 +539,4 @@
}
static EXPIRED_ACTIVATION_TOKEN: LazyLock<ErrorKind> =
LazyLock::new(|| custom_error_kind("M_EXPIRED_ACTIVATION_TOKEN"));
nex commented 2026-08-11 14:15:37 +00:00
Owner
Copy link

Shouldn't the unstable prefix be used in these error codes?

Shouldn't the unstable prefix be used in these error codes?
eleboucher commented 2026-08-11 15:26:37 +00:00
Author
Contributor
Copy link

i'm following the spec here

i'm following the spec here
Henry-Hiles marked this conversation as resolved
src/api/client/push.rs Outdated
@ -484,0 +543,4 @@
static UNKNOWN_ACTIVATION_TOKEN: LazyLock<ErrorKind> =
LazyLock::new(|| custom_error_kind("M_UNKNOWN_ACTIVATION_TOKEN"));
fn custom_error_kind(errcode: &str) -> ErrorKind {
nex commented 2026-08-11 14:15:28 +00:00
Owner
Copy link

This seems like an odd way to define the custom error, any reason not to just add it to the ErrorKind enum itself?

This seems like an odd way to define the custom error, any reason not to just add it to the `ErrorKind` enum itself?
eleboucher marked this conversation as resolved
src/core/config/mod.rs Outdated
@ -1582,1 +1582,4 @@
/// Allow encrypted Web Push pushers (MSC4174).
#[serde(default)]
pub allow_webpush: bool,
nex commented 2026-08-11 14:16:58 +00:00
Owner
Copy link

Since webpush_vapid_contact has to be set to enable the feature, and it defaults to unset, I think this allow flag might be redundant in this case

Since `webpush_vapid_contact` has to be set to enable the feature, and it defaults to unset, I think this allow flag might be redundant in this case
eleboucher marked this conversation as resolved
src/ruminuwuity/pushers/ack.rs Outdated
@ -0,0 +1,36 @@
pub mod v3 {
nex commented 2026-08-11 14:17:33 +00:00
Owner
Copy link

nit: Should be unstable instead of v3 until the proposal is stable

nit: Should be `unstable` instead of `v3` until the proposal is stable
eleboucher marked this conversation as resolved
src/service/pusher/webpush.rs Outdated
@ -0,0 +1,614 @@
use std::{collections::HashMap, sync::Arc, time::Duration};
nex commented 2026-08-11 14:24:55 +00:00
Owner
Copy link

This file is rather quite large/dense, it might be worth splitting the Vapid impl, Service impl, and utilities (funcs and consts) into separate files for easier maintainability.
I'd also recommend attaching docstrings to the function defs and ideally some comments dotted around to explain what the server is doing to help someone who might be looking at this code having never seen actual webpush stuff (e.g. me) to understand what is going on

This file is rather quite large/dense, it might be worth splitting the `Vapid` impl, `Service` impl, and utilities (funcs and consts) into separate files for easier maintainability. I'd also recommend attaching docstrings to the function defs and ideally some comments dotted around to explain what the server is doing to help someone who might be looking at this code having never seen actual webpush stuff (e.g. me) to understand what is going on
eleboucher marked this conversation as resolved
eleboucher requested review from nex 2026-08-12 17:06:05 +00:00
Henry-Hiles commented 2026-08-12 17:12:59 +00:00
Member
Copy link

Blocked on https://github.com/matrix-org/matrix-spec-proposals/pull/4174#discussion_r3761648776.

Blocked on https://github.com/matrix-org/matrix-spec-proposals/pull/4174#discussion_r3761648776.
eleboucher force-pushed feat/msc4174-webpush from 5a2f881a26
All checks were successful
Auto Labeler / Apply labels based on changed files (pull_request_target) Successful in 3s
Details
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Check changed files (pull_request) Successful in 5s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m13s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m20s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 9m23s
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 7s
Details
to 877b7d71a6
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 7s
Details
Checks / Prek / Check changed files (pull_request) Successful in 8s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m20s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m40s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 9m50s
Details
2026-08-13 15:08:23 +00:00 Compare
eleboucher force-pushed feat/msc4174-webpush from 877b7d71a6
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 7s
Details
Checks / Prek / Check changed files (pull_request) Successful in 8s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m20s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m40s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 9m50s
Details
to c6c7587955
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 7s
Details
Checks / Prek / Check changed files (pull_request) Successful in 6s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Failing after 1m13s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m20s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 8m21s
Details
2026-08-13 15:30:15 +00:00 Compare
eleboucher force-pushed feat/msc4174-webpush from c6c7587955
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 7s
Details
Checks / Prek / Check changed files (pull_request) Successful in 6s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Failing after 1m13s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m20s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 8m21s
Details
to c234f001f7
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Check changed files (pull_request) Successful in 6s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m13s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m20s
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 10s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 8m17s
Details
2026-08-13 15:49:11 +00:00 Compare
Henry-Hiles commented 2026-08-14 19:33:44 +00:00
Member
Copy link

Could this follow https://github.com/matrix-org/matrix-spec-proposals/pull/4174#discussion_r3786568663 for now? Until it's written into the MSC, or until the MSC is in spec and therefore using stable identifiers?

Could this follow https://github.com/matrix-org/matrix-spec-proposals/pull/4174#discussion_r3786568663 for now? Until it's written into the MSC, or until the MSC is in spec and therefore using stable identifiers?
eleboucher commented 2026-08-14 19:57:41 +00:00
Author
Contributor
Copy link

@Henry-Hiles wrote in #2122 (comment):

Could this follow https://github.com/matrix-org/matrix-spec-proposals/pull/4174#discussion_r3786568663 for now? Until it's written into the MSC, or until the MSC is in spec and therefore using stable identifiers?

Done let's get this merge now :D

@Henry-Hiles wrote in https://forgejo.ellis.link/continuwuation/continuwuity/pulls/2122#issuecomment-34168: > Could this follow https://github.com/matrix-org/matrix-spec-proposals/pull/4174#discussion_r3786568663 for now? Until it's written into the MSC, or until the MSC is in spec and therefore using stable identifiers? Done let's get this merge now :D
eleboucher force-pushed feat/msc4174-webpush from c234f001f7
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Check changed files (pull_request) Successful in 6s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m13s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m20s
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 10s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 8m17s
Details
to 1833c6b35e
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Check changed files (pull_request) Successful in 7s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m11s
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 8s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m20s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 8m26s
Details
2026-08-14 19:58:28 +00:00 Compare
Henry-Hiles commented 2026-08-14 19:59:14 +00:00
Member
Copy link

TBH i'm not certain it'd get merged until the MSC itself is updated to have unstable prefixes, but I can at least test this now :)

I'll try to get an impl going in Nexus sometime soon.

TBH i'm not certain it'd get merged until the MSC itself is updated to have unstable prefixes, but I can at least test this now :) I'll try to get an impl going in Nexus sometime soon.
eleboucher force-pushed feat/msc4174-webpush from 1833c6b35e
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Check changed files (pull_request) Successful in 7s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m11s
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 8s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m20s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 8m26s
Details
to 9fc2bbe0e7
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 7s
Details
Checks / Prek / Check changed files (pull_request) Successful in 7s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m23s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m7s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 8m53s
Details
2026-08-14 21:49:49 +00:00 Compare
eleboucher force-pushed feat/msc4174-webpush from 9fc2bbe0e7
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 7s
Details
Checks / Prek / Check changed files (pull_request) Successful in 7s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m23s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m7s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 8m53s
Details
to abc6101a2f
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 7s
Details
Checks / Prek / Check changed files (pull_request) Successful in 6s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m12s
Details
Update flake hashes / update-flake-hashes (pull_request) Failing after 4m53s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 8m19s
Details
2026-08-17 15:35:22 +00:00 Compare
Henry-Hiles commented 2026-08-18 02:53:08 +00:00
Member
Copy link

Once https://github.com/matrix-org/matrix-spec-proposals/pull/4174/changes#r3800536083 is applied to the MSC, this can be unblocked.

Once https://github.com/matrix-org/matrix-spec-proposals/pull/4174/changes#r3800536083 is applied to the MSC, this can be unblocked.
eleboucher force-pushed feat/msc4174-webpush from abc6101a2f
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 7s
Details
Checks / Prek / Check changed files (pull_request) Successful in 6s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m12s
Details
Update flake hashes / update-flake-hashes (pull_request) Failing after 4m53s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 8m19s
Details
to d7236bb279
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 6s
Details
Checks / Prek / Check changed files (pull_request) Successful in 7s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m14s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m23s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 5m16s
Details
2026-08-18 09:12:51 +00:00 Compare
Henry-Hiles commented 2026-08-18 13:39:24 +00:00
Member
Copy link

Hi, the MSC now has an unstable prefix, so it should be ready to be implemented.

Does this PR already follow https://github.com/matrix-org/matrix-spec-proposals/pull/4174/changes#diff-b2f2ad49aabe11774709efbdd9f7d3537ed2ed223b0a868d69e9db814dd18887R219?

EDIT: It appears to.

Hi, the MSC now has an unstable prefix, so it should be ready to be implemented. Does this PR already follow https://github.com/matrix-org/matrix-spec-proposals/pull/4174/changes#diff-b2f2ad49aabe11774709efbdd9f7d3537ed2ed223b0a868d69e9db814dd18887R219? EDIT: It appears to.
eleboucher force-pushed feat/msc4174-webpush from d7236bb279
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 6s
Details
Checks / Prek / Check changed files (pull_request) Successful in 7s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m14s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m23s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 5m16s
Details
to c4adfb3e76
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 7s
Details
Checks / Prek / Check changed files (pull_request) Successful in 6s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m13s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m22s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 8m17s
Details
2026-08-18 18:38:37 +00:00 Compare
Aranjedeath reviewed 2026-08-19 18:48:39 +00:00
conduwuit-example.toml Outdated
@ -1333,1 +1333,4 @@
# Allow encrypted Web Push pushers (MSC4174).
# VAPID contact URI (mailto: or https:).
#webpush_vapid_contact =
Aranjedeath commented 2026-08-19 18:48:39 +00:00
Owner
Copy link

we have built-in contact page, so this can be automatic! :>

we have built-in contact page, so this can be automatic! :>
👍 1
eleboucher commented 2026-08-19 20:16:53 +00:00
Author
Contributor
Copy link

done

done
eleboucher marked this conversation as resolved
refactor(config): Reuse support_email for web push VAPID contact
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 6s
Details
Checks / Prek / Check changed files (pull_request) Successful in 7s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m28s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m4s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 8m16s
Details
b5d6177d5e
Jade commented 2026-08-19 20:18:14 +00:00
Owner
Copy link

What no, we meant the "about" web page that displays support contacts - email isn't set by default

What no, we meant the "about" web page that displays support contacts - email isn't set by default
refactor(config): Fall back to support page for web push VAPID contact
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 6s
Details
Checks / Prek / Check changed files (pull_request) Successful in 6s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Has been cancelled
Details
Update flake hashes / update-flake-hashes (pull_request) Has been cancelled
Details
5ecbdf201c
eleboucher force-pushed feat/msc4174-webpush from 5ecbdf201c
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 6s
Details
Checks / Prek / Check changed files (pull_request) Successful in 6s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Has been cancelled
Details
Update flake hashes / update-flake-hashes (pull_request) Has been cancelled
Details
to bbddc2b22f
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 7s
Details
Checks / Prek / Check changed files (pull_request) Successful in 6s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 54s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m20s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 8m14s
Details
2026-08-19 20:35:25 +00:00 Compare
eleboucher force-pushed feat/msc4174-webpush from bbddc2b22f
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 7s
Details
Checks / Prek / Check changed files (pull_request) Successful in 6s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 54s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m20s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 8m14s
Details
to 84aae2b5c0
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 7s
Details
Checks / Prek / Check changed files (pull_request) Successful in 7s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m14s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m19s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 9m15s
Details
2026-08-22 18:56:27 +00:00 Compare
Henry-Hiles requested changes 2026-08-23 00:12:37 +00:00
Henry-Hiles left a comment
Copy link

Vapid info is not returned on capabilities request:

{
    "capabilities": {
        "m.room_versions": {
            "default": "12",
            "available": {
                "10": "stable",
                "11": "stable",
                "12": "stable",
                "3": "unstable",
                "4": "unstable",
                "5": "unstable",
                "6": "stable",
                "7": "stable",
                "8": "stable",
                "9": "stable"
            }
        },
        "m.3pid_changes": { "enabled": false },
        "m.get_login_token": { "enabled": true },
        "m.profile_fields": { "enabled": true, "disallowed": [] },
        "m.forget_forced_upon_leave": { "enabled": true },
        "m.account_moderation": { "suspend": true, "lock": true }
    }
}
Vapid info is not returned on capabilities request: ```json { "capabilities": { "m.room_versions": { "default": "12", "available": { "10": "stable", "11": "stable", "12": "stable", "3": "unstable", "4": "unstable", "5": "unstable", "6": "stable", "7": "stable", "8": "stable", "9": "stable" } }, "m.3pid_changes": { "enabled": false }, "m.get_login_token": { "enabled": true }, "m.profile_fields": { "enabled": true, "disallowed": [] }, "m.forget_forced_upon_leave": { "enabled": true }, "m.account_moderation": { "suspend": true, "lock": true } } } ```
eleboucher force-pushed feat/msc4174-webpush from 84aae2b5c0
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 7s
Details
Checks / Prek / Check changed files (pull_request) Successful in 7s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m14s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m19s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 9m15s
Details
to 57888e15f5
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 11s
Details
Checks / Prek / Check changed files (pull_request) Successful in 7s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m19s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m31s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 9m48s
Details
2026-08-23 09:01:45 +00:00 Compare
eleboucher force-pushed feat/msc4174-webpush from 57888e15f5
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 11s
Details
Checks / Prek / Check changed files (pull_request) Successful in 7s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m19s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m31s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 9m48s
Details
to fcaf1a2130
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 7s
Details
Checks / Prek / Check changed files (pull_request) Successful in 6s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m15s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m24s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled
Details
2026-08-23 13:45:15 +00:00 Compare
eleboucher force-pushed feat/msc4174-webpush from fcaf1a2130
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 7s
Details
Checks / Prek / Check changed files (pull_request) Successful in 6s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m15s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m24s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled
Details
to 7ca69e9311
All checks were successful
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 9s
Details
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Check changed files (pull_request) Successful in 6s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m15s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m21s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 9m20s
Details
2026-08-23 13:47:54 +00:00 Compare
eleboucher force-pushed feat/msc4174-webpush from 7ca69e9311
All checks were successful
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 9s
Details
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Check changed files (pull_request) Successful in 6s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m15s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m21s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 9m20s
Details
to fd70f57f23
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 7s
Details
Checks / Prek / Check changed files (pull_request) Successful in 7s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m14s
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m24s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 8m15s
Details
2026-08-23 14:07:34 +00:00 Compare
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 7s
Required
Details
Checks / Prek / Check changed files (pull_request) Successful in 7s
Required
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m14s
Required
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m24s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 8m15s
Required
Details
This pull request is blocked because it's outdated.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u feat/msc4174-webpush:eleboucher-feat/msc4174-webpush
git switch eleboucher-feat/msc4174-webpush
Sign in to join this conversation.
Reviewers
No reviewers
nex
Henry-Hiles
Labels
Clear labels   
Abandoned
This pull request appears to be abandoned by its author.

  
Blocked
This pull request or issue is currently blocked from being merged/closed

  
Bug
Something isn't working as intended

  
Changelog
Added
 Changelog entry added

  
Changelog
Missing
 No changelog when one is needed

  
Changelog
None
 Changelog is unnecesary for this change

  
Cherry-picking
Commits picked from other conduit projects

  
Database
This requires or includes changes to the database

  
Dependencies
Something dependency related

  
Dependencies/Renovate
Automatic dependency upgrades by Renovate

  
Difficulty
Easy
 Low difficulty to implement - touches few parts of the codebase, low complexity

  
Difficulty
Hard
 High difficulty to implement - touches many parts of the codebase, high complexity

  
Difficulty
Medium
 Medium difficulty to implement - touches more parts of the codebase, higher complexity

  
Documentation
Improvements or additions to documentation

  
Enhancement
New feature or request

  
Good first issue
Good for newcomers

  
Help wanted
Additional eyes and keyboards are required for this one

  
Inherited
Issues that have been inhereted from the project pre-fork

  
Matrix/Administration
Features pertaining to homeserver administration

  
Matrix/Appservices
Features pertaining to the appservice API

  
Matrix/Auth
Features pertaining to authentication

  
Matrix/Client
Features pertaining to client-to-server interactions

  
Matrix/Core
Issues relating to core matrix functionality, such as state resolution and PDU formats

  
Matrix/E2EE
Issues related to end to end encryption

  
Matrix/Federation
Features pertaining to server-to-server interactions

  
Matrix/Hydra
Issues related to room version 12 and related changes (temporary label)

  
Matrix/MSC
Features pertaining to unstable matrix features

  
Matrix/Media
Features pertaining to media interactions

  
Matrix/T&S
Changes or issues related to trust & safety tooling

  
Merge
This PR is ready to be merged

  
Merge/Manual
This PR should be manually merged

  
Merge/Squash
This PR should be squashed when it is merged

  
Meta
Related to housekeeping, maintenance, or other repo-meta.

  
Meta/CI
Issues related to CI changes

  
Meta/Packaging
Packaging

  
Priority
Blocking
 This issue is blocking the next release

  
Priority
High
 This issue is very important

  
Priority
Low
 This issue is of a rather low priority

  
Security
This item is related to general security

  
Status
Confirmed
 This issue has enough information and is confirmed

  
Status
Duplicate
 This issue or pull request already exists

  
Status
Invalid
 This issue doesn't seem right

  
Status
Needs Investigation
 This issue needs further investigation

  
Support
Questions or support requests

  
bob the builder
pdu logic rewrite starring nexus nicholson

No labels
Abandoned
Blocked
Bug
Changelog
Added
Changelog
Missing
Changelog
None
Cherry-picking
Database
Dependencies
Dependencies/Renovate
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/E2EE
Matrix/Federation
Matrix/Hydra
Matrix/MSC
Matrix/Media
Matrix/T&S
Merge
Merge/Manual
Merge/Squash
Meta
Meta/CI
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
Support
bob the builder
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
continuwuation/continuwuity!2122
No description provided.