refactor: Don't embed unsigned in storage #2270

Merged
nex merged 13 commits from nex/feat/unsigned into main 2026-09-27 18:42:52 +00:00

2026-09-27

chore: Add news frag
All checks were successful
Checks / Prek / Check changed files (pull_request) Successful in 6s
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 8s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m11s
Documentation / Build and Deploy Documentation (pull_request) Successful in 1m14s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 9m49s
Checks / Prek / Check changed files (push) Successful in 6s
Documentation / Build and Deploy Documentation (push) Successful in 1m29s
Checks / Prek / Pre-commit & Formatting (push) Successful in 1m43s
Checks / Prek / Clippy and Cargo Tests (push) Successful in 10m14s
Release Docker Image / Build linux-arm64 (release) (push) Successful in 12m23s
Release Docker Image / Build linux-arm64 (max-perf) (push) Has been skipped
Release Docker Image / Build linux-amd64 (release) (push) Successful in 14m15s
Release Docker Image / Create Multi-arch Release Manifest (push) Successful in 15s
Release Docker Image / Build linux-amd64 (max-perf) (push) Successful in 35m25s
Release Docker Image / Create Max-Perf Manifest (push) Has been skipped
Release Docker Image / Mirror Images (push) Has been skipped
Release Docker Image / Release Binaries (push) Has been skipped
2026-09-27 19:19:50 +01:00
feat: Add a migration to fix up unsigned data
Some checks failed
Checks / Changelog / Check changelog is added (pull_request_target) Failing after 6s
Checks / Prek / Check changed files (pull_request) Successful in 8s
Documentation / Build and Deploy Documentation (pull_request) Successful in 1m3s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m6s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 9m48s
2026-09-27 18:31:46 +01:00
style: Take an optional context instead of deconstructed parameters
Some checks failed
Checks / Changelog / Check changelog is added (pull_request_target) Failing after 40s
Checks / Prek / Check changed files (pull_request) Successful in 10s
Documentation / Build and Deploy Documentation (pull_request) Successful in 1m4s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m9s
Update flake hashes / update-flake-hashes (pull_request) Successful in 2m45s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 11m30s
2026-09-27 17:33:26 +01:00
fix: Don't allow set_unsigned to panic
While an error in this function is probably bad, detonating a metric tonne of TNT on the call tree is probably worse
2026-09-27 17:32:47 +01:00
fix: Move helper to helpers.rs, rename field, don't recurse unsigned in redacted_because
Renamed `redacted_because_id` to `org.continuwuity.redacted_by` for proper namespacing; `get_unsigned_context` now lives in helpers.rs instead of `mod.rs`. The helper function also now explicitly wipes `unsigned` for `redacted_because` to avoid leaks (see comment).
2026-09-27 17:32:46 +01:00