feat: Add selective logout support to admin cmds #2554

Open
melody wants to merge 2 commits from melody/continuwuity:feat/admin-users-selective-lougout into main
First-time contributor

This pull request adds selective logout support to the !admin users logout command.

As mentioned in the attached messages, some users seem to struggle with having a lot of stale devices singed in and having no easy way to get rid of them. This PR allows admins to remove specific devices/session from useraccounts which is, in my opinion, useful in following scenarios:
- Having a lot of stale sessions due to using a browser that automatically deletes cookies after shutdown and forgetting to log out every single time
- Wanting to clear out stale sessions but not wanting to bother with having to export and re-import all of the encryption keys
- An admin being able to log out a users specific device in case it got compromised and the user not remembering credentials (also ties into the whole key-exporting thing..)
- more?

Context
My inital message regarding struggling to log out a lot of stale devices at once

ganža mentioning this being a re-occuring problem and proposing this feature

This is breaking, so I propose to merge it together with !2439 in 27.1

Pull request checklist:

  • This pull request targets the main branch, and the branch is named something other than
    main.
  • I have written an appropriate pull request title and my description is clear.
  • I understand I am responsible for the contents of this pull request.
  • I have followed the contributing guidelines:
<!-- In order to help reviewers know what your pull request does at a glance, you should ensure that 1. Your PR title is a short, single sentence describing what you changed 2. You have described in more detail what you have changed, why you have changed it, what the intended effect is, and why you think this will be beneficial to the project. If you have made any potentially strange/questionable design choices, but didn't feel they'd benefit from code comments, please don't mention them here - after opening your pull request, go to "files changed", and click on the "+" symbol in the line number gutter, and attach comments to the lines that you think would benefit from some clarification. --> This pull request adds selective logout support to the `!admin users logout` command. As mentioned in the attached messages, some users seem to struggle with having a lot of stale devices singed in and having no easy way to get rid of them. This PR allows admins to remove specific devices/session from useraccounts which is, in my opinion, useful in following scenarios: - Having a lot of stale sessions due to using a browser that automatically deletes cookies after shutdown and forgetting to log out every single time - Wanting to clear out stale sessions but not wanting to bother with having to export and re-import all of the encryption keys - An admin being able to log out a users specific device in case it got compromised and the user not remembering credentials (also ties into the whole key-exporting thing..) - more? **Context** [My inital message regarding struggling to log out a lot of stale devices at once](matrix:roomid/c10y-jrqTOLA-GfF5T00rpGRvbzIyNUPduR9y7TeJzQ/e/u3yrhXVbymO2WMlxYNL6-DW-OUHZs5fNbH3z3IQacIY?via=continuwuity.org&via=continuwuity.rocks&via=matrix.org) [ganža mentioning this being a re-occuring problem and proposing this feature](matrix:roomid/c10y-jrqTOLA-GfF5T00rpGRvbzIyNUPduR9y7TeJzQ/e/1HywLkxy8GQQFkvwjazBC7diwFUkaY66-H80uX5XsNY?via=continuwuity.org&via=continuwuity.rocks&via=matrix.org) <!-- Example: This pull request allows us to warp through time and space ten times faster than before by double-inverting the warp drive with hyperheated jump fluid, both making the drive faster and more efficient. This resolves the common issue where we have to wait more than 10 milliseconds to engage, use, and disengage the warp drive when travelling between galaxies. --> <!-- Closes: #... --> <!-- Fixes: #... --> <!-- Uncomment the above line(s) if your pull request fixes an issue or closes another pull request by superseding it. Replace `#...` with the issue/pr number, such as `#123`. --> This is breaking, so I propose to merge it together with !2439 in 27.1 **Pull request checklist:** <!-- You need to complete these before your PR can be considered. If you aren't sure about some, feel free to ask for clarification in #dev:continuwuity.org. --> - [x] This pull request targets the `main` branch, and the branch is named something other than `main`. - [x] I have written an appropriate pull request title and my description is clear. - [x] I understand I am responsible for the contents of this pull request. - I have followed the [contributing guidelines][c1]: - [x] My contribution follows the [code style][c2], if applicable. - [x] I ran [pre-commit checks][c1pc] before opening/drafting this pull request. - [x] I have [tested my contribution][c1t] (or proof-read it for documentation-only changes) myself, if applicable. This includes ensuring code compiles. - [x] My commit messages follow the [commit message format][c1cm] and are descriptive. <!-- Notes on these requirements: - While not required, we encourage you to sign your commits with GPG or SSH to attest the authenticity of your changes. - While we allow LLM-assisted contributions, we do not appreciate contributions that are low quality, which is typical of machine-generated contributions that have not had a lot of love and care from a human. Please do not open a PR if all you have done is asked ChatGPT to tidy up the codebase with a +-100,000 diff. - In the case of code style violations, reviewers may leave review comments/change requests indicating what the ideal change would look like. For example, a reviewer may suggest you lower a log level, or use `match` instead of `if/else` etc. - In the case of code style violations, pre-commit check failures, minor things like typos/spelling errors, and in some cases commit format violations, reviewers may modify your branch directly, typically by making changes and adding a commit. Particularly in the latter case, a reviewer may rebase your commits to squash "spammy" ones (like "fix", "fix", "actually fix"), and reword commit messages that don't satisfy the format. - Pull requests MUST pass the `Checks` CI workflows to be capable of being merged. This can only be bypassed in exceptional circumstances. If your CI flakes, let us know in matrix:r/dev:continuwuity.org. - Pull requests have to be based on the latest `main` commit before being merged. If the main branch changes while you're making your changes, you should make sure you rebase on main before opening a PR. Your branch will be rebased on main before it is merged if it has fallen behind. - We typically only do fast-forward merges, so your entire commit log will be included. Once in main, it's difficult to get out cleanly, so put on your best dress, smile for the cameras! --> [c1]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md [c2]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/docs/development/code_style.mdx [c1pc]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#pre-commit-checks [c1t]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#running-tests-locally [c1cm]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#commit-messages
feat: Add selective logout support to admin cmds
Some checks failed
Auto Labeler / Apply labels based on changed files (pull_request_target) Successful in 4s
Checks / Changelog / Check changelog is added (pull_request_target) Failing after 15s
Documentation / Build and Deploy Documentation (pull_request) Has been cancelled
Checks / Prek / Pre-commit & Formatting (pull_request) Has been cancelled
Checks / Prek / Check changed files (pull_request) Has been cancelled
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled
e25816d414
Author
First-time contributor

Also, I was thinking it might make sense to add an additional command for listing a users devices?

Also, I was thinking it might make sense to add an additional command for listing a users devices?
melody force-pushed feat/admin-users-selective-lougout from e25816d414
Some checks failed
Auto Labeler / Apply labels based on changed files (pull_request_target) Successful in 4s
Checks / Changelog / Check changelog is added (pull_request_target) Failing after 15s
Documentation / Build and Deploy Documentation (pull_request) Has been cancelled
Checks / Prek / Pre-commit & Formatting (pull_request) Has been cancelled
Checks / Prek / Check changed files (pull_request) Has been cancelled
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled
to d3ffb63947
Some checks failed
Checks / Changelog / Check changelog is added (pull_request_target) Failing after 6s
Documentation / Build and Deploy Documentation (pull_request) Has been cancelled
Checks / Prek / Pre-commit & Formatting (pull_request) Has been cancelled
Checks / Prek / Check changed files (pull_request) Has been cancelled
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m33s
2026-11-19 20:55:06 +00:00
Compare
chore: Add changelog
All checks were successful
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 8s
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Checks / Prek / Check changed files (pull_request) Successful in 8s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m58s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 10m35s
a33cd95f65
Owner

This is breaking, so I propose to merge it together with ...

In what way is it breaking? from a glance of the diff, it doesn't seem to be

Also, I was thinking it might make sense to add an additional command for listing a users devices?

Clients usually already have a UI for showing other users' devices, so this seems a bit redundant to me

> This is breaking, so I propose to merge it together with ... In what way is it breaking? from a glance of the diff, it doesn't seem to be > Also, I was thinking it might make sense to add an additional command for listing a users devices? Clients usually already have a UI for showing other users' devices, so this seems a bit redundant to me
Author
First-time contributor

I meant more like a technically breaking if one happened to execute that particular admin command on server startup.. but yah, probably doesn't break anything for any actual user

Also, I agree regarding clients displaying that info too, soo I'll just leave it out

I meant more like a *technically* breaking if one happened to execute that particular admin command on server startup.. but yah, probably doesn't break anything for any actual user Also, I agree regarding clients displaying that info too, soo I'll just leave it out
Author
First-time contributor

Also, sidenote, I'm pretty sure the prek lint test workflow failed due to unrelated flakiness.

Would be glad if somebody could rerun it at their own convenience

Also, sidenote, I'm pretty sure the prek lint test workflow failed due to unrelated flakiness. Would be glad if somebody could rerun it at their own convenience
All checks were successful
Checks / Changelog / Check changelog is added (pull_request_target) Successful in 8s
Required
Details
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Checks / Prek / Check changed files (pull_request) Successful in 8s
Required
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m58s
Required
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 10m35s
Required
Details
This pull request is blocked because it's outdated.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'feat/admin-users-selective-lougout:melody-feat/admin-users-selective-lougout'
git switch 'melody-feat/admin-users-selective-lougout'
Sign in to join this conversation.
No reviewers
No milestone
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
continuwuation/continuwuity!2554
No description provided.