WIP: chore: Migrate from chrono to jiff #2563

Draft
melody wants to merge 1 commit from melody/continuwuity:chore/chrono-to-jiff into main
First-time contributor

This pull request migrates the soft-deprecated chrono date/time library to jiff.

Closes: #2547

Pull request checklist:

  • This pull request targets the main branch, and the branch is named something other than
    main.
  • I have written an appropriate pull request title and my description is clear.
  • I understand I am responsible for the contents of this pull request.
  • I have followed the contributing guidelines:
<!-- In order to help reviewers know what your pull request does at a glance, you should ensure that 1. Your PR title is a short, single sentence describing what you changed 2. You have described in more detail what you have changed, why you have changed it, what the intended effect is, and why you think this will be beneficial to the project. If you have made any potentially strange/questionable design choices, but didn't feel they'd benefit from code comments, please don't mention them here - after opening your pull request, go to "files changed", and click on the "+" symbol in the line number gutter, and attach comments to the lines that you think would benefit from some clarification. --> This pull request migrates the soft-deprecated chrono date/time library to jiff. <!-- Example: This pull request allows us to warp through time and space ten times faster than before by double-inverting the warp drive with hyperheated jump fluid, both making the drive faster and more efficient. This resolves the common issue where we have to wait more than 10 milliseconds to engage, use, and disengage the warp drive when travelling between galaxies. --> Closes: #2547 <!-- Fixes: #... --> <!-- Uncomment the above line(s) if your pull request fixes an issue or closes another pull request by superseding it. Replace `#...` with the issue/pr number, such as `#123`. --> **Pull request checklist:** <!-- You need to complete these before your PR can be considered. If you aren't sure about some, feel free to ask for clarification in #dev:continuwuity.org. --> - [x] This pull request targets the `main` branch, and the branch is named something other than `main`. - [x] I have written an appropriate pull request title and my description is clear. - [x] I understand I am responsible for the contents of this pull request. - I have followed the [contributing guidelines][c1]: - [x] My contribution follows the [code style][c2], if applicable. - [x] I ran [pre-commit checks][c1pc] before opening/drafting this pull request. - [ ] I have [tested my contribution][c1t] (or proof-read it for documentation-only changes) myself, if applicable. This includes ensuring code compiles. - [x] My commit messages follow the [commit message format][c1cm] and are descriptive. <!-- Notes on these requirements: - While not required, we encourage you to sign your commits with GPG or SSH to attest the authenticity of your changes. - While we allow LLM-assisted contributions, we do not appreciate contributions that are low quality, which is typical of machine-generated contributions that have not had a lot of love and care from a human. Please do not open a PR if all you have done is asked ChatGPT to tidy up the codebase with a +-100,000 diff. - In the case of code style violations, reviewers may leave review comments/change requests indicating what the ideal change would look like. For example, a reviewer may suggest you lower a log level, or use `match` instead of `if/else` etc. - In the case of code style violations, pre-commit check failures, minor things like typos/spelling errors, and in some cases commit format violations, reviewers may modify your branch directly, typically by making changes and adding a commit. Particularly in the latter case, a reviewer may rebase your commits to squash "spammy" ones (like "fix", "fix", "actually fix"), and reword commit messages that don't satisfy the format. - Pull requests MUST pass the `Checks` CI workflows to be capable of being merged. This can only be bypassed in exceptional circumstances. If your CI flakes, let us know in matrix:r/dev:continuwuity.org. - Pull requests have to be based on the latest `main` commit before being merged. If the main branch changes while you're making your changes, you should make sure you rebase on main before opening a PR. Your branch will be rebased on main before it is merged if it has fallen behind. - We typically only do fast-forward merges, so your entire commit log will be included. Once in main, it's difficult to get out cleanly, so put on your best dress, smile for the cameras! --> [c1]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md [c2]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/docs/development/code_style.mdx [c1pc]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#pre-commit-checks [c1t]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#running-tests-locally [c1cm]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#commit-messages
chore: Migrate from chrono to jiff
Some checks failed
Auto Labeler / Apply labels based on changed files (pull_request_target) Successful in 3s
Checks / Changelog / Check changelog is added (pull_request_target) Failing after 8s
Documentation / Build and Deploy Documentation (pull_request) Has been cancelled
Checks / Prek / Pre-commit & Formatting (pull_request) Has been cancelled
Checks / Prek / Check changed files (pull_request) Has been cancelled
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled
Update flake hashes / update-flake-hashes (pull_request) Has been cancelled
2a37ac853e
Author
First-time contributor

This is WIP because I wanted to clarify a question before marking it as ready:
Jiff doesn't support +%, which is used in one reference of the format function here. It is also one of only two references, the second reference using a very similar format to RFC3339 which could, imo, also just be replaced with a RFC2822 datetime format. What do we do here?

This is WIP because I wanted to clarify a question before marking it as ready: [Jiff doesn't support `+%`](https://docs.rs/jiff/latest/jiff/fmt/strtime/index.html#unsupported), which is used in one reference of the format function [here](https://forgejo.ellis.link/melody/continuwuity/src/commit/2a37ac853ef1152b098de057391f2adf4b21ecbb/src/service/registration_tokens/data.rs#L74). It is also one of only two references, the [second reference](https://forgejo.ellis.link/melody/continuwuity/src/commit/2a37ac853ef1152b098de057391f2adf4b21ecbb/src/admin/query/resolver.rs#L71) using a *very* similar format to RFC3339 which could, imo, also just be replaced with a RFC2822 datetime format. What do we do here?
Owner

Neither of those seem like they're important in any way, so just feel free to replace them with something approximately similar to the existing format, or otherwise sensible

Neither of those seem like they're important in any way, so just feel free to replace them with something approximately similar to the existing format, or otherwise sensible
melody force-pushed chore/chrono-to-jiff from 2a37ac853e
Some checks failed
Auto Labeler / Apply labels based on changed files (pull_request_target) Successful in 3s
Checks / Changelog / Check changelog is added (pull_request_target) Failing after 8s
Documentation / Build and Deploy Documentation (pull_request) Has been cancelled
Checks / Prek / Pre-commit & Formatting (pull_request) Has been cancelled
Checks / Prek / Check changed files (pull_request) Has been cancelled
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled
Update flake hashes / update-flake-hashes (pull_request) Has been cancelled
to deab0705e6
Some checks failed
Checks / Changelog / Check changelog is added (pull_request_target) Failing after 8s
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Checks / Prek / Check changed files (pull_request) Successful in 6s
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m26s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m32s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 12m21s
2026-11-20 22:04:15 +00:00
Compare
@ -73,0 +70,4 @@
.duration_since(SystemTime::UNIX_EPOCH)
.unwrap_or_default()
.as_micros();
let ts = Timestamp::from_microsecond(micros_since_unix.try_into().unwrap_or_default())
Author
First-time contributor

I don't think we'd ever need this amount of precision here, but as this is a very cold codepath I figured we could play it safe. This requires a u128.

I don't think we'd ever need this amount of precision here, but as this is a very cold codepath I figured we could play it safe. This requires a `u128`.
Author
First-time contributor

@nex wrote in #2563 (comment):

Neither of those seem like they're important in any way, so just feel free to replace them with something approximately similar to the existing format, or otherwise sensible

I mean, would RFC2822 be fine with you? I could just drop the whole format() in that case.

@nex wrote in https://forgejo.ellis.link/continuwuation/continuwuity/pulls/2563#issuecomment-40538: > Neither of those seem like they're important in any way, so just feel free to replace them with something approximately similar to the existing format, or otherwise sensible I mean, would RFC2822 be fine with you? I could just drop the whole `format()` in that case.
Owner

Well, RFC2822 was superseded by rfc5322, but yeah sounds fine by me

Well, RFC2822 was superseded by rfc5322, but yeah sounds fine by me
Some checks failed
Checks / Changelog / Check changelog is added (pull_request_target) Failing after 8s
Required
Details
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Checks / Prek / Check changed files (pull_request) Successful in 6s
Required
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 1m26s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m32s
Required
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 12m21s
Required
Details
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'chore/chrono-to-jiff:melody-chore/chrono-to-jiff'
git switch 'melody-chore/chrono-to-jiff'
Sign in to join this conversation.
No reviewers
No milestone
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
continuwuation/continuwuity!2563
No description provided.