continuwuation/continuwuity
9
17
Fork 10
Code Issues 78 Pull requests 9 Projects Releases 16 Packages 1 Activity Actions

config: rocksdb_compaction help was inverted :-) #737

Merged
grinapo merged 1 commit from grinapo/patch-1 into main 2025-04-20 18:49:32 +00:00
Conversation 1 Commits 1 Files changed 2 +6 -6
grinapo commented 2025-04-09 17:18:02 +00:00 (Migrated from github.com)
Copy link

You seem to have replaced disable_rocksdb_compaction with rocksdb_compaction, since the help is blackmailing me never ever ever to set it to true, except true is the default.

I have tried to make it say what you possibly meant.

You seem to have replaced `disable_rocksdb_compaction` with `rocksdb_compaction`, since the help is blackmailing me never ever ever to set it to `true`, except **true is the default**. I have tried to make it say what you possibly meant.
nex added the
Inherited
 label 2025-04-14 23:38:40 +00:00
Jade force-pushed grinapo/patch-1 from 9bc7356165 to d58e2f419f 2025-04-20 18:45:41 +00:00 Compare
Jade force-pushed grinapo/patch-1 from d58e2f419f to 5486dbda24 2025-04-20 18:48:20 +00:00 Compare
Jade approved these changes 2025-04-20 18:49:20 +00:00
Jade left a comment
Owner
Copy link

Looks correct to me.

Looks correct to me.
Jade merged commit 5486dbda24 into main 2025-04-20 18:49:32 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Jade
Labels
Clear labels   
Bug

Something isn't working as intended

  
Cherry-picking

Commits picked from other conduit projects

  
Database

This requires or includes changes to the database

  
Dependencies

Something dependency related

  
Documentation

Improvements or additions to documentation

  
Enhancement

New feature or request

  
Good first issue

Good for newcomers

  
Help wanted

Additional eyes and keyboards are required for this one

  
Inherited

Issues that have been inhereted from the project pre-fork

  
Matrix/Administration

Features pertaining to homeserver administration

  
Matrix/Appservices

Features pertaining to the appservice API

  
Matrix/Auth

Features pertaining to authentication

  
Matrix/Client

Features pertaining to client-to-server interactions

  
Matrix/Core

   
Matrix/Federation

Features pertaining to server-to-server interactions

  
Matrix/MSC

Features pertaining to unstable matrix features

  
Matrix/Media

Features pertaining to media interactions

  
Meta

Related to housekeeping, maintenance, or other repo-meta.

  
Meta/Packaging

Packaging

  
Priority
Blocking
This issue is blocking the next release

  
Priority
High
This issue is very important

  
Priority
Low
This issue is of a rather low priority

  
Security

This item is related to general security

  
Status
Confirmed

  
Status
Duplicate
This issue or pull request already exists

  
Status
Invalid
This issue doesn't seem right

  
Status
Needs Investigation
This issue needs further investigation

  
Wont fix

This will not be worked on

  
old/ci/cd

Ci/CD

Archived

  
old/rust

Pull requests that update Rust code

Archived

No labels
Bug
Cherry-picking
Database
Dependencies
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/Federation
Matrix/MSC
Matrix/Media
Meta
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
Wont fix
old/ci/cd
old/rust
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: continuwuation/continuwuity#737
No description provided.
Delete branch "grinapo/patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?