continuwuation/continuwuity
5
5
Fork 0
Code Issues 66 Pull requests 6 Projects Releases 15 Packages 1 Activity Actions

fix space hierarchy pagination not respecting client-specified limit. #769

Merged
Aranjedeath merged 1 commit from fix-hierarchy-pagination-limit into main 2025-04-17 15:10:08 +00:00
Conversation 1 Commits 1 Files changed 1 +1 -1
Aranjedeath commented 2025-04-17 14:51:44 +00:00
Owner
Copy link
No description provided.
Aranjedeath added 1 commit 2025-04-17 14:51:45 +00:00
fix space hierarchy pagination not respecting client-specified limit.
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Successful in 42s
Details
Documentation / Build and Deploy Documentation (push) Successful in 44s
Details
773c3d457b
Jade approved these changes 2025-04-17 14:54:44 +00:00
Jade left a comment
Owner
Copy link

Looks good!

Looks good!
src/api/client/space.rs
@ -180,3 +180,3 @@
.then_some(PaginationToken {
short_room_ids: next_short_room_ids,
limit: max_depth.try_into().ok()?,
limit: limit.try_into().ok()?,
Jade commented 2025-04-17 14:54:34 +00:00
Owner
Copy link

LGTM! The limit is set to a max of 100 before this function is called, so should be safe.

LGTM! The limit is set to a max of 100 before this function is called, so should be safe.
Aranjedeath merged commit 773c3d457b into main 2025-04-17 15:10:08 +00:00
Aranjedeath deleted branch fix-hierarchy-pagination-limit 2025-04-17 15:10:08 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Jade
Labels
Clear labels   
Bug

Something isn't working as intended

  
Cherry-picking

Commits picked from other conduit projects

  
Dependencies

Something dependency related

  
Documentation

Improvements or additions to documentation

  
Duplicate

This issue or pull request already exists

  
Enhancement

New feature or request

  
Good first issue

Good for newcomers

  
Help wanted

Additional eyes and keyboards are required for this one

  
Inherited

Issues that have been inhereted from the project pre-fork

  
Invalid

This issue doesn't seem right

  
Matrix/Administration

Features pertaining to homeserver administration

  
Matrix/Appservices

Features pertaining to the appservice API

  
Matrix/Auth

Features pertaining to authentication

  
Matrix/Client

Features pertaining to client-to-server interactions

  
Matrix/Federation

Features pertaining to server-to-server interactions

  
Matrix/MSC

Features pertaining to unstable matrix features

  
Matrix/Media

Features pertaining to media interactions

  
Meta

Related to housekeeping, maintenance, or other repo-meta.

  
Performance

Issues related to performance and related improvements

  
Priority
Critical
This issue is of the utmost priority

  
Priority
High
This issue is very important

  
Priority
Low
This issue is of a rather low priority

  
Priority
Medium
This issue is of a medium priority

  
Priority
Unknown
The priority of this issue has not been triaged yet, or cannot be appropriately decided.

  
Security

This item is related to general security

  
Wont fix

This will not be worked on

  
no-priority

   
old/blocked

Issue is blocked on another issue being completed

Archived

  
old/ci/cd

Ci/CD

Archived

  
old/core-matrix

Archived

  
old/database

Database things

Archived

  
old/github_actions

Issue/PR is from GitHub Actions

Archived

  
old/high-priority

Archived

  
old/low-priority

Archived

  
old/medium-priority

Archived

  
old/question

General questions

Archived

  
old/rocksdb

RocksDB database stuff

Archived

  
old/rust

Pull requests that update Rust code

Archived

  
packaging

Packaging

No labels
Bug
Cherry-picking
Dependencies
Documentation
Duplicate
Enhancement
Good first issue
Help wanted
Inherited
Invalid
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Federation
Matrix/MSC
Matrix/Media
Meta
Performance
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Priority
Unknown
Security
Wont fix
no-priority
old/blocked
old/ci/cd
old/core-matrix
old/database
old/github_actions
old/high-priority
old/low-priority
old/medium-priority
old/question
old/rocksdb
old/rust
packaging
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: continuwuation/continuwuity#769
No description provided.
Delete branch "fix-hierarchy-pagination-limit"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?