continuwuation/continuwuity
7
6
Fork 0
Code Issues 59 Pull requests 3 Projects Releases 16 Packages 1 Activity Actions 1

refactor: The update checker has become the announcements checker #780

Merged
Jade merged 1 commit from jade/announcements-checker into main 2025-04-20 20:01:53 +00:00
Conversation 6 Commits 1 Files changed 12 +238 -166
Jade commented 2025-04-20 18:35:44 +00:00
Owner
Copy link

Replaces June's endpoint with a continuwuity endpoint.
Adds a JSON schema.

Closes #89
Closes #760

Note that I haven't tested this, but there aren't any actual logic changes so we should be good.

Replaces June's endpoint with a continuwuity endpoint. Adds a JSON schema. Closes #89 Closes #760 Note that I haven't tested this, but there aren't any actual logic changes so we should be good.
Jade added 1 commit 2025-04-20 18:35:45 +00:00
refactor: The update checker has become the announcements checker
Some checks failed
Release Docker Image / merge (push) Blocked by required conditions
Details
Release Docker Image / define-variables (push) Successful in 12s
Details
Documentation / Build and Deploy Documentation (pull_request) Failing after 9s
Details
Release Docker Image / define-variables (pull_request) Failing after 0s
Details
Release Docker Image / build-image (linux/amd64, linux-amd64) (pull_request) Has been skipped
Details
Release Docker Image / build-image (linux/arm64, linux-arm64) (pull_request) Has been skipped
Details
Release Docker Image / merge (pull_request) Has been skipped
Details
Release Docker Image / build-image (linux/amd64, linux-amd64) (push) Has been cancelled
Details
Release Docker Image / build-image (linux/arm64, linux-arm64) (push) Has been cancelled
Details
ebed4940d2 
Replaces June's endpoint with a continuwuity endpoint.
Adds a JSON schema.

Closes #89
Closes #760
Jade added 1 commit 2025-04-20 18:41:18 +00:00
fixup! refactor: The update checker has become the announcements checker
Some checks failed
Release Docker Image / define-variables (pull_request) Failing after 0s
Details
Release Docker Image / build-image (linux/amd64, linux-amd64) (pull_request) Has been skipped
Details
Release Docker Image / build-image (linux/arm64, linux-arm64) (pull_request) Has been skipped
Details
Release Docker Image / merge (pull_request) Has been skipped
Details
Documentation / Build and Deploy Documentation (pull_request) Successful in 31s
Details
Release Docker Image / define-variables (push) Failing after 1s
Details
Release Docker Image / build-image (linux/amd64, linux-amd64) (push) Has been skipped
Details
Release Docker Image / build-image (linux/arm64, linux-arm64) (push) Has been skipped
Details
Release Docker Image / merge (push) Has been skipped
Details
51f8061608
Jade force-pushed jade/announcements-checker from 51f8061608 to 1e92cfe803 2025-04-20 18:59:39 +00:00 Compare
Jade changed title from refactor: The update checker has become the announcements checker to WIP: refactor: The update checker has become the announcements checker 2025-04-20 19:15:56 +00:00
requested review from Owners 2025-04-20 19:15:56 +00:00
nex commented 2025-04-20 19:45:38 +00:00
Owner
Copy link

Is this ready for review? It's marked as WIP, but you've requested a review

Is this ready for review? It's marked as WIP, but you've requested a review
Jade changed title from WIP: refactor: The update checker has become the announcements checker to refactor: The update checker has become the announcements checker 2025-04-20 19:46:17 +00:00
Jade commented 2025-04-20 19:46:42 +00:00
Author
Owner
Copy link

Oops, accidentally clicked that. Should be ready for review.

Oops, accidentally clicked that. Should be ready for review.
👍 1
nex approved these changes 2025-04-20 19:50:37 +00:00
Dismissed
nex left a comment
Owner
Copy link

mostly good, few questions

mostly good, few questions
conduwuit-example.toml Outdated
@ -119,3 +117,4 @@
# announcements or major updates. This is not an update check endpoint.
#
# This is disabled by default as this is rarely used except for security
# updates or major updates.
nex commented 2025-04-20 19:49:04 +00:00
Owner
Copy link

"This is not an update check endpoint." followed by "This is disabled by default as this is rarely used except for security updates or major updates.".

Also, aren't we enabling this by default?

"This is not an update check endpoint." followed by "This is disabled by default as this is rarely used except for security updates or major updates.". Also, aren't we enabling this by default?
Jade commented 2025-04-20 19:58:56 +00:00
Author
Owner
Copy link

Forgot to enable it by default.

"This is not an update check endpoint." followed by "This is disabled by default as this is rarely used except for security updates or major updates.".

Perhaps better clarified as, "This is disabled by default as this is rarely used except for security [announcements] or major update [announcements] ."

Removed anyway, as the prior text is sufficient and hopefully usage won't be infrequent!

Forgot to enable it by default. > "This is not an update check endpoint." followed by "This is disabled by default as this is rarely used except for security updates or major updates.". Perhaps better clarified as, "This is disabled by default as this is rarely used except for security [announcements] or major update [announcements] ." Removed anyway, as the prior text is sufficient and hopefully usage won't be infrequent!
Jade marked this conversation as resolved
src/core/config/mod.rs Outdated
@ -167,3 +165,4 @@
/// announcements or major updates. This is not an update check endpoint.
///
/// This is disabled by default as this is rarely used except for security
/// updates or major updates.
nex commented 2025-04-20 19:49:50 +00:00
Owner
Copy link

Same comment as conduwuit-example.toml

Same comment as conduwuit-example.toml
Jade marked this conversation as resolved
src/service/announcements/mod.rs Outdated
@ -0,0 +57,4 @@
const CHECK_FOR_ANNOUNCEMENTS_URL: &str =
"https://continuwuity.org/.well-known/continuwuity/announcements";
const CHECK_FOR_ANNOUNCEMENTS_INTERVAL: u64 = 7200; // 2 hours
nex commented 2025-04-20 19:50:19 +00:00
Owner
Copy link

Why 2 hours? This isn't going to be updated frequently, imo every 24 hours will be plenty

Why 2 hours? This isn't going to be updated frequently, imo every 24 hours will be plenty
Jade commented 2025-04-20 19:55:41 +00:00
Author
Owner
Copy link

This was the original value. I didn't reduce it because if we do use it for anything urgent, 24 hours as the max time till someone receives it might be a bit too long. There's no particular harm in a higher check frequency here, I don't think?

This was the original value. I didn't reduce it because if we *do* use it for anything urgent, 24 hours as the max time till someone receives it might be a bit too long. There's no particular harm in a higher check frequency here, I don't think?
nex commented 2025-04-20 19:59:52 +00:00
Owner
Copy link

eh, true. 2 hours is fine then.

eh, true. 2 hours is fine then.
nex marked this conversation as resolved
nex requested changes 2025-04-20 19:50:54 +00:00
Dismissed
nex left a comment
Owner
Copy link

that was not meant to be an approved. I pressed the shiny button

that was not meant to be an approved. I pressed the shiny button
😆 1
Jade added 1 commit 2025-04-20 19:58:55 +00:00
fixup! refactor: The update checker has become the announcements checker
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Failing after 1s
Details
Release Docker Image / define-variables (pull_request) Successful in 2s
Details
Release Docker Image / define-variables (push) Successful in 12s
Details
Release Docker Image / build-image (linux/arm64, linux-arm64) (pull_request) Successful in 23m4s
Details
Release Docker Image / build-image (linux/arm64, linux-arm64) (push) Has been cancelled
Details
Release Docker Image / merge (push) Has been cancelled
Details
Release Docker Image / build-image (linux/amd64, linux-amd64) (push) Has been cancelled
Details
Release Docker Image / build-image (linux/amd64, linux-amd64) (pull_request) Successful in 54m40s
Details
Release Docker Image / merge (pull_request) Successful in 29s
Details
16118a7bd7
nex approved these changes 2025-04-20 20:00:30 +00:00
nex commented 2025-04-20 20:00:42 +00:00
Owner
Copy link

approved for real this time

approved for real this time
Jade force-pushed jade/announcements-checker from 16118a7bd7 to 2d9bdc0979 2025-04-20 20:01:36 +00:00 Compare
Jade merged commit 2d9bdc0979 into main 2025-04-20 20:01:53 +00:00
Jade deleted branch jade/announcements-checker 2025-04-20 20:01:53 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
nex
Labels
Clear labels   
Bug

Something isn't working as intended

  
Cherry-picking

Commits picked from other conduit projects

  
Dependencies

Something dependency related

  
Documentation

Improvements or additions to documentation

  
Duplicate

This issue or pull request already exists

  
Enhancement

New feature or request

  
Good first issue

Good for newcomers

  
Help wanted

Additional eyes and keyboards are required for this one

  
Inherited

Issues that have been inhereted from the project pre-fork

  
Invalid

This issue doesn't seem right

  
Matrix/Administration

Features pertaining to homeserver administration

  
Matrix/Appservices

Features pertaining to the appservice API

  
Matrix/Auth

Features pertaining to authentication

  
Matrix/Client

Features pertaining to client-to-server interactions

  
Matrix/Federation

Features pertaining to server-to-server interactions

  
Matrix/MSC

Features pertaining to unstable matrix features

  
Matrix/Media

Features pertaining to media interactions

  
Meta

Related to housekeeping, maintenance, or other repo-meta.

  
Performance

Issues related to performance and related improvements

  
Priority
Critical
This issue is of the utmost priority

  
Priority
High
This issue is very important

  
Priority
Low
This issue is of a rather low priority

  
Priority
Medium
This issue is of a medium priority

  
Priority
Unknown
The priority of this issue has not been triaged yet, or cannot be appropriately decided.

  
Security

This item is related to general security

  
Wont fix

This will not be worked on

  
no-priority

   
old/blocked

Issue is blocked on another issue being completed

Archived

  
old/ci/cd

Ci/CD

Archived

  
old/core-matrix

Archived

  
old/database

Database things

Archived

  
old/github_actions

Issue/PR is from GitHub Actions

Archived

  
old/high-priority

Archived

  
old/low-priority

Archived

  
old/medium-priority

Archived

  
old/question

General questions

Archived

  
old/rocksdb

RocksDB database stuff

Archived

  
old/rust

Pull requests that update Rust code

Archived

  
packaging

Packaging

No labels
Bug
Cherry-picking
Dependencies
Documentation
Duplicate
Enhancement
Good first issue
Help wanted
Inherited
Invalid
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Federation
Matrix/MSC
Matrix/Media
Meta
Performance
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Priority
Unknown
Security
Wont fix
no-priority
old/blocked
old/ci/cd
old/core-matrix
old/database
old/github_actions
old/high-priority
old/low-priority
old/medium-priority
old/question
old/rocksdb
old/rust
packaging
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: continuwuation/continuwuity#780
No description provided.
Delete branch "jade/announcements-checker"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?