refactor: The update checker has become the announcements checker #780

Jade · 2025-04-20T18:35:44Z

Jade commented

2025-04-20 18:35:44 +00:00

Replaces June's endpoint with a continuwuity endpoint.
Adds a JSON schema.

Closes #89
Closes #760

Note that I haven't tested this, but there aren't any actual logic changes so we should be good.

Replaces June's endpoint with a continuwuity endpoint. Adds a JSON schema. Closes #89 Closes #760 Note that I haven't tested this, but there aren't any actual logic changes so we should be good.

Jade force-pushed jade/announcements-checker from 51f8061608 to 1e92cfe803

2025-04-20 18:59:39 +00:00

Compare

Jade changed title from ~~refactor: The update checker has become the announcements checker~~ to WIP: refactor: The update checker has become the announcements checker

2025-04-20 19:15:56 +00:00

requested review from Owners

2025-04-20 19:15:56 +00:00

nex commented

2025-04-20 19:45:38 +00:00

Is this ready for review? It's marked as WIP, but you've requested a review

Jade changed title from ~~WIP: refactor: The update checker has become the announcements checker~~ to refactor: The update checker has become the announcements checker

2025-04-20 19:46:17 +00:00

Jade commented

2025-04-20 19:46:42 +00:00

Oops, accidentally clicked that. Should be ready for review.

👍 1

nex approved these changes 2025-04-20 19:50:37 +00:00

Dismissed

nex left a comment

mostly good, few questions

conduwuit-example.toml Outdated

					
				@ -119,3 +117,4 @@

				# announcements or major updates. This is not an update check endpoint.

				#

				# This is disabled by default as this is rarely used except for security

				# updates or major updates.

nex commented

2025-04-20 19:49:04 +00:00

"This is not an update check endpoint." followed by "This is disabled by default as this is rarely used except for security updates or major updates.".

Also, aren't we enabling this by default?

"This is not an update check endpoint." followed by "This is disabled by default as this is rarely used except for security updates or major updates.". Also, aren't we enabling this by default?

Jade commented

2025-04-20 19:58:56 +00:00

Forgot to enable it by default.

"This is not an update check endpoint." followed by "This is disabled by default as this is rarely used except for security updates or major updates.".

Perhaps better clarified as, "This is disabled by default as this is rarely used except for security [announcements] or major update [announcements] ."

Removed anyway, as the prior text is sufficient and hopefully usage won't be infrequent!

Forgot to enable it by default. > "This is not an update check endpoint." followed by "This is disabled by default as this is rarely used except for security updates or major updates.". Perhaps better clarified as, "This is disabled by default as this is rarely used except for security [announcements] or major update [announcements] ." Removed anyway, as the prior text is sufficient and hopefully usage won't be infrequent!

Jade marked this conversation as resolved

src/core/config/mod.rs Outdated

					
				@ -167,3 +165,4 @@

					/// announcements or major updates. This is not an update check endpoint.

					///

					/// This is disabled by default as this is rarely used except for security

					/// updates or major updates.

nex commented

2025-04-20 19:49:50 +00:00

Same comment as conduwuit-example.toml

Jade marked this conversation as resolved

src/service/announcements/mod.rs Outdated

					
				@ -0,0 +57,4 @@

				const CHECK_FOR_ANNOUNCEMENTS_URL: &str =

					"https://continuwuity.org/.well-known/continuwuity/announcements";

				const CHECK_FOR_ANNOUNCEMENTS_INTERVAL: u64 = 7200; // 2 hours

nex commented

2025-04-20 19:50:19 +00:00

Why 2 hours? This isn't going to be updated frequently, imo every 24 hours will be plenty

Jade commented

2025-04-20 19:55:41 +00:00

This was the original value. I didn't reduce it because if we do use it for anything urgent, 24 hours as the max time till someone receives it might be a bit too long. There's no particular harm in a higher check frequency here, I don't think?

This was the original value. I didn't reduce it because if we *do* use it for anything urgent, 24 hours as the max time till someone receives it might be a bit too long. There's no particular harm in a higher check frequency here, I don't think?

nex commented

2025-04-20 19:59:52 +00:00

eh, true. 2 hours is fine then.

nex marked this conversation as resolved

nex requested changes 2025-04-20 19:50:54 +00:00

Dismissed

nex left a comment

that was not meant to be an approved. I pressed the shiny button

😆 1

nex approved these changes 2025-04-20 20:00:30 +00:00

nex commented

2025-04-20 20:00:42 +00:00