continuwuation/continuwuity
9
28
Fork 25
Code Issues 89 Pull requests 24 Projects Releases 18 Packages 3 Activity Actions

Fix federated leaves dropping the reason #789

Merged
Jade merged 1 commit from nex/fix-768 into main 2025-04-23 21:46:43 +00:00
Conversation 2 Commits 1 Files changed 1 +8 -1
nex commented 2025-04-23 00:53:53 +00:00
Owner
Copy link

Fixes #768

this small change fixes the issue where leaving a room over federation drops the client-included reason, bringing behavior in line of that of synapse and other implementations.

Fixes #768 this small change fixes the issue where leaving a room over federation drops the client-included reason, bringing behavior in line of that of synapse and other implementations.
Inject reason into federated leave request membership
Some checks failed
Release Docker Image / define-variables (pull_request) Successful in 1s
Details
Release Docker Image / build-image (linux/arm64, linux-arm64) (pull_request) Successful in 20m35s
Details
Release Docker Image / build-image (linux/amd64, linux-amd64) (pull_request) Successful in 58m53s
Details
Release Docker Image / merge (pull_request) Successful in 31s
Details
Documentation / Build and Deploy Documentation (pull_request) Successful in 23s
Details
Release Docker Image / define-variables (push) Successful in 3s
Details
Release Docker Image / build-image (linux/amd64, linux-amd64) (push) Failing after 17m27s
Details
Release Docker Image / build-image (linux/arm64, linux-arm64) (push) Failing after 17m47s
Details
Release Docker Image / merge (push) Has been skipped
Details
b8bfd1c3fa
requested review from Owners 2025-04-23 00:54:12 +00:00
Jade approved these changes 2025-04-23 01:27:35 +00:00
Jade left a comment
Owner
Copy link

Looks good! I was a bit surprised that there's no typing on the leave event, but I guess it is more flexible for other servers.

Looks good! I was a bit surprised that there's no typing on the leave event, but I guess it is more flexible for other servers.
nex commented 2025-04-23 01:33:36 +00:00
Author
Owner
Copy link

The v1 leave is documented in the spec as being a bit flimsy, v2 is meant to be more "consistent", but that's out of scope for this PR

The v1 leave is documented in the spec as being a bit flimsy, v2 is meant to be more "consistent", but that's out of scope for this PR
Jade force-pushed nex/fix-768 from b8bfd1c3fa to 41cf118a24 2025-04-23 21:46:33 +00:00 Compare
Jade merged commit 41cf118a24 into main 2025-04-23 21:46:43 +00:00
nex added this to the 0.5.0 milestone 2025-06-28 20:55:25 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Jade
Labels
Clear labels   
Bug

Something isn't working as intended

  
Cherry-picking

Commits picked from other conduit projects

  
Database

This requires or includes changes to the database

  
Dependencies

Something dependency related

  
Dependencies/Renovate

Automatic dependency upgrades by Renovate

  
Difficulty
Easy
Low difficulty to implement - touches few parts of the codebase, low complexity

  
Difficulty
Hard
High difficulty to implement - touches many parts of the codebase, high complexity

  
Difficulty
Medium
Medium difficulty to implement - touches more parts of the codebase, higher complexity

  
Documentation

Improvements or additions to documentation

  
Enhancement

New feature or request

  
Good first issue

Good for newcomers

  
Help wanted

Additional eyes and keyboards are required for this one

  
Inherited

Issues that have been inhereted from the project pre-fork

  
Matrix/Administration

Features pertaining to homeserver administration

  
Matrix/Appservices

Features pertaining to the appservice API

  
Matrix/Auth

Features pertaining to authentication

  
Matrix/Client

Features pertaining to client-to-server interactions

  
Matrix/Core

   
Matrix/Federation

Features pertaining to server-to-server interactions

  
Matrix/MSC

Features pertaining to unstable matrix features

  
Matrix/Media

Features pertaining to media interactions

  
Meta

Related to housekeeping, maintenance, or other repo-meta.

  
Meta/Packaging

Packaging

  
Priority
Blocking
This issue is blocking the next release

  
Priority
High
This issue is very important

  
Priority
Low
This issue is of a rather low priority

  
Security

This item is related to general security

  
Status
Confirmed

  
Status
Duplicate
This issue or pull request already exists

  
Status
Invalid
This issue doesn't seem right

  
Status
Needs Investigation
This issue needs further investigation

  
To-Merge

   
Wont fix

This will not be worked on

  
old/ci/cd

Ci/CD

Archived

  
old/rust

Pull requests that update Rust code

Archived

No labels
Bug
Cherry-picking
Database
Dependencies
Dependencies/Renovate
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/Federation
Matrix/MSC
Matrix/Media
Meta
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
To-Merge
Wont fix
old/ci/cd
old/rust
Milestone
Clear milestone
No items
No milestone
0.5.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: continuwuation/continuwuity#789
No description provided.
Delete branch "nex/fix-768"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?