continuwuation/continuwuity
8
20
Fork 17
Code Issues 83 Pull requests 7 Projects Releases 17 Packages 1 Activity Actions

feat: HTML default page #801

Merged
Jade merged 6 commits from jade/html-default-page into main 2025-05-04 19:24:23 +00:00
Conversation 2 Commits 6 Files changed 24 +571 -41
Jade commented 2025-04-25 01:50:55 +00:00
Owner
Copy link

TODO:

  • Move logic for calculating metadata from dockerfile to build.rs for more compatibility with different build methods
  • Update Nix to pass the git remote

image

TODO: - [x] Move logic for calculating metadata from dockerfile to build.rs for more compatibility with different build methods - [ ] Update Nix to pass the git remote ![image](/attachments/ac13514d-bc85-4bc6-87d1-8f05391b7bca)
image.png
149 KiB
nex added the
Documentation
Enhancement
 labels 2025-04-27 18:39:07 +00:00
Jade force-pushed jade/html-default-page from 0bc8bfa923 to e1655edd83 2025-04-30 21:31:55 +00:00 Compare
Jade added 1 commit 2025-04-30 23:47:07 +00:00
Jade changed title from WIP: feat: HTML default page to feat: HTML default page 2025-04-30 23:47:41 +00:00
Jade commented 2025-04-30 23:48:32 +00:00
Author
Owner
Copy link

Not sure how to pass the git remote from nix, so going to ignore that, but I've got this into a state I'm happy with for now.

Not sure how to pass the git remote from nix, so going to ignore that, but I've got this into a state I'm happy with for now.
Jade 2025-04-30 23:48:46 +00:00
nex requested changes 2025-04-30 23:59:54 +00:00
src/api/client/message.rs
@ -144,3 +144,3 @@
<&DeviceId>::from(registration.registration.id.as_str())
} else {
panic!("No device_id provided and no appservice registration found, this should be unreachable");
panic!(
nex commented 2025-04-30 23:56:58 +00:00
Owner
Copy link

Is this related to adding a HTML page? feels like it should be in its own PR

Is this related to adding a HTML page? feels like it should be in its own PR
Jade commented 2025-05-01 00:01:09 +00:00
Author
Owner
Copy link

This is just the result of auto formatting, I thought I got this earlier but apparently not 🤷

This is just the result of auto formatting, I thought I got this earlier but apparently not 🤷
nex marked this conversation as resolved
src/web/templates/index.html.j2 Outdated
@ -0,0 +7,4 @@
<p>To get started, you can:</p>
<ul>
<li>Read the <a href="https://continuwuity.org/introduction">documentation</a></li>
<li>Join the <a href="https://continuwuity.org/community">community</a></li>
nex commented 2025-04-30 23:59:11 +00:00
Owner
Copy link

This should probably be a link to the room rather than guidelines

This should probably be a link to the room rather than guidelines
Jade commented 2025-05-01 00:02:09 +00:00
Author
Owner
Copy link

Possibly. The community page has a link to three of the rooms, at least.

Possibly. The community page has a link to three of the rooms, at least.
nex commented 2025-05-01 00:40:19 +00:00
Owner
Copy link

And a lot of words that people won't read to find the room links :^)

And a lot of words that people won't read to find the room links :^)
Jade marked this conversation as resolved
src/web/templates/index.html.j2 Outdated
@ -0,0 +9,4 @@
<li>Read the <a href="https://continuwuity.org/introduction">documentation</a></li>
<li>Join the <a href="https://continuwuity.org/community">community</a></li>
<li>Log in with a <a href="https://matrix.org/ecosystem/clients/">client</a></li>
<li>Ensure <a href="https://federationtester.matrix.org/">federation</a> works</li>
nex commented 2025-04-30 23:59:49 +00:00
Owner
Copy link

would it be possible to append the servername to this to automate the check? i.e. https://federationtester.matrix.org/#{{ config.server_name }}

would it be possible to append the servername to this to automate the check? i.e. `https://federationtester.matrix.org/#{{ config.server_name }}`
Jade commented 2025-05-01 00:05:50 +00:00
Author
Owner
Copy link

Yeah, although it would require some code flow restructuring. Two ways to do this, either we have the router call into the template with the info from the services (faster compile times), or we have the templates depend on the services (probably a more understandable structure)

Yeah, although it would require some code flow restructuring. Two ways to do this, either we have the router call into the template with the info from the services (faster compile times), or we have the templates depend on the services (probably a more understandable structure)
Jade commented 2025-05-01 00:12:07 +00:00
Author
Owner
Copy link

Compile times should be no real impact as long as we don't depend on API, admin, router or main.

Compile times should be no real impact as long as we don't depend on API, admin, router or main.
nex commented 2025-05-01 00:41:47 +00:00
Owner
Copy link

You only compile once, but you read plenty more (metaphorically speaking). although if it adds a stupid amount of time to compile under any circumstance dw about it, it's just a convenience thing

You only compile once, but you read plenty more (metaphorically speaking). although if it adds a stupid amount of time to compile under any circumstance dw about it, it's just a convenience thing
Jade marked this conversation as resolved
Jade force-pushed jade/html-default-page from 843d9cf2ae to e3ae024ed3 2025-05-01 20:23:46 +00:00 Compare
Jade added 1 commit 2025-05-01 20:27:16 +00:00
ci: Fix bad comparison
All checks were successful
Release Docker Image / define-variables (pull_request) Successful in 1s
Details
Documentation / Build and Deploy Documentation (pull_request) Successful in 30s
Details
Release Docker Image / build-image (linux/amd64, linux-amd64) (pull_request) Successful in 17m9s
Details
Release Docker Image / build-image (linux/arm64, linux-arm64) (pull_request) Successful in 17m29s
Details
Release Docker Image / merge (pull_request) Successful in 24s
Details
Documentation / Build and Deploy Documentation (push) Successful in 47s
Details
Release Docker Image / define-variables (push) Successful in 3s
Details
Release Docker Image / build-image (linux/arm64, linux-arm64) (push) Successful in 16m57s
Details
Release Docker Image / build-image (linux/amd64, linux-amd64) (push) Successful in 1h0m42s
Details
Release Docker Image / merge (push) Successful in 31s
Details
d78fc53577
requested review from nex 2025-05-03 15:23:55 +00:00
Jade merged commit d78fc53577 into main 2025-05-04 19:24:23 +00:00
nex added this to the 0.5.0 milestone 2025-06-28 20:54:50 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
nex
Labels
Clear labels   
Bug

Something isn't working as intended

  
Cherry-picking

Commits picked from other conduit projects

  
Database

This requires or includes changes to the database

  
Dependencies

Something dependency related

  
Difficulty
Easy
Low difficulty to implement - touches few parts of the codebase, low complexity

  
Difficulty
Hard
High difficulty to implement - touches many parts of the codebase, high complexity

  
Difficulty
Medium
Medium difficulty to implement - touches more parts of the codebase, higher complexity

  
Documentation

Improvements or additions to documentation

  
Enhancement

New feature or request

  
Good first issue

Good for newcomers

  
Help wanted

Additional eyes and keyboards are required for this one

  
Inherited

Issues that have been inhereted from the project pre-fork

  
Matrix/Administration

Features pertaining to homeserver administration

  
Matrix/Appservices

Features pertaining to the appservice API

  
Matrix/Auth

Features pertaining to authentication

  
Matrix/Client

Features pertaining to client-to-server interactions

  
Matrix/Core

   
Matrix/Federation

Features pertaining to server-to-server interactions

  
Matrix/MSC

Features pertaining to unstable matrix features

  
Matrix/Media

Features pertaining to media interactions

  
Meta

Related to housekeeping, maintenance, or other repo-meta.

  
Meta/Packaging

Packaging

  
Priority
Blocking
This issue is blocking the next release

  
Priority
High
This issue is very important

  
Priority
Low
This issue is of a rather low priority

  
Security

This item is related to general security

  
Status
Confirmed

  
Status
Duplicate
This issue or pull request already exists

  
Status
Invalid
This issue doesn't seem right

  
Status
Needs Investigation
This issue needs further investigation

  
Wont fix

This will not be worked on

  
old/ci/cd

Ci/CD

Archived

  
old/rust

Pull requests that update Rust code

Archived

No labels
Bug
Cherry-picking
Database
Dependencies
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/Federation
Matrix/MSC
Matrix/Media
Meta
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
Wont fix
old/ci/cd
old/rust
Milestone
Clear milestone
No items
No milestone
0.5.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: continuwuation/continuwuity#801
No description provided.
Delete branch "jade/html-default-page"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?