continuwuation/continuwuity
9
17
Fork 10
Code Issues 78 Pull requests 9 Projects Releases 16 Packages 1 Activity Actions 1

chore: Error on missing ID in messages #802

Merged
Jade merged 1 commit from jade/messages-more-strict-validation into main 2025-04-27 17:05:23 +00:00
Conversation 7 Commits 1 Files changed 1 +3 -3
Jade commented 2025-04-25 22:53:47 +00:00
Owner
Copy link

Slight tweak to #757, to help make sure any unexpected behavior here is caught

Slight tweak to https://forgejo.ellis.link/continuwuation/continuwuity/pulls/757, to help make sure any unexpected behavior here is caught
Jade added 1 commit 2025-04-25 22:53:47 +00:00
chore: Error on missing ID in messages
Some checks failed
Release Docker Image / define-variables (push) Successful in 1s
Details
Release Docker Image / define-variables (pull_request) Successful in 1s
Details
Documentation / Build and Deploy Documentation (pull_request) Successful in 33s
Details
Release Docker Image / build-image (linux/amd64, linux-amd64) (push) Successful in 20m27s
Details
Release Docker Image / build-image (linux/arm64, linux-arm64) (push) Successful in 20m14s
Details
Release Docker Image / build-image (linux/arm64, linux-arm64) (pull_request) Successful in 3m27s
Details
Release Docker Image / merge (push) Failing after 46s
Details
Release Docker Image / build-image (linux/amd64, linux-amd64) (pull_request) Successful in 46m58s
Details
Release Docker Image / merge (pull_request) Failing after 45s
Details
fccffbdb65
requested review from nex 2025-04-26 20:55:49 +00:00
Jade commented 2025-04-26 20:56:04 +00:00
Author
Owner
Copy link

@nex Just want to check this doesn't regress your usecase

@nex Just want to check this doesn't regress your usecase
nex commented 2025-04-27 16:02:31 +00:00
Owner
Copy link

@Jade wrote in #802 (comment):

@nex Just want to check this doesn't regress your usecase

Will test now

@Jade wrote in https://forgejo.ellis.link/continuwuation/continuwuity/pulls/802#issuecomment-15555: > @nex Just want to check this doesn't regress your usecase Will test now
nex commented 2025-04-27 16:15:33 +00:00
Owner
Copy link

Compile warning, but it might be unrelated:

   Compiling conduwuit_service v0.5.0-rc.5 (/home/nex/Downloads/continuwuity/src/service)
warning: field `server` is never read
  --> src/service/moderation.rs:13:6
   |
12 | struct Services {
   |        -------- field in this struct
13 |     pub server: Arc<Server>,
   |         ^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

   Compiling conduwuit_api v0.5.0-rc.5 (/home/nex/Downloads/continuwuity/src/api)
warning: `conduwuit_service` (lib) generated 1 warning
Compile warning, but it might be unrelated: ``` Compiling conduwuit_service v0.5.0-rc.5 (/home/nex/Downloads/continuwuity/src/service) warning: field `server` is never read --> src/service/moderation.rs:13:6 | 12 | struct Services { | -------- field in this struct 13 | pub server: Arc<Server>, | ^^^^^^ | = note: `#[warn(dead_code)]` on by default Compiling conduwuit_api v0.5.0-rc.5 (/home/nex/Downloads/continuwuity/src/api) warning: `conduwuit_service` (lib) generated 1 warning ```
Jade commented 2025-04-27 16:16:41 +00:00
Author
Owner
Copy link

Yeah, that's cause I hadn't rebased it to include dcbacb5b78 yet

Yeah, that's cause I hadn't rebased it to include dcbacb5b78ac679ddb17465c9e60042cff4ab3e7 yet
👍 1
Jade commented 2025-04-27 16:35:13 +00:00
Author
Owner
Copy link

Anything in the logs with the string No device_id provided and no appservice registration found, this should be unreachable?

Anything in the logs with the string `No device_id provided and no appservice registration found, this should be unreachable`?
Jade force-pushed jade/messages-more-strict-validation from fccffbdb65 to 1a5ab33852 2025-04-27 16:35:40 +00:00 Compare
nex approved these changes 2025-04-27 16:36:47 +00:00
nex left a comment
Owner
Copy link

Given it a quick test, looks to work fine for the appservice.

Given it a quick test, looks to work fine for the appservice.
nex commented 2025-04-27 16:37:12 +00:00
Owner
Copy link

@Jade wrote in #802 (comment):

Anything in the logs with the string No device_id provided and no appservice registration found, this should be unreachable?

Nope, I just forgot how /messages works 😅

@Jade wrote in https://forgejo.ellis.link/continuwuation/continuwuity/pulls/802#issuecomment-15584: > Anything in the logs with the string `No device_id provided and no appservice registration found, this should be unreachable`? Nope, I just forgot how /messages works 😅
😆 1
Jade merged commit 1a5ab33852 into main 2025-04-27 17:05:23 +00:00
nex added the
Bug
 label 2025-04-27 18:38:45 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
nex
Labels
Clear labels   
Bug

Something isn't working as intended

  
Cherry-picking

Commits picked from other conduit projects

  
Database

This requires or includes changes to the database

  
Dependencies

Something dependency related

  
Documentation

Improvements or additions to documentation

  
Enhancement

New feature or request

  
Good first issue

Good for newcomers

  
Help wanted

Additional eyes and keyboards are required for this one

  
Inherited

Issues that have been inhereted from the project pre-fork

  
Matrix/Administration

Features pertaining to homeserver administration

  
Matrix/Appservices

Features pertaining to the appservice API

  
Matrix/Auth

Features pertaining to authentication

  
Matrix/Client

Features pertaining to client-to-server interactions

  
Matrix/Core

   
Matrix/Federation

Features pertaining to server-to-server interactions

  
Matrix/MSC

Features pertaining to unstable matrix features

  
Matrix/Media

Features pertaining to media interactions

  
Meta

Related to housekeeping, maintenance, or other repo-meta.

  
Meta/Packaging

Packaging

  
Priority
Blocking
This issue is blocking the next release

  
Priority
High
This issue is very important

  
Priority
Low
This issue is of a rather low priority

  
Security

This item is related to general security

  
Status
Confirmed

  
Status
Duplicate
This issue or pull request already exists

  
Status
Invalid
This issue doesn't seem right

  
Status
Needs Investigation
This issue needs further investigation

  
Wont fix

This will not be worked on

  
old/ci/cd

Ci/CD

Archived

  
old/rust

Pull requests that update Rust code

Archived

No labels
Bug
Cherry-picking
Database
Dependencies
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/Federation
Matrix/MSC
Matrix/Media
Meta
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
Wont fix
old/ci/cd
old/rust
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: continuwuation/continuwuity#802
No description provided.
Delete branch "jade/messages-more-strict-validation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?