continuwuation/continuwuity
8
20
Fork 18
Code Issues 82 Pull requests 8 Projects Releases 17 Packages 1 Activity Actions 1

feat: #821 - Options to disable local typing and read receipts #898

Merged
nex merged 3 commits from oddlid/continuwuity:821_disable_local_receipts into main 2025-07-08 13:25:42 +00:00
Conversation 3 Commits 3 Files changed 4 +32 -2
oddlid commented 2025-07-08 10:48:30 +00:00
Contributor
Copy link

First attempt at issue #821 - please review and point out stuff I might have missed.

closes #821

First attempt at issue #821 - please review and point out stuff I might have missed. closes #821
oddlid added 1 commit 2025-07-08 10:48:31 +00:00
feat: #821 - Options to disable local typing and read receipts
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Failing after 0s
Details
Checks / Prefligit / prefligit (pull_request) Successful in 31s
Details
564e7097e6
oddlid changed title from WIP feat: #821 - Options to disable local typing and read receipts to WIP: feat: #821 - Options to disable local typing and read receipts 2025-07-08 10:49:50 +00:00
nex requested changes 2025-07-08 12:25:53 +00:00
Dismissed
nex left a comment
Owner
Copy link

Looks good to me, I just think the new config options' descriptions could use a little clarification.

Looks good to me, I just think the new config options' descriptions could use a little clarification.
src/core/config/mod.rs Outdated
@ -1259,6 +1259,10 @@ pub struct Config {
#[serde(default = "true_fn")]
pub presence_timeout_remote_users: bool,
/// Allow local read receipts
nex commented 2025-07-08 12:25:00 +00:00
Owner
Copy link

Perhaps a mention that disabling local read receipts and typing also disables outgoing, similar to what allow_local_presence + allow_outgoing_presence says.

Perhaps a mention that disabling local read receipts and typing also disables outgoing, similar to what `allow_local_presence` + `allow_outgoing_presence` says.
oddlid commented 2025-07-08 12:47:54 +00:00
Author
Contributor
Copy link

I've updated the doc comments now, for both options.

I've updated the doc comments now, for both options.
src/core/config/mod.rs Outdated
@ -1269,1 +1273,4 @@
/// Allow local typing updates.
#[serde(default = "true_fn")]
pub allow_local_typing: bool,
nex commented 2025-07-08 12:25:44 +00:00
Owner
Copy link

Same comment as allow_local_read_receipts

Same comment as `allow_local_read_receipts`
nex added the
Enhancement
Matrix/Client
 labels 2025-07-08 12:26:08 +00:00
oddlid added 1 commit 2025-07-08 12:46:26 +00:00
feat: #821 - Options to disable local typing and read receipts
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Failing after 0s
Details
Checks / Prefligit / prefligit (pull_request) Successful in 47s
Details
c3c33f47e2
oddlid commented 2025-07-08 12:51:47 +00:00
Author
Contributor
Copy link

I think I've forgotten to run some command that generates the config example. I'll fix that...

I think I've forgotten to run some command that generates the config example. I'll fix that...
oddlid added 1 commit 2025-07-08 12:52:39 +00:00
feat: #821 - Options to disable local typing and read receipts
Some checks failed
Checks / Prefligit / prefligit (pull_request) Successful in 23s
Details
Release Docker Image / define-variables (push) Successful in 2s
Details
Checks / Prefligit / prefligit (push) Successful in 14s
Details
Documentation / Build and Deploy Documentation (pull_request) Failing after 1s
Details
Documentation / Build and Deploy Documentation (push) Successful in 44s
Details
Checks / Rust / Format (push) Successful in 1m0s
Details
Checks / Rust / Clippy (push) Successful in 4m2s
Details
Checks / Rust / Cargo Test (push) Successful in 4m32s
Details
Release Docker Image / build-image (linux/amd64, release, linux-amd64, base) (push) Successful in 10m5s
Details
Release Docker Image / build-image (linux/arm64, release, linux-arm64, base) (push) Successful in 19m6s
Details
Release Docker Image / merge (push) Successful in 27s
Details
13b21b00a9
nex approved these changes 2025-07-08 13:19:13 +00:00
nex left a comment
Owner
Copy link

Thanks for the changes. Un-draft the PR whenever you're ready for merge :)

Thanks for the changes. Un-draft the PR whenever you're ready for merge :)
oddlid changed title from WIP: feat: #821 - Options to disable local typing and read receipts to feat: #821 - Options to disable local typing and read receipts 2025-07-08 13:24:07 +00:00
nex merged commit 13b21b00a9 into main 2025-07-08 13:25:42 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
nex
Labels
Clear labels   
Bug

Something isn't working as intended

  
Cherry-picking

Commits picked from other conduit projects

  
Database

This requires or includes changes to the database

  
Dependencies

Something dependency related

  
Difficulty
Easy
Low difficulty to implement - touches few parts of the codebase, low complexity

  
Difficulty
Hard
High difficulty to implement - touches many parts of the codebase, high complexity

  
Difficulty
Medium
Medium difficulty to implement - touches more parts of the codebase, higher complexity

  
Documentation

Improvements or additions to documentation

  
Enhancement

New feature or request

  
Good first issue

Good for newcomers

  
Help wanted

Additional eyes and keyboards are required for this one

  
Inherited

Issues that have been inhereted from the project pre-fork

  
Matrix/Administration

Features pertaining to homeserver administration

  
Matrix/Appservices

Features pertaining to the appservice API

  
Matrix/Auth

Features pertaining to authentication

  
Matrix/Client

Features pertaining to client-to-server interactions

  
Matrix/Core

   
Matrix/Federation

Features pertaining to server-to-server interactions

  
Matrix/MSC

Features pertaining to unstable matrix features

  
Matrix/Media

Features pertaining to media interactions

  
Meta

Related to housekeeping, maintenance, or other repo-meta.

  
Meta/Packaging

Packaging

  
Priority
Blocking
This issue is blocking the next release

  
Priority
High
This issue is very important

  
Priority
Low
This issue is of a rather low priority

  
Security

This item is related to general security

  
Status
Confirmed

  
Status
Duplicate
This issue or pull request already exists

  
Status
Invalid
This issue doesn't seem right

  
Status
Needs Investigation
This issue needs further investigation

  
Wont fix

This will not be worked on

  
old/ci/cd

Ci/CD

Archived

  
old/rust

Pull requests that update Rust code

Archived

No labels
Bug
Cherry-picking
Database
Dependencies
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/Federation
Matrix/MSC
Matrix/Media
Meta
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
Wont fix
old/ci/cd
old/rust
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: continuwuation/continuwuity#898
No description provided.
Delete branch "oddlid/continuwuity:821_disable_local_receipts"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?