continuwuation/continuwuity
8
20
Fork 18
Code Issues 82 Pull requests 8 Projects Releases 17 Packages 1 Activity Actions 3

WIP: feat: Ask remote servers for individual unknown events #899

Draft
nex wants to merge 1 commit from nex/feat/pins-backfill into main
pull from: nex/feat/pins-backfill
merge into: continuwuation:main
Conversation 2 Commits 1 Files changed 2 +112 -9
nex commented 2025-07-08 16:14:37 +00:00
Owner
Copy link

This change allows us to use /_matrix/federation/v1/get_event/{eventId} to fetch individual events that we may not have. This is similar to backfill, except it only retrieves an event by its ID, rather than fetching history.

This PR also makes use of this by making /_matrix/client/v3/rooms/{roomId}/event/{eventId} endpoint try to fetch the event locally, falling back to a backfill request if it fails. This means users can fetch pins from before they joined, in the event their server doesn't already have them locally.

This change allows us to use [`/_matrix/federation/v1/get_event/{eventId}`](https://spec.matrix.org/unstable/server-server-api/#get_matrixfederationv1eventeventid) to fetch individual events that we may not have. This is similar to backfill, except it only retrieves an event by its ID, rather than fetching history. This PR also makes use of this by making [`/_matrix/client/v3/rooms/{roomId}/event/{eventId}`](https://spec.matrix.org/unstable/client-server-api/#get_matrixclientv3roomsroomideventeventid) endpoint try to fetch the event locally, falling back to a backfill request if it fails. This means users can fetch pins from before they joined, in the event their server doesn't already have them locally.
nex added the
Enhancement
Matrix/Client
Matrix/Federation
 labels 2025-07-08 16:14:37 +00:00
nex added 1 commit 2025-07-08 16:14:37 +00:00
feat: Ask remote servers for individual unknown events
All checks were successful
Release Docker Image / define-variables (push) Successful in 12s
Details
Checks / Prefligit / prefligit (push) Successful in 20s
Details
Checks / Rust / Format (push) Successful in 51s
Details
Checks / Rust / Clippy (push) Successful in 3m32s
Details
Checks / Rust / Cargo Test (push) Successful in 4m57s
Details
Checks / Prefligit / prefligit (pull_request) Successful in 33s
Details
Documentation / Build and Deploy Documentation (pull_request) Successful in 47s
Details
Release Docker Image / build-image (linux/amd64, release, linux-amd64, base) (push) Successful in 13m10s
Details
Release Docker Image / build-image (linux/arm64, release, linux-arm64, base) (push) Successful in 13m28s
Details
Release Docker Image / merge (push) Successful in 31s
Details
89e2faaa8e
nex commented 2025-07-08 16:15:17 +00:00
Author
Owner
Copy link

This looks to cause really weird issues with backfill

This looks to cause really weird issues with backfill
nex changed title from feat: Ask remote servers for individual unknown events to WIP: feat: Ask remote servers for individual unknown events 2025-07-08 16:15:20 +00:00
Jade commented 2025-07-08 16:18:59 +00:00
Owner
Copy link

This should probably skip adding the event to the timeline, and only do that on actual backfill

This should probably skip adding the event to the timeline, and only do that on actual backfill
All checks were successful
Release Docker Image / define-variables (push) Successful in 12s
Details
Checks / Prefligit / prefligit (push) Successful in 20s
Required
Details
Checks / Rust / Format (push) Successful in 51s
Required
Details
Checks / Rust / Clippy (push) Successful in 3m32s
Required
Details
Checks / Rust / Cargo Test (push) Successful in 4m57s
Required
Details
Checks / Prefligit / prefligit (pull_request) Successful in 33s
Required
Details
Documentation / Build and Deploy Documentation (pull_request) Successful in 47s
Details
Release Docker Image / build-image (linux/amd64, release, linux-amd64, base) (push) Successful in 13m10s
Details
Release Docker Image / build-image (linux/arm64, release, linux-arm64, base) (push) Successful in 13m28s
Details
Release Docker Image / merge (push) Successful in 31s
Details
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin nex/feat/pins-backfill:nex/feat/pins-backfill
git checkout nex/feat/pins-backfill
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Bug

Something isn't working as intended

  
Cherry-picking

Commits picked from other conduit projects

  
Database

This requires or includes changes to the database

  
Dependencies

Something dependency related

  
Difficulty
Easy
Low difficulty to implement - touches few parts of the codebase, low complexity

  
Difficulty
Hard
High difficulty to implement - touches many parts of the codebase, high complexity

  
Difficulty
Medium
Medium difficulty to implement - touches more parts of the codebase, higher complexity

  
Documentation

Improvements or additions to documentation

  
Enhancement

New feature or request

  
Good first issue

Good for newcomers

  
Help wanted

Additional eyes and keyboards are required for this one

  
Inherited

Issues that have been inhereted from the project pre-fork

  
Matrix/Administration

Features pertaining to homeserver administration

  
Matrix/Appservices

Features pertaining to the appservice API

  
Matrix/Auth

Features pertaining to authentication

  
Matrix/Client

Features pertaining to client-to-server interactions

  
Matrix/Core

   
Matrix/Federation

Features pertaining to server-to-server interactions

  
Matrix/MSC

Features pertaining to unstable matrix features

  
Matrix/Media

Features pertaining to media interactions

  
Meta

Related to housekeeping, maintenance, or other repo-meta.

  
Meta/Packaging

Packaging

  
Priority
Blocking
This issue is blocking the next release

  
Priority
High
This issue is very important

  
Priority
Low
This issue is of a rather low priority

  
Security

This item is related to general security

  
Status
Confirmed

  
Status
Duplicate
This issue or pull request already exists

  
Status
Invalid
This issue doesn't seem right

  
Status
Needs Investigation
This issue needs further investigation

  
Wont fix

This will not be worked on

  
old/ci/cd

Ci/CD

Archived

  
old/rust

Pull requests that update Rust code

Archived

No labels
Bug
Cherry-picking
Database
Dependencies
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/Federation
Matrix/MSC
Matrix/Media
Meta
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
Wont fix
old/ci/cd
old/rust
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: continuwuation/continuwuity#899
No description provided.
Delete branch "nex/feat/pins-backfill"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?