continuwuation/continuwuity
8
20
Fork 18
Code Issues 82 Pull requests 8 Projects Releases 17 Packages 1 Activity Actions 1

feat: Upload files for admin commands that are too long #902

Merged
nex merged 2 commits from nex/feat/admin-command-files into main 2025-07-09 14:33:10 +00:00
Conversation 2 Commits 2 Files changed 2 +109 -9
nex commented 2025-07-09 14:13:09 +00:00
Owner
Copy link

This closes #304 by uploading a markdown file when the generated output is too large.

It does this by checking if the expected output size would exceed 60KiB (allowing for a 4KiB wiggle room for the rest of the PDU fluff) and if so, converting the output to a file and sending that instead.

image

This technically has some edge-cases where the content size might be under 60KiB, but the PDU size grows to over 64KiB, causing the error again, but I can't think of a way to easily reproduce that, and handing those cases is more work than doing this.

This closes #304 by uploading a markdown file when the generated output is too large. It does this by checking if the expected output size would exceed 60KiB (allowing for a 4KiB wiggle room for the rest of the PDU fluff) and if so, converting the output to a file and sending that instead. ![image](/attachments/d8bb7e22-f1c2-4465-9845-be811c43c336) This *technically* has some edge-cases where the content size might be under 60KiB, but the PDU size grows to over 64KiB, causing the error again, but I can't think of a way to easily reproduce that, and handing those cases is more work than doing this.
image.png
21 KiB
nex added the
Enhancement
Matrix/Administration
 labels 2025-07-09 14:13:09 +00:00
nex added 1 commit 2025-07-09 14:13:09 +00:00
feat(902): Upload files for admin commands that are too long
Some checks failed
Release Docker Image / merge (push) Blocked by required conditions
Details
Release Docker Image / define-variables (push) Successful in 2s
Details
Checks / Prefligit / prefligit (push) Successful in 34s
Details
Checks / Rust / Format (push) Successful in 38s
Details
Documentation / Build and Deploy Documentation (pull_request) Successful in 38s
Details
Checks / Rust / Cargo Test (push) Failing after 1m16s
Details
Checks / Prefligit / prefligit (pull_request) Successful in 19s
Details
Checks / Rust / Clippy (push) Failing after 2m27s
Details
Release Docker Image / build-image (linux/amd64, release, linux-amd64, base) (push) Successful in 10m9s
Details
Release Docker Image / build-image (linux/arm64, release, linux-arm64, base) (push) Has been cancelled
Details
7b60f5368d
requested reviews from Jade, Owners 2025-07-09 14:16:00 +00:00
nex reviewed 2025-07-09 14:17:20 +00:00
src/service/admin/grant.rs
@ -194,3 +194,2 @@
| Ok(event) if !matches!(event.membership, Invite | Knock | Join) =>
return Err!("Cannot revoke {user_id} in membership state {:?}.", event.membership),
| Ok(event) if !matches!(event.membership, Invite | Knock | Join) => {
nex commented 2025-07-09 14:17:20 +00:00
Author
Owner
Copy link

clippy or cargo fmt did this, not sure why - can remove from PR if needed

clippy or cargo fmt did this, not sure why - can remove from PR if needed
Jade commented 2025-07-09 14:18:26 +00:00
Owner
Copy link

It's fine

It's fine
👍 1
Jade marked this conversation as resolved
Jade approved these changes 2025-07-09 14:20:25 +00:00
nex added 1 commit 2025-07-09 14:28:41 +00:00
style(902): Fix clippy complaining about cast
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Successful in 37s
Details
Checks / Prefligit / prefligit (pull_request) Successful in 22s
Details
Release Docker Image / define-variables (push) Successful in 7s
Details
Checks / Prefligit / prefligit (push) Successful in 20s
Details
Documentation / Build and Deploy Documentation (push) Successful in 43s
Details
Checks / Rust / Format (push) Successful in 55s
Details
Checks / Rust / Clippy (push) Successful in 4m26s
Details
Checks / Rust / Cargo Test (push) Successful in 5m12s
Details
Release Docker Image / build-image (linux/amd64, release, linux-amd64, base) (push) Successful in 13m43s
Details
Release Docker Image / build-image (linux/arm64, release, linux-arm64, base) (push) Successful in 12m18s
Details
Release Docker Image / merge (push) Successful in 26s
Details
ce84c46459
nex scheduled this pull request to auto merge when all checks succeed 2025-07-09 14:29:23 +00:00
nex merged commit ce84c46459 into main 2025-07-09 14:33:10 +00:00
nex deleted branch nex/feat/admin-command-files 2025-07-09 14:33:11 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Jade
Labels
Clear labels   
Bug

Something isn't working as intended

  
Cherry-picking

Commits picked from other conduit projects

  
Database

This requires or includes changes to the database

  
Dependencies

Something dependency related

  
Difficulty
Easy
Low difficulty to implement - touches few parts of the codebase, low complexity

  
Difficulty
Hard
High difficulty to implement - touches many parts of the codebase, high complexity

  
Difficulty
Medium
Medium difficulty to implement - touches more parts of the codebase, higher complexity

  
Documentation

Improvements or additions to documentation

  
Enhancement

New feature or request

  
Good first issue

Good for newcomers

  
Help wanted

Additional eyes and keyboards are required for this one

  
Inherited

Issues that have been inhereted from the project pre-fork

  
Matrix/Administration

Features pertaining to homeserver administration

  
Matrix/Appservices

Features pertaining to the appservice API

  
Matrix/Auth

Features pertaining to authentication

  
Matrix/Client

Features pertaining to client-to-server interactions

  
Matrix/Core

   
Matrix/Federation

Features pertaining to server-to-server interactions

  
Matrix/MSC

Features pertaining to unstable matrix features

  
Matrix/Media

Features pertaining to media interactions

  
Meta

Related to housekeeping, maintenance, or other repo-meta.

  
Meta/Packaging

Packaging

  
Priority
Blocking
This issue is blocking the next release

  
Priority
High
This issue is very important

  
Priority
Low
This issue is of a rather low priority

  
Security

This item is related to general security

  
Status
Confirmed

  
Status
Duplicate
This issue or pull request already exists

  
Status
Invalid
This issue doesn't seem right

  
Status
Needs Investigation
This issue needs further investigation

  
Wont fix

This will not be worked on

  
old/ci/cd

Ci/CD

Archived

  
old/rust

Pull requests that update Rust code

Archived

No labels
Bug
Cherry-picking
Database
Dependencies
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/Federation
Matrix/MSC
Matrix/Media
Meta
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
Wont fix
old/ci/cd
old/rust
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: continuwuation/continuwuity#902
No description provided.
Delete branch "nex/feat/admin-command-files"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?