continuwuation/continuwuity
8
20
Fork 18
Code Issues 82 Pull requests 8 Projects Releases 17 Packages 1 Activity Actions 3

refactor: Migrate std mutexes to parking_lot #908

Merged
Jade merged 8 commits from jade/parking_lot into main 2025-07-20 15:41:25 +00:00
Conversation 0 Commits 8 Files changed 43 +413 -359
Jade commented 2025-07-20 00:46:16 +00:00
Owner
Copy link

What we're looking for:

  • Deadlocks might be detected (Shouldn't be anything that triggers them now, but appservice EDUs used to trigger something
  • Performance improvements from less memory and hardware lock elision

My whole with_lock api might be redundant for sync locks with unlocked. Although that has slightly different semantics (&mut rather than just &)
Code style wise we make it clear that these are synchronous primitives.

What we're looking for: - Deadlocks might be detected (Shouldn't be anything that triggers them now, but appservice EDUs used to trigger *something* - Performance improvements from less memory and hardware lock elision My whole with_lock api might be redundant for sync locks with [unlocked](https://docs.rs/lock_api/0.4.13/lock_api/struct.MutexGuard.html#method.unlocked). Although that has slightly different semantics (&mut rather than just &) Code style wise we make it clear that these are synchronous primitives.
Jade added 8 commits 2025-07-20 00:46:17 +00:00
chore: Disable direnv's nix flake interfering with cargo cache
All checks were successful
Release Docker Image / define-variables (push) Successful in 4s
Details
Checks / Prefligit / prefligit (push) Successful in 35s
Details
Checks / Rust / Format (push) Successful in 44s
Details
Checks / Rust / Clippy (push) Successful in 4m15s
Details
Checks / Rust / Cargo Test (push) Successful in 5m8s
Details
Release Docker Image / build-image (linux/arm64, release, linux-arm64, base) (push) Successful in 13m18s
Details
Release Docker Image / build-image (linux/amd64, release, linux-amd64, base) (push) Successful in 13m51s
Details
Release Docker Image / merge (push) Successful in 36s
Details
Checks / Prefligit / prefligit (pull_request) Successful in 34s
Details
Documentation / Build and Deploy Documentation (pull_request) Successful in 45s
Details
394382884d
Jade force-pushed jade/parking_lot from 394382884d to 95610499c7 2025-07-20 15:36:12 +00:00 Compare
Jade scheduled this pull request to auto merge when all checks succeed 2025-07-20 15:36:27 +00:00
Jade merged commit 95610499c7 into main 2025-07-20 15:41:25 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Bug

Something isn't working as intended

  
Cherry-picking

Commits picked from other conduit projects

  
Database

This requires or includes changes to the database

  
Dependencies

Something dependency related

  
Difficulty
Easy
Low difficulty to implement - touches few parts of the codebase, low complexity

  
Difficulty
Hard
High difficulty to implement - touches many parts of the codebase, high complexity

  
Difficulty
Medium
Medium difficulty to implement - touches more parts of the codebase, higher complexity

  
Documentation

Improvements or additions to documentation

  
Enhancement

New feature or request

  
Good first issue

Good for newcomers

  
Help wanted

Additional eyes and keyboards are required for this one

  
Inherited

Issues that have been inhereted from the project pre-fork

  
Matrix/Administration

Features pertaining to homeserver administration

  
Matrix/Appservices

Features pertaining to the appservice API

  
Matrix/Auth

Features pertaining to authentication

  
Matrix/Client

Features pertaining to client-to-server interactions

  
Matrix/Core

   
Matrix/Federation

Features pertaining to server-to-server interactions

  
Matrix/MSC

Features pertaining to unstable matrix features

  
Matrix/Media

Features pertaining to media interactions

  
Meta

Related to housekeeping, maintenance, or other repo-meta.

  
Meta/Packaging

Packaging

  
Priority
Blocking
This issue is blocking the next release

  
Priority
High
This issue is very important

  
Priority
Low
This issue is of a rather low priority

  
Security

This item is related to general security

  
Status
Confirmed

  
Status
Duplicate
This issue or pull request already exists

  
Status
Invalid
This issue doesn't seem right

  
Status
Needs Investigation
This issue needs further investigation

  
Wont fix

This will not be worked on

  
old/ci/cd

Ci/CD

Archived

  
old/rust

Pull requests that update Rust code

Archived

No labels
Bug
Cherry-picking
Database
Dependencies
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/Federation
Matrix/MSC
Matrix/Media
Meta
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
Wont fix
old/ci/cd
old/rust
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: continuwuation/continuwuity#908
No description provided.
Delete branch "jade/parking_lot"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?