continuwuation/continuwuity
9
20
Fork 18
Code Issues 82 Pull requests 8 Projects Releases 17 Packages 1 Activity Actions 5

introduce federation connection timeout setting #909

Merged
Jade merged 2 commits from rooot/continuwuity:federation-conn-timeout into main 2025-07-20 14:57:55 +00:00
Conversation 6 Commits 2 Files changed 3 +25
rooot commented 2025-07-20 01:22:36 +00:00
Contributor
Copy link

introduces a new setting to separate federation connection timeouts from the rest

fixes #906

introduces a new setting to separate federation connection timeouts from the rest fixes #906
rooot added 1 commit 2025-07-20 01:22:36 +00:00
feat(config): introduce federation connection timeout setting
Some checks are pending
Documentation / Build and Deploy Documentation (pull_request) Blocked by required conditions
Details
Checks / Prefligit / prefligit (pull_request) Blocked by required conditions
Details
5399ac97f2 
fixes #906

Signed-off-by: rooot <hey@rooot.gay>
Jade reviewed 2025-07-20 01:26:05 +00:00
src/core/config/mod.rs Outdated
@ -415,0 +415,4 @@
/// Federation client connection timeout (seconds). You should not set this
/// to high values, as dead homeservers can significantly slow down federation,
/// specifically key retrieval, which will take roughly the amount of time
/// you configure here given that a homeserver doesn't respond.
Jade commented 2025-07-20 01:26:05 +00:00
Owner
Copy link

Might want to mention the client timeout issue

Might want to mention the client timeout issue
rooot commented 2025-07-20 01:27:59 +00:00
Author
Contributor
Copy link

something like "This will cause any sane client to time out /keys/query, causing E2EE and device verification to fail"?

something like "This will cause any sane client to time out /keys/query, causing E2EE and device verification to fail"?
Jade commented 2025-07-20 01:31:38 +00:00
Owner
Copy link

This will cause most clients to time out /keys/query, causing E2EE and device verification to fail

(Probably comes under https://continuwuity.org/development/code_style#inclusivity-and-diversity-guidelines)

> This will cause most clients to time out /keys/query, causing E2EE and device verification to fail (Probably comes under https://continuwuity.org/development/code_style#inclusivity-and-diversity-guidelines)
rooot commented 2025-07-20 01:37:59 +00:00
Author
Contributor
Copy link

im gonna be honest it didn't occur to me in the slightest that the term "sane clients" would be considered ableist language ^^
i guess "This will cause most clients to time out /keys/query, causing E2EE and device verification to fail" would be better?

im gonna be honest it didn't occur to me in the slightest that the term "sane clients" would be considered ableist language ^^ i guess "This will cause most clients to time out /keys/query, causing E2EE and device verification to fail" would be better?
rooot commented 2025-07-20 14:42:08 +00:00
Author
Contributor
Copy link

oh i literally just realized that i came up with the exact same notice, i thought you were quoting, my bad lmao

oh i literally just realized that i came up with the exact same notice, i thought you were quoting, my bad lmao
😆 1
rooot marked this conversation as resolved
rooot added 1 commit 2025-07-20 14:45:13 +00:00
docs(config): warn about federation key query timeout caveat
Some checks are pending
Documentation / Build and Deploy Documentation (pull_request) Blocked by required conditions
Details
Checks / Prefligit / prefligit (pull_request) Blocked by required conditions
Details
1d5c3e1cf3 
Signed-off-by: rooot <hey@rooot.gay>
rooot force-pushed federation-conn-timeout from 1d5c3e1cf3 to 811623adb8 2025-07-20 14:46:26 +00:00 Compare
rooot commented 2025-07-20 14:49:49 +00:00
Author
Contributor
Copy link

(forgot to run cargo build before committing the docs change, wasn't worth adding another commit to the history for)

(forgot to run cargo build before committing the docs change, wasn't worth adding another commit to the history for)
Jade approved these changes 2025-07-20 14:57:01 +00:00
Jade merged commit 811623adb8 into main 2025-07-20 14:57:55 +00:00
Jade commented 2025-07-20 15:10:29 +00:00
Owner
Copy link

Ahh dammit the formatting was wrong

Ahh dammit the formatting was wrong
rooot commented 2025-07-20 15:14:10 +00:00
Author
Contributor
Copy link

oops dangit

oops dangit
Jade commented 2025-07-20 15:28:22 +00:00
Owner
Copy link

editing the branch protection rules to force push to main 😗🎶

editing the branch protection rules to force push to main 😗🎶
Sign in to join this conversation.
Reviewers
No reviewers
Jade
Labels
Clear labels   
Bug

Something isn't working as intended

  
Cherry-picking

Commits picked from other conduit projects

  
Database

This requires or includes changes to the database

  
Dependencies

Something dependency related

  
Difficulty
Easy
Low difficulty to implement - touches few parts of the codebase, low complexity

  
Difficulty
Hard
High difficulty to implement - touches many parts of the codebase, high complexity

  
Difficulty
Medium
Medium difficulty to implement - touches more parts of the codebase, higher complexity

  
Documentation

Improvements or additions to documentation

  
Enhancement

New feature or request

  
Good first issue

Good for newcomers

  
Help wanted

Additional eyes and keyboards are required for this one

  
Inherited

Issues that have been inhereted from the project pre-fork

  
Matrix/Administration

Features pertaining to homeserver administration

  
Matrix/Appservices

Features pertaining to the appservice API

  
Matrix/Auth

Features pertaining to authentication

  
Matrix/Client

Features pertaining to client-to-server interactions

  
Matrix/Core

   
Matrix/Federation

Features pertaining to server-to-server interactions

  
Matrix/MSC

Features pertaining to unstable matrix features

  
Matrix/Media

Features pertaining to media interactions

  
Meta

Related to housekeeping, maintenance, or other repo-meta.

  
Meta/Packaging

Packaging

  
Priority
Blocking
This issue is blocking the next release

  
Priority
High
This issue is very important

  
Priority
Low
This issue is of a rather low priority

  
Security

This item is related to general security

  
Status
Confirmed

  
Status
Duplicate
This issue or pull request already exists

  
Status
Invalid
This issue doesn't seem right

  
Status
Needs Investigation
This issue needs further investigation

  
Wont fix

This will not be worked on

  
old/ci/cd

Ci/CD

Archived

  
old/rust

Pull requests that update Rust code

Archived

No labels
Bug
Cherry-picking
Database
Dependencies
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/Federation
Matrix/MSC
Matrix/Media
Meta
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
Wont fix
old/ci/cd
old/rust
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: continuwuation/continuwuity#909
No description provided.
Delete branch "rooot/continuwuity:federation-conn-timeout"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?