continuwuation/continuwuity
continuwuation/continuwuity
11
31
Fork 29
Code Issues 94 Pull requests 21 Releases 19 Packages 4 Activity Actions 1

WIP: Fix appservice user creation (fixes #813) #918

Closed
tcpipuk wants to merge 2 commits from fix-813-appservice-user-creation into main
pull from: fix-813-appservice-user-creation
merge into: continuwuation:main
Conversation 1 Commits 2 Files changed 2 +19 -1
tcpipuk commented 2025-08-04 19:58:09 +00:00
Owner
Copy link

This PR fixes issue #813 where appservice users were not being created, preventing appservices from functioning correctly:

  • Creates the appservice user (sender_localpart) during initial registration
  • Also creates users during authentication to handle existing appservices registered before this fix

The issue was that when an appservice registered, the corresponding user account for the sender_localpart was never created, which prevented:

  • Direct messages to the appservice bot user
  • The appservice from properly acting as its designated user

The fix should ensure that missing user accounts are created both:

  1. During initial appservice registration (for new appservices)
  2. During authentication (for existing appservices, so fixing them automatically)
This PR fixes issue #813 where appservice users were not being created, preventing appservices from functioning correctly: - Creates the appservice user (sender_localpart) during initial registration - Also creates users during authentication to handle existing appservices registered before this fix The issue was that when an appservice registered, the corresponding user account for the `sender_localpart` was never created, which prevented: - Direct messages to the appservice bot user - The appservice from properly acting as its designated user The fix should ensure that missing user accounts are created both: 1. During initial appservice registration (for new appservices) 2. During authentication (for existing appservices, so fixing them automatically)
tcpipuk self-assigned this 2025-08-04 19:58:09 +00:00
fix(appservice): Create appservice user on registration
All checks were successful
Checks / Prefligit / prefligit (push) Successful in 26s
Details
Checks / Rust / Format (push) Successful in 57s
Details
Checks / Rust / Clippy (push) Successful in 4m26s
Details
Checks / Rust / Cargo Test (push) Successful in 4m52s
Details
15ee7559ea 
Fixes #813 where appservice users were not being created when the
appservice was registered, causing bridges like mautrix-telegram
to fail on startup.

The fix creates the appservice's sender_localpart user if it doesn't
already exist during the registration process, matching the expected
Matrix appservice behaviour.
fix(appservice): Create user on authentication for existing appservices
All checks were successful
Release Docker Image / define-variables (push) Successful in 3s
Details
Checks / Prefligit / prefligit (push) Successful in 14s
Details
Checks / Rust / Format (push) Successful in 39s
Details
Checks / Rust / Clippy (push) Successful in 4m8s
Details
Checks / Rust / Cargo Test (push) Successful in 4m50s
Details
Release Docker Image / build-image (linux/amd64, release, linux-amd64, base) (push) Successful in 13m22s
Details
Release Docker Image / build-image (linux/arm64, release, linux-arm64, base) (push) Successful in 13m56s
Details
Release Docker Image / merge (push) Successful in 21s
Details
Checks / Prefligit / prefligit (pull_request) Successful in 14s
Details
Documentation / Build and Deploy Documentation (pull_request) Successful in 36s
Details
3e68b67562 
Ensures appservice users are created during authentication requests,
fixing the issue for appservices registered before the initial fix.
This allows existing appservices to work without re-registration.
Jade requested changes 2025-08-05 14:02:51 +00:00
src/api/router/auth.rs
@ -220,6 +220,10 @@ async fn auth_appservice(
return Err!(Request(Exclusive("User is not in namespace.")));
}
if !services.users.exists(&user_id).await {
Jade commented 2025-08-05 14:00:28 +00:00
Owner
Copy link

This would create for any user in the regex, not sure we need to do that - I think the issue was the account in sender_localpart? Ignore me if I'm wrong here

This would create for any user in the regex, not sure we need to do that - I think the issue was the account in `sender_localpart`? Ignore me if I'm wrong here
Jade commented 2025-08-05 14:02:48 +00:00
Owner
Copy link

If it is what needs to happen, then it should only happen for exclusive namespaces to stop, e.g. doublepuppetting from accidentally creating accounts.

If it *is* what needs to happen, then it should only happen for exclusive namespaces to stop, e.g. doublepuppetting from accidentally creating accounts.
tcpipuk commented 2025-08-10 11:18:37 +00:00
Author
Owner
Copy link

I completely forgot to target just the appservice's localpart for auth here, yeah. I'm just consolidating a few commits into my tom/fixes branch to test them all in one build, and will solve this in there.

I completely forgot to target just the appservice's localpart for auth here, yeah. I'm just consolidating a few commits into my `tom/fixes` branch to test them all in one build, and will solve this in there.
tcpipuk closed this pull request 2025-08-10 11:05:42 +00:00
nex added this to the v0.5.0-rc.8 milestone 2025-08-16 16:00:38 +00:00
All checks were successful
Release Docker Image / define-variables (push) Successful in 3s
Details
Checks / Prefligit / prefligit (push) Successful in 14s
Required
Details
Checks / Rust / Format (push) Successful in 39s
Required
Details
Checks / Rust / Clippy (push) Successful in 4m8s
Required
Details
Checks / Rust / Cargo Test (push) Successful in 4m50s
Required
Details
Release Docker Image / build-image (linux/amd64, release, linux-amd64, base) (push) Successful in 13m22s
Details
Release Docker Image / build-image (linux/arm64, release, linux-arm64, base) (push) Successful in 13m56s
Details
Release Docker Image / merge (push) Successful in 21s
Details
Checks / Prefligit / prefligit (pull_request) Successful in 14s
Required
Details
Documentation / Build and Deploy Documentation (pull_request) Successful in 36s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Jade
Labels
Clear labels   
Bug

Something isn't working as intended

  
Cherry-picking

Commits picked from other conduit projects

  
Database

This requires or includes changes to the database

  
Dependencies

Something dependency related

  
Dependencies/Renovate

Automatic dependency upgrades by Renovate

  
Difficulty
Easy
Low difficulty to implement - touches few parts of the codebase, low complexity

  
Difficulty
Hard
High difficulty to implement - touches many parts of the codebase, high complexity

  
Difficulty
Medium
Medium difficulty to implement - touches more parts of the codebase, higher complexity

  
Documentation

Improvements or additions to documentation

  
Enhancement

New feature or request

  
Good first issue

Good for newcomers

  
Help wanted

Additional eyes and keyboards are required for this one

  
Inherited

Issues that have been inhereted from the project pre-fork

  
Matrix/Administration

Features pertaining to homeserver administration

  
Matrix/Appservices

Features pertaining to the appservice API

  
Matrix/Auth

Features pertaining to authentication

  
Matrix/Client

Features pertaining to client-to-server interactions

  
Matrix/Core

Issues relating to core matrix functionality, such as state resolution and PDU formats

  
Matrix/Federation

Features pertaining to server-to-server interactions

  
Matrix/Hydra

Issues related to room version 12 and related changes (temporary label)

  
Matrix/MSC

Features pertaining to unstable matrix features

  
Matrix/Media

Features pertaining to media interactions

  
Meta

Related to housekeeping, maintenance, or other repo-meta.

  
Meta/CI

Issues related to CI changes

  
Meta/Packaging

Packaging

  
Priority
Blocking
This issue is blocking the next release

  
Priority
High
This issue is very important

  
Priority
Low
This issue is of a rather low priority

  
Security

This item is related to general security

  
Status/Blocked

This pull request or issue is currently blocked from being merged/closed

  
Status
Confirmed
This issue has enough information and is confirmed

  
Status
Duplicate
This issue or pull request already exists

  
Status
Invalid
This issue doesn't seem right

  
Status
Needs Investigation
This issue needs further investigation

  
To-Merge

   
Wont fix

This will not be worked on

  
old/ci/cd

Ci/CD

Archived

  
old/rust

Pull requests that update Rust code

Archived

No labels
Bug
Cherry-picking
Database
Dependencies
Dependencies/Renovate
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/Federation
Matrix/Hydra
Matrix/MSC
Matrix/Media
Meta
Meta/CI
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status/Blocked
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
To-Merge
Wont fix
old/ci/cd
old/rust
Milestone
Clear milestone
No items
No milestone
v0.5.0-rc.8
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
tcpipuk
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
continuwuation/continuwuity!918
No description provided.