continuwuation/continuwuity
9
28
Fork 25
Code Issues 89 Pull requests 23 Projects Releases 18 Packages 3 Activity Actions

fix: Drop fake room v2 support #926

Merged
nex merged 1 commit from nex/drop-v2 into main 2025-08-16 15:32:19 +00:00
Conversation 1 Commits 1 Files changed 1 +1 -1
nex commented 2025-08-16 15:24:03 +00:00
Owner
Copy link

We never supported v2 rooms as far as I know, and have only ever non-technically claimed to unstable support v3-5 - we however permit the usage of v2 rooms, but decide that we're going to inject v3 events into them? which is very wrong and might break the five total v2 rooms that exist in the wild.
This change prevents us advertising support for v2 and as such prevents joins and creates for this version.

We never supported v2 rooms as far as I know, and have only ever non-technically claimed to unstable support v3-5 - we however permit the usage of v2 rooms, but decide that we're going to inject v3 events into them? which is very wrong and might break the five total v2 rooms that exist in the wild. This change prevents us advertising support for v2 and as such prevents joins and creates for this version.
😆 1
fix: Drop fake room v2 support
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Successful in 39s
Details
Checks / Prefligit / prefligit (pull_request) Successful in 14s
Details
Documentation / Build and Deploy Documentation (push) Successful in 52s
Details
Release Docker Image / define-variables (push) Successful in 43s
Details
Checks / Prefligit / prefligit (push) Successful in 58s
Details
Checks / Rust / Format (push) Successful in 57s
Details
Checks / Rust / Clippy (push) Successful in 3m21s
Details
Checks / Rust / Cargo Test (push) Successful in 3m36s
Details
Release Docker Image / build-image (linux/arm64, release, linux-arm64, base) (push) Successful in 14m6s
Details
Release Docker Image / build-image (linux/amd64, release, linux-amd64, base) (push) Successful in 15m52s
Details
Release Docker Image / merge (push) Successful in 21s
Details
54acd07555
nex commented 2025-08-16 15:24:53 +00:00
Author
Owner
Copy link

Skipping review process, this PR does not change functionality, only (incorrectly) advertised support

Skipping review process, this PR does not change functionality, only (incorrectly) advertised support
nex scheduled this pull request to auto merge when all checks succeed 2025-08-16 15:25:00 +00:00
nex merged commit 54acd07555 into main 2025-08-16 15:32:19 +00:00
nex deleted branch nex/drop-v2 2025-08-16 15:32:19 +00:00
nex added this to the v0.5.0-rc.8 milestone 2025-08-16 16:00:14 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Bug

Something isn't working as intended

  
Cherry-picking

Commits picked from other conduit projects

  
Database

This requires or includes changes to the database

  
Dependencies

Something dependency related

  
Dependencies/Renovate

Automatic dependency upgrades by Renovate

  
Difficulty
Easy
Low difficulty to implement - touches few parts of the codebase, low complexity

  
Difficulty
Hard
High difficulty to implement - touches many parts of the codebase, high complexity

  
Difficulty
Medium
Medium difficulty to implement - touches more parts of the codebase, higher complexity

  
Documentation

Improvements or additions to documentation

  
Enhancement

New feature or request

  
Good first issue

Good for newcomers

  
Help wanted

Additional eyes and keyboards are required for this one

  
Inherited

Issues that have been inhereted from the project pre-fork

  
Matrix/Administration

Features pertaining to homeserver administration

  
Matrix/Appservices

Features pertaining to the appservice API

  
Matrix/Auth

Features pertaining to authentication

  
Matrix/Client

Features pertaining to client-to-server interactions

  
Matrix/Core

Issues relating to core matrix functionality, such as state resolution and PDU formats

  
Matrix/Federation

Features pertaining to server-to-server interactions

  
Matrix/MSC

Features pertaining to unstable matrix features

  
Matrix/Media

Features pertaining to media interactions

  
Meta

Related to housekeeping, maintenance, or other repo-meta.

  
Meta/Packaging

Packaging

  
Priority
Blocking
This issue is blocking the next release

  
Priority
High
This issue is very important

  
Priority
Low
This issue is of a rather low priority

  
Security

This item is related to general security

  
Status
Confirmed

  
Status
Duplicate
This issue or pull request already exists

  
Status
Invalid
This issue doesn't seem right

  
Status
Needs Investigation
This issue needs further investigation

  
To-Merge

   
Wont fix

This will not be worked on

  
old/ci/cd

Ci/CD

Archived

  
old/rust

Pull requests that update Rust code

Archived

No labels
Bug
Cherry-picking
Database
Dependencies
Dependencies/Renovate
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/Federation
Matrix/MSC
Matrix/Media
Meta
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
To-Merge
Wont fix
old/ci/cd
old/rust
Milestone
Clear milestone
No items
No milestone
v0.5.0-rc.8
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
continuwuation/continuwuity!926
No description provided.