continuwuation/continuwuity
10
27
Fork 25
Code Issues 89 Pull requests 23 Projects Releases 18 Packages 3 Activity Actions 3

main #974

Closed
jhoninck wants to merge 9 commits from jhoninck/continuwuity:main into main
pull from: jhoninck/continuwuity:main
merge into: continuwuation:main
Conversation 3 Commits 9 Files changed 11 +2750 -7
jhoninck commented 2025-09-02 15:37:34 +00:00
First-time contributor
Copy link

lets hope you can see this:

  1. Moved Documentation to Proper Location
    • Moved from src/core/docs_*.rs to docs/ directory
    • Converted from Rust code to proper Markdown format
    • Renamed files to follow project conventions
    • Updated File Structure:
    • Clean Git History:
      Commit 1: "Enhanced error handling, types, and documentation"
      Commit 2: "Move documentation to proper docs/ directory"
      Branch: feature/enhanced-error-handling-and-types
      Status: Clean working tree, ready for PR
lets hope you can see this: 1. Moved Documentation to Proper Location - Moved from src/core/docs_*.rs to docs/ directory - Converted from Rust code to proper Markdown format - Renamed files to follow project conventions - Updated File Structure: - Clean Git History: Commit 1: "Enhanced error handling, types, and documentation" Commit 2: "Move documentation to proper docs/ directory" Branch: feature/enhanced-error-handling-and-types Status: Clean working tree, ready for PR
Upload files to "docs"
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been cancelled
Details
d85ab0cbdb
Jade requested changes 2025-09-02 15:49:41 +00:00
Jade left a comment
Owner
Copy link
  • What is the purpose of this pull request?
  • Have you tested this with a deployed continuwuity instance?
  • Please follow the contributing guidelines, as mentioned in #972 - your commit messages are not in the correct format, and the formatting & precommit checks are failing
  • The code no longer compiles
- What is the purpose of this pull request? - Have you tested this with a deployed continuwuity instance? - Please follow the contributing guidelines, as mentioned in https://forgejo.ellis.link/continuwuation/continuwuity/issues/972 - your commit messages are not in the correct format, and the formatting & precommit checks are failing - The code no longer compiles
nex requested changes 2025-09-02 15:55:59 +00:00
nex left a comment
Owner
Copy link

Several issues here

  • This PR doesn't do anything of substance
  • You have not followed the code style (particularily the documentation section)
  • You have duplicated content in the docs and source code
  • The documentation and actually most of this code feels like it was generated by a large language model with no real human oversight
  • This PR has not followed our contributing guidelines
  • Your commit history is nonsense, I would suggest doing a rebase and modifying your commit messages to explain what each commit does rather than just "uploaded files"
Several issues here - This PR doesn't do anything of substance - You have not followed the [code style](https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/docs/development/code_style.md) (particularily the documentation section) - You have duplicated content in the docs and source code - The documentation and actually most of this code feels like it was generated by a large language model with no real human oversight - This PR has not followed our [contributing guidelines](https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md) - Your commit history is nonsense, I would suggest doing a rebase and modifying your commit messages to explain what each commit does rather than just "uploaded files"
docs/enhanced_best_practices.md
@ -0,0 +1,148 @@
# Enhanced Best Practices for Continuwuity
nex commented 2025-09-02 15:47:35 +00:00
Owner
Copy link

We already have most of this information in our code style guide

We already have most of this information in our [code style guide](https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/docs/development/code_style.md)
docs/enhanced_examples.md
@ -0,0 +1,128 @@
# Enhanced Examples for Continuwuity
nex commented 2025-09-02 15:48:12 +00:00
Owner
Copy link

This entire file seems unnecessary, examples should be in the file the examples are relevant to

This entire file seems unnecessary, examples should be in the file the examples are relevant to
src/core/docs_api_guide.rs
@ -0,0 +1,408 @@
//! API Guide for Continuwuity Enhanced Types
nex commented 2025-09-02 15:49:42 +00:00
Owner
Copy link

docs should not be in the source code

docs should not be in the source code
src/core/docs_best_practices.rs
@ -0,0 +1,379 @@
//! Best Practices for Continuwuity Development
nex commented 2025-09-02 15:49:53 +00:00
Owner
Copy link

Again, docs should not be in the source code

Again, docs should not be in the source code
src/core/docs_examples.rs
@ -0,0 +1,363 @@
//! Comprehensive Examples for Continuwuity
nex commented 2025-09-02 15:50:05 +00:00
Owner
Copy link

Documentation should not be in the source code

Documentation should not be in the source code
src/core/enhanced.rs
@ -0,0 +1,449 @@
// Enhanced Type Definitions for Continuwuity
nex commented 2025-09-02 15:50:56 +00:00
Owner
Copy link

This feels like you're extracting https://forgejo.ellis.link/continuwuation/ruwuma partially into this project - all of our types and whatnot are kept in an external dependency.

This feels like you're extracting https://forgejo.ellis.link/continuwuation/ruwuma partially into this project - all of our types and whatnot are kept in an external dependency.
src/core/error/enhanced.rs
@ -0,0 +6,4 @@
/// Enhanced error types with better user messaging
#[derive(Error, Debug)]
pub enum EnhancedError {
nex commented 2025-09-02 15:51:22 +00:00
Owner
Copy link

We already have onsite error types, this is duplicating work

We already have onsite error types, this is duplicating work
src/core/error/mod.rs
@ -111,4 +112,2 @@
#[error(transparent)]
IntoHttp(#[from] ruma::api::error::IntoHttpError),
#[error("{0}")]
Ldap(Cow<'static, str>),
nex commented 2025-09-02 15:51:43 +00:00
Owner
Copy link

Why was this removed?

Why was this removed?
src/core/types_enhanced.rs
@ -0,0 +1,449 @@
// Enhanced Type Definitions for Continuwuity
nex commented 2025-09-02 15:52:14 +00:00
Owner
Copy link

Again this is just a partial reimplementation of ruwuma

Again this is just a partial reimplementation of ruwuma
Jade commented 2025-09-02 16:27:48 +00:00
Owner
Copy link

User said:

good luck, have tried to adapt, will stop contributing now

User said: > [good luck, have tried to adapt, will stop contributing now](https://matrix.to/#/!main-1:continuwuity.org/%24byBlIF1ckBcssQLmLM_kaWqGZbTJvN5hQA9NBPg11Pc?via=ellis.link&via=explodie.org&via=matrix.org)
Jade closed this pull request 2025-09-02 16:27:48 +00:00
Some checks are pending
Documentation / Build and Deploy Documentation (pull_request) Has been cancelled
Details
Checks / *
Required

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Jade
nex
Labels
Clear labels   
Bug

Something isn't working as intended

  
Cherry-picking

Commits picked from other conduit projects

  
Database

This requires or includes changes to the database

  
Dependencies

Something dependency related

  
Dependencies/Renovate

Automatic dependency upgrades by Renovate

  
Difficulty
Easy
Low difficulty to implement - touches few parts of the codebase, low complexity

  
Difficulty
Hard
High difficulty to implement - touches many parts of the codebase, high complexity

  
Difficulty
Medium
Medium difficulty to implement - touches more parts of the codebase, higher complexity

  
Documentation

Improvements or additions to documentation

  
Enhancement

New feature or request

  
Good first issue

Good for newcomers

  
Help wanted

Additional eyes and keyboards are required for this one

  
Inherited

Issues that have been inhereted from the project pre-fork

  
Matrix/Administration

Features pertaining to homeserver administration

  
Matrix/Appservices

Features pertaining to the appservice API

  
Matrix/Auth

Features pertaining to authentication

  
Matrix/Client

Features pertaining to client-to-server interactions

  
Matrix/Core

   
Matrix/Federation

Features pertaining to server-to-server interactions

  
Matrix/MSC

Features pertaining to unstable matrix features

  
Matrix/Media

Features pertaining to media interactions

  
Meta

Related to housekeeping, maintenance, or other repo-meta.

  
Meta/Packaging

Packaging

  
Priority
Blocking
This issue is blocking the next release

  
Priority
High
This issue is very important

  
Priority
Low
This issue is of a rather low priority

  
Security

This item is related to general security

  
Status
Confirmed

  
Status
Duplicate
This issue or pull request already exists

  
Status
Invalid
This issue doesn't seem right

  
Status
Needs Investigation
This issue needs further investigation

  
To-Merge

   
Wont fix

This will not be worked on

  
old/ci/cd

Ci/CD

Archived

  
old/rust

Pull requests that update Rust code

Archived

No labels
Bug
Cherry-picking
Database
Dependencies
Dependencies/Renovate
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/Federation
Matrix/MSC
Matrix/Media
Meta
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
To-Merge
Wont fix
old/ci/cd
old/rust
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: continuwuation/continuwuity#974
No description provided.
Delete branch "jhoninck/continuwuity:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?