continuwuation/continuwuity
10
27
Fork 25
Code Issues 89 Pull requests 28 Projects Releases 18 Packages 3 Activity Actions 5

feat: Support omitting members in the send_join response #977

Open
nex wants to merge 2 commits from nex/feat/provide-fast-joins into main
pull from: nex/feat/provide-fast-joins
merge into: continuwuation:main
Conversation 6 Commits 2 Files changed 2 +85 -19
nex commented 2025-09-03 13:21:10 +00:00
Owner
Copy link

This PR allows us to omit membership events in our /send_join endpoint, allowing us to provide fast/partial joins. Joining a room via a continuwuity server with this change should be significantly faster and weigh less on the server itself.

This does not allow us to use fast/partial joins, that is a feature being kinda worked on in nex/feat/fast-joins-hack-do-not-use-DO-NOT-USE (but as the branch name says do not use it)

This PR allows us to omit membership events in our `/send_join` endpoint, allowing us to *provide* fast/partial joins. Joining a room via a continuwuity server with this change should be significantly faster and weigh less on the server itself. This does not allow us to *use* fast/partial joins, that is a feature being kinda worked on in [nex/feat/fast-joins-hack-do-not-use-DO-NOT-USE](https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/nex/feat/fast-joins-hack-do-not-use-DO-NOT-USE) (but as the branch name says *do not use it*)
feat: Support omitting members in the send_join response
All checks were successful
Release Docker Image / define-variables (push) Successful in 4s
Details
Documentation / Build and Deploy Documentation (pull_request) Successful in 43s
Details
Checks / Prek / Pre-commit & Formatting (push) Successful in 1m18s
Details
Checks / Prek / Clippy and Cargo Tests (push) Successful in 5m29s
Details
Release Docker Image / build-image (linux/amd64, release, linux-amd64, base) (push) Successful in 12m14s
Details
Release Docker Image / build-image (linux/arm64, release, linux-arm64, base) (push) Successful in 11m33s
Details
Release Docker Image / merge (push) Successful in 10s
Details
7f06473a64
fix: Omitting redundant entries from the auth_chain caused problems
All checks were successful
Release Docker Image / define-variables (push) Successful in 11s
Details
Documentation / Build and Deploy Documentation (pull_request) Successful in 42s
Details
Checks / Prek / Pre-commit & Formatting (push) Successful in 1m6s
Details
Checks / Prek / Clippy and Cargo Tests (push) Successful in 5m24s
Details
Release Docker Image / build-image (linux/amd64, release, linux-amd64, base) (push) Successful in 12m18s
Details
Release Docker Image / build-image (linux/arm64, release, linux-arm64, base) (push) Successful in 12m51s
Details
Release Docker Image / merge (push) Successful in 11s
Details
8bff0179fe
nex reviewed 2025-09-05 01:35:56 +00:00
src/api/server/send_join.rs
@ -238,6 +258,17 @@ async fn create_join_event(
.rooms
.auth_chain
.event_ids_iter(room_id, starting_events)
// .broad_filter_map(|event_id| async {
nex commented 2025-09-05 01:35:56 +00:00
Author
Owner
Copy link

This was commented out as for whatever reason, not including events in the auth chain that are already in the state object caused synapse to explode. Still, without this, this is already a large improvement. Remove commented code before merge?

This was commented out as for whatever reason, not including events in the auth chain that are already in the state object caused synapse to explode. Still, without this, this is already a large improvement. Remove commented code before merge?
nex reviewed 2025-09-05 01:36:11 +00:00
src/api/server/send_join.rs
@ -257,0 +296,4 @@
.await;
// If there's no servers, just add us
let servers = if servers.is_empty() {
vec![services.globals.server_name().to_string()]
nex commented 2025-09-05 01:36:11 +00:00
Author
Owner
Copy link

This should never happen, but also bees shouldn't be able to fly (this did happen in my testing)

This should never happen, but also bees shouldn't be able to fly (this did happen in my testing)
nex changed title from WIP: feat: Support omitting members in the send_join response to feat: Support omitting members in the send_join response 2025-09-05 01:37:01 +00:00
requested review from Owners 2025-09-05 01:37:15 +00:00
nex reviewed 2025-09-05 01:41:56 +00:00
src/api/server/send_join.rs
@ -211,3 +215,3 @@
drop(mutex_lock);
debug!("Fetching current state IDs");
nex commented 2025-09-05 01:41:56 +00:00
Author
Owner
Copy link

should be trace, it contains no valuable timing information or whatever

should be trace, it contains no valuable timing information or whatever
nex reviewed 2025-09-05 01:42:11 +00:00
src/api/server/send_join.rs
@ -219,9 +223,25 @@ async fn create_join_event(
.collect()
.await;
#[allow(clippy::unnecessary_unwrap)]
nex commented 2025-09-05 01:42:11 +00:00
Author
Owner
Copy link

This wrap is in fact necessary otherwise the warning turns into an error

This wrap is in fact necessary otherwise the warning turns into an error
Jade commented 2025-09-05 01:49:05 +00:00
Owner
Copy link

could use expect to have this comment in the code

could use expect to have this comment in the code
nex reviewed 2025-09-05 01:42:29 +00:00
src/api/server/send_join.rs
@ -257,0 +286,4 @@
let servers_in_room: Option<Vec<_>> = if !omit_members {
None
} else {
debug!("Fetching list of servers in room");
nex commented 2025-09-05 01:42:29 +00:00
Author
Owner
Copy link

Should also be a trace

Should also be a trace
nex reviewed 2025-09-05 01:42:48 +00:00
src/api/server/send_join.rs
@ -257,0 +302,4 @@
};
Some(servers)
};
debug!("Returning send_join data");
nex commented 2025-09-05 01:42:48 +00:00
Author
Owner
Copy link

Another one for trace

Another one for trace
All checks were successful
Release Docker Image / define-variables (push) Successful in 11s
Details
Documentation / Build and Deploy Documentation (pull_request) Successful in 42s
Details
Checks / Prek / Pre-commit & Formatting (push) Successful in 1m6s
Required
Details
Checks / Prek / Clippy and Cargo Tests (push) Successful in 5m24s
Required
Details
Release Docker Image / build-image (linux/amd64, release, linux-amd64, base) (push) Successful in 12m18s
Details
Release Docker Image / build-image (linux/arm64, release, linux-arm64, base) (push) Successful in 12m51s
Details
Release Docker Image / merge (push) Successful in 11s
Details
This pull request is blocked because it's outdated.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin nex/feat/provide-fast-joins:nex/feat/provide-fast-joins
git switch nex/feat/provide-fast-joins
Sign in to join this conversation.
Reviewers
No reviewers
continuwuation/Owners
Labels
Clear labels   
Bug

Something isn't working as intended

  
Cherry-picking

Commits picked from other conduit projects

  
Database

This requires or includes changes to the database

  
Dependencies

Something dependency related

  
Dependencies/Renovate

Automatic dependency upgrades by Renovate

  
Difficulty
Easy
Low difficulty to implement - touches few parts of the codebase, low complexity

  
Difficulty
Hard
High difficulty to implement - touches many parts of the codebase, high complexity

  
Difficulty
Medium
Medium difficulty to implement - touches more parts of the codebase, higher complexity

  
Documentation

Improvements or additions to documentation

  
Enhancement

New feature or request

  
Good first issue

Good for newcomers

  
Help wanted

Additional eyes and keyboards are required for this one

  
Inherited

Issues that have been inhereted from the project pre-fork

  
Matrix/Administration

Features pertaining to homeserver administration

  
Matrix/Appservices

Features pertaining to the appservice API

  
Matrix/Auth

Features pertaining to authentication

  
Matrix/Client

Features pertaining to client-to-server interactions

  
Matrix/Core

   
Matrix/Federation

Features pertaining to server-to-server interactions

  
Matrix/MSC

Features pertaining to unstable matrix features

  
Matrix/Media

Features pertaining to media interactions

  
Meta

Related to housekeeping, maintenance, or other repo-meta.

  
Meta/Packaging

Packaging

  
Priority
Blocking
This issue is blocking the next release

  
Priority
High
This issue is very important

  
Priority
Low
This issue is of a rather low priority

  
Security

This item is related to general security

  
Status
Confirmed

  
Status
Duplicate
This issue or pull request already exists

  
Status
Invalid
This issue doesn't seem right

  
Status
Needs Investigation
This issue needs further investigation

  
To-Merge

   
Wont fix

This will not be worked on

  
old/ci/cd

Ci/CD

Archived

  
old/rust

Pull requests that update Rust code

Archived

No labels
Bug
Cherry-picking
Database
Dependencies
Dependencies/Renovate
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/Federation
Matrix/MSC
Matrix/Media
Meta
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
To-Merge
Wont fix
old/ci/cd
old/rust
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: continuwuation/continuwuity#977
No description provided.
Delete branch "nex/feat/provide-fast-joins"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?