fix(ci): Resolve registry push failures for fork PRs #989
Merged
tcpipuk
merged 1 commit from 2025-09-07 17:17:58 +00:00
tom/conditional-docker-login into main 2025-09-07
fix(ci): Resolve registry push failures for fork PRs
Some checks failed
Release Docker Image / define-variables (pull_request) Successful in 10s
Documentation / Build and Deploy Documentation (pull_request) Successful in 25s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 39s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 4m19s
Release Docker Image / build-image (linux/amd64, release, linux-amd64, base) (pull_request) Successful in 7m42s
Release Docker Image / build-image (linux/arm64, release, linux-arm64, base) (pull_request) Successful in 6m58s
Release Docker Image / merge (pull_request) Successful in 8s
Release Docker Image / define-variables (push) Successful in 14s
Documentation / Build and Deploy Documentation (push) Successful in 30s
Release Docker Image / build-image (linux/amd64, release, linux-amd64, base) (push) Has been cancelled
Release Docker Image / build-image (linux/arm64, release, linux-arm64, base) (push) Has been cancelled
Release Docker Image / merge (push) Has been cancelled
Checks / Prek / Pre-commit & Formatting (push) Successful in 45s
Checks / Prek / Clippy and Cargo Tests (push) Successful in 5m30s
Fork PRs now fail during Docker image build with 'tag is needed when pushing to registry' because BUILTIN_REGISTRY_ENABLED evaluates to false without proper credentials, leaving the images list empty. This appears to be due to recent Forgejo permission changes affecting fork access to repository secrets. Add fallback to official registry when credentials unavailable, skip registry login and push operations for forks, and make merge job conditional since no digests exist without push. This allows forks to test Docker builds whilst avoiding authentication failures.