continuwuation/resolvematrix
8
2
Fork 0
Code Issues 3 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Limit read of well-known file #13

Merged
Jade merged 5 commits from zoe/limit-well-known-read into main 2026-06-26 22:04:18 +00:00
Conversation 4 Commits 5 Files changed 4 +681 -14
s1lv3r commented 2026-06-23 00:37:27 +00:00
Member
Copy link

Recreation of #10 since it decided to close itself and break.

Depends on #11 (#12)

Todo:

  • Tests
Recreation of #10 since it decided to close itself and break. Depends on #11 (#12) Todo: - [x] Tests
s1lv3r self-assigned this 2026-06-23 00:37:27 +00:00
refactor: Move to builder pattern
Some checks failed
Checks / Prek / Pre-commit & Formatting (pull_request) Failing after 1m53s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 2m30s
Details
f581cf166c
 
Note that the original methods still exist, but are marked as deprecated
chore: Formatting
Some checks failed
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 45s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 50s
Details
18bfbb7df0
feat: Limit read of well-known file
Some checks failed
Checks / Prek / Pre-commit & Formatting (pull_request) Failing after 1m57s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 1m12s
Details
75c211b3cc
s1lv3r force-pushed zoe/limit-well-known-read from 75c211b3cc
Some checks failed
Checks / Prek / Pre-commit & Formatting (pull_request) Failing after 1m57s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 1m12s
Details
to 68e3b18118
Some checks failed
Checks / Prek / Pre-commit & Formatting (pull_request) Failing after 1m40s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 2m4s
Details
2026-06-23 21:40:28 +00:00 Compare
s1lv3r changed title from WIP: Limit read of well-known file to Limit read of well-known file 2026-06-23 21:40:57 +00:00
s1lv3r requested review from Jade 2026-06-23 21:41:00 +00:00
fix: fmt
Some checks failed
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 37s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 51s
Details
a3531989fc
fix: Return proper error if well-known too large
All checks were successful
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 34s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 2m3s
Details
0cd62ec1bb
s1lv3r changed title from Limit read of well-known file to WIP: Limit read of well-known file 2026-06-23 23:12:37 +00:00
chore: Add tests
Some checks failed
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m39s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 3m33s
Details
e03ca33326
s1lv3r changed title from WIP: Limit read of well-known file to Limit read of well-known file 2026-06-24 18:16:36 +00:00
fix: Change default to not accept invalid certs
Some checks failed
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 32s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 1m11s
Details
5b350f4885
refactor: Simplify structure for limit_read
Some checks failed
Checks / Prek / Pre-commit & Formatting (pull_request) Failing after 46s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 1m15s
Details
013b764d55
chore: formatting
Some checks failed
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 45s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 1m14s
Details
61ed59684d
fix: Log error when request fails
All checks were successful
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 32s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 4m3s
Details
7b03668037
chore: Update readme
Some checks failed
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 33s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 1m15s
Details
0739f32fee
 
installed+ran prek and cargo-readme
s1lv3r commented 2026-06-24 19:34:24 +00:00
Author
Member
Copy link

ok so the tests are failing because the container cant resolve localhost as a domain

they work fine on any properly setup system, idk how to fix that error

ok so the tests are failing because the container cant resolve localhost as a domain they work fine on any properly setup system, idk how to fix that error
Jade force-pushed zoe/limit-well-known-read from 0739f32fee
Some checks failed
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 33s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 1m15s
Details
to 680758697b
Some checks failed
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 32s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 1m23s
Details
2026-06-26 19:14:33 +00:00 Compare
Jade force-pushed zoe/limit-well-known-read from 680758697b
Some checks failed
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 32s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 1m23s
Details
to 17074e2617
Some checks failed
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 31s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 1m24s
Details
2026-06-26 19:18:11 +00:00 Compare
Jade force-pushed zoe/limit-well-known-read from 17074e2617
Some checks failed
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 31s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 1m24s
Details
to 06da83c134
Some checks failed
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 30s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 1m22s
Details
2026-06-26 19:19:58 +00:00 Compare
Jade force-pushed zoe/limit-well-known-read from 06da83c134
Some checks failed
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 30s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 1m22s
Details
to 9ae7a46637
Some checks failed
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 31s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled
Details
2026-06-26 19:22:05 +00:00 Compare
Jade force-pushed zoe/limit-well-known-read from 9ae7a46637
Some checks failed
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 31s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled
Details
to f7a5fd8198
All checks were successful
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 51s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 2m18s
Details
2026-06-26 19:22:46 +00:00 Compare
Jade commented 2026-06-26 19:24:04 +00:00
Owner
Copy link

test_invalid_well_known fails on my machine, on macos, as well. All others pass, though

test_invalid_well_known fails on my machine, on macos, as well. All others pass, though
Jade force-pushed zoe/limit-well-known-read from f7a5fd8198
All checks were successful
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 51s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 2m18s
Details
to 4010519745
Some checks failed
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 30s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 1m24s
Details
2026-06-26 19:29:16 +00:00 Compare
Jade force-pushed zoe/limit-well-known-read from 4010519745
Some checks failed
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 30s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 1m24s
Details
to 81773475b3
Some checks failed
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 31s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 1m16s
Details
2026-06-26 19:32:25 +00:00 Compare
feat: Use parking_lot
Some checks failed
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 43s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 1m30s
Details
5d843c1754
Jade force-pushed zoe/limit-well-known-read from 5d843c1754
Some checks failed
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 43s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 1m30s
Details
to 81773475b3
Some checks failed
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 31s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 1m16s
Details
2026-06-26 20:01:26 +00:00 Compare
s1lv3r commented 2026-06-26 20:11:26 +00:00
Author
Member
Copy link

Probably happens due to the localhost.localhost, which i believe is technically supposed to resolve everywhere i think? i guess not

Probably happens due to the `localhost.localhost`, which i believe is technically supposed to resolve everywhere i think? i guess not
Jade force-pushed zoe/limit-well-known-read from 81773475b3
Some checks failed
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 31s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 1m16s
Details
to 9cbef6e16f
Some checks failed
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 32s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 1m47s
Details
2026-06-26 20:31:52 +00:00 Compare
fix: Use more compatible localhost domain
Some checks failed
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 31s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 1m45s
Details
Checks / Prek / Pre-commit & Formatting (push) Successful in 31s
Details
Checks / Prek / Clippy and Cargo Tests (push) Has been cancelled
Details
f493f480ed
Jade approved these changes 2026-06-26 22:03:57 +00:00
Jade merged commit f493f480ed into main 2026-06-26 22:04:18 +00:00
s1lv3r deleted branch zoe/limit-well-known-read 2026-07-08 16:35:08 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Jade
Labels
Clear labels   
Compat/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
s1lv3r
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Depends on
#12 Move to builder pattern and split up library
continuwuation/resolvematrix
Reference
continuwuation/resolvematrix!13
No description provided.